mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Alexandre Courbot" <acourbot@nvidia.com>
To: "Christian S. Lima" <christiansantoslima21@gmail.com>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Alex Gaynor" <alex.gaynor@gmail.com>,
	"Boqun Feng" <boqun.feng@gmail.com>,
	"Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <benno.lossin@proton.me>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Trevor Gross" <tmgross@umich.edu>,
	"Danilo Krummrich" <dakr@kernel.org>,
	rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
	~lkcamp/patches@lists.sr.ht, richard120310@gmail.com
Subject: Re: [PATCH v8] rust: transmute: Add methods for FromBytes trait
Date: Fri, 01 Aug 2025 21:26:22 +0900	[thread overview]
Message-ID: <DBR3913BFPSK.18K4JBYOPQVRG@nvidia.com> (raw)
In-Reply-To: <20250624042802.105623-1-christiansantoslima21@gmail.com>

Hi Christian,

Any plan for a v9 soon? I would like to make sure we secure this into
the Nova tree as we are highly dependent on this feature.

On Tue Jun 24, 2025 at 1:28 PM JST, Christian S. Lima wrote:
<snip>
> +// SAFETY: All bit patterns are acceptable values of the types and in array case if all bit patterns
> +// are acceptable for individual values in an array, then all bit patterns are also acceptable
> +// for arrays of that type.
> +unsafe impl<T> FromBytes for T
> +where
> +    T: FromBytesSized,
> +{
> +    fn from_bytes(bytes: &[u8]) -> Option<&Self> {
> +        let slice_ptr = bytes.as_ptr().cast::<T>();
> +        if bytes.len() == ::core::mem::size_of::<T>() && slice_ptr.is_aligned() {

Another small nit: this is not a macro, so you don't need to use the
`::` prefix here. Actually even `size_of::<T>()` seems to work.

  parent reply	other threads:[~2025-08-01 13:22 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-24  4:28 Christian S. Lima
2025-06-25  2:39 ` kernel test robot
2025-07-07  5:14 ` Alexandre Courbot
2025-07-14 22:16   ` Christian
2025-07-22 14:06     ` Alexandre Courbot
2025-07-25 18:37       ` Christian
2025-07-26  2:57         ` Alexandre Courbot
2025-07-27  1:37 ` Kane York
2025-07-28 19:39   ` Christian
2025-07-28 21:21     ` K. York
2025-08-01 12:26 ` Alexandre Courbot [this message]
2025-08-01 15:35   ` Miguel Ojeda
2025-08-01 17:47   ` Christian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DBR3913BFPSK.18K4JBYOPQVRG@nvidia.com \
    --to=acourbot@nvidia.com \
    --cc=a.hindborg@kernel.org \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=benno.lossin@proton.me \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=christiansantoslima21@gmail.com \
    --cc=dakr@kernel.org \
    --cc=gary@garyguo.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ojeda@kernel.org \
    --cc=richard120310@gmail.com \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tmgross@umich.edu \
    --cc=~lkcamp/patches@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®