From: "Danilo Krummrich" <dakr@kernel.org>
To: "Timur Tabi" <ttabi@nvidia.com>
Cc: "phasta@kernel.org" <phasta@kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"nouveau@lists.freedesktop.org" <nouveau@lists.freedesktop.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/nouveau: Remove surplus struct member
Date: Fri, 01 Aug 2025 17:12:19 +0200 [thread overview]
Message-ID: <DBR6S322NP7E.1T932OJTX6A63@kernel.org> (raw)
In-Reply-To: <809d2ff29bb87f782f7a813d67d3d604882db320.camel@nvidia.com>
On Fri Aug 1, 2025 at 4:50 PM CEST, Timur Tabi wrote:
> Does mean that the TODO has been done, or that someone completely forgot and now your patch is
> remove all reminders?
>
> If it's the format, maybe add a fixes: tag for the commit that resolved the TODO?
The TODO was introduced by commit ebb945a94bba ("drm/nouveau: port all engines
to new engine module format") from 2012.
It's a bit hard to know what exactly resolves "this will be reworked in the near
future" for a commit with the following diffstat. :)
146 files changed, 14219 insertions(+), 11099 deletions(-)
The last remains of accel_done were removed with commit
4e2ec2500bfc ("drm/nouveau: Remove file nouveau_fbcon.c"), but I don't think we
should mention this commit, given that apparently no one knows what was intended
to be reworked here [1].
We could mention the above in the commit message, though it will also be
available through the lore link in the commit message once the patch is applied.
NIT: Please don't top post, use interleaved style [2] instead.
[1] https://lore.kernel.org/all/481a2808c235f95726d17803503b2b6dc2746dc3.camel@mailbox.org/
[2] https://docs.kernel.org/process/submitting-patches.html#use-trimmed-interleaved-replies-in-email-discussions
next prev parent reply other threads:[~2025-08-01 15:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-01 7:45 Philipp Stanner
2025-08-01 14:50 ` Timur Tabi
2025-08-01 15:12 ` Danilo Krummrich [this message]
2025-08-01 15:42 ` Timur Tabi
2025-08-01 19:33 ` Philipp Stanner
2025-08-09 12:00 ` Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DBR6S322NP7E.1T932OJTX6A63@kernel.org \
--to=dakr@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=phasta@kernel.org \
--cc=ttabi@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®