mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Brigham Campbell" <me@brighamcampbell.com>
To: "Giant Sand Fans" <rampxxxx@gmail.com>,
	"Dmitry Baryshkov" <dmitry.baryshkov@oss.qualcomm.com>
Cc: <maarten.lankhorst@linux.intel.com>, <mripard@kernel.org>,
	<tzimmermann@suse.de>, <airlied@gmail.com>, <simona@ffwll.ch>,
	<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
	"dri-devel" <dri-devel-bounces@lists.freedesktop.org>
Subject: Re: [PATCH] drm: Add directive to format code in comment
Date: Tue, 05 Aug 2025 10:55:30 -0600	[thread overview]
Message-ID: <DBUNH9S9HCXH.SIOBPAT3U91N@brighamcampbell.com> (raw)
In-Reply-To: <CABPJ0vgz6gib5LdKY1O6uhPq7Tk5GN2X_dcGBwtx3b=TRQUw-Q@mail.gmail.com>

On Tue Aug 5, 2025 at 5:53 AM MDT, Giant Sand Fans wrote:
> On Tue, 5 Aug 2025 at 12:49, Dmitry Baryshkov
> <dmitry.baryshkov@oss.qualcomm.com> wrote:
>> Fixes tag?
>    Sorry, what do you mean?

Dmitry is looking for a tag in the body of your patch (much like your
"Signed-off-by" tag) which describes the commit which introduced the bad
behavior[1]. In this case, it looks like this block was introduced with
the incorrect kerneldoc code block formatting by commit 471920ce25d5, so
the correct Fixes tag would look like the following:

Fixes: 471920ce25d5 ("drm/gpuvm: Add locking helpers")

[1]: https://docs.kernel.org/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes

Cheers,
Brigham

  reply	other threads:[~2025-08-05 16:55 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-04 21:29 Javier Garcia
2025-08-05 10:49 ` Dmitry Baryshkov
2025-08-05 11:53   ` Giant Sand Fans
2025-08-05 16:55     ` Brigham Campbell [this message]
2025-08-05 17:55       ` Giant Sand Fans
2025-08-10 11:22   ` [PATCH v2] " Javier Garcia
2025-08-10 13:23     ` Danilo Krummrich
2025-08-10 14:12       ` Giant Sand Fans
2025-08-10 15:07       ` [PATCH v3] " Javier Garcia
2025-08-11  1:04         ` Bagas Sanjaya
2025-08-15 18:53         ` Danilo Krummrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DBUNH9S9HCXH.SIOBPAT3U91N@brighamcampbell.com \
    --to=me@brighamcampbell.com \
    --cc=airlied@gmail.com \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=dri-devel-bounces@lists.freedesktop.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=rampxxxx@gmail.com \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®