From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EFAF22AEF5 for ; Wed, 6 Aug 2025 12:47:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754484459; cv=none; b=KCPLIUDWOJ23jb0/beh05bVv79oGXVjyd0ywUFxnWLRcXM91tIu2AE4NY9NT0VJmtry6vJejYwC2xxkwpowoeu7d/l6FGknWjcguu/HSopUwHIbxhF83n6dcXtLJDcuk2RTz9gltT1G2IeC2zaR5fVc5vd/HiWYiAsrZoUBq18E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754484459; c=relaxed/simple; bh=uMQQAh8WcEu02JuyRqG+sm8RrNuWu2jygYPIttRgVMs=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=IFmgnjnuq0AAUtKUUylEBUCaE7fqOEUB+t0QYEbaCTyzNoQ0x5aHSH80WNEXnpjr3zmJi9kiS88r+i7jsRao1jqhd2Xb3eRzha2xt/d0C8vACrV72Etk6/GaF5QBQrF/XMJShy/VvV3/cEO9sCcuxFjnJwQF3AizE290TOwCSQM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Y563eKZL; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Y563eKZL" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-3b8de193b60so2049993f8f.0 for ; Wed, 06 Aug 2025 05:47:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1754484455; x=1755089255; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=uMQQAh8WcEu02JuyRqG+sm8RrNuWu2jygYPIttRgVMs=; b=Y563eKZLs+dk82ECbRE0AshTXvJznIRc9cr9MhygBCmWO9RGAjre7XgSyN2uhhG4oL JiV9glDJlbuMJy79Jwq739tZO6+Pur+dXeFYnifU/COFNt3SrUEOUFozPW54qBKZ/+P3 XgA0TCLCs7Xsr8VK9HBBNXzDF43DJLSwkNC0azEfRuwiJR69QSRvniv9YfPPiGwNzzk8 4BHOyz2OBV26cB8qnMiUJSvhlSBX//dUKHa3WyO9UhRwytEaDOXiIXT8/FN3ez1B75D+ WKXigqjr+pJpFNLMG/6FsU5Z+xC1PbV1onB5XpxyDh+9NBawNkpCJbRaMKhXMW8VYXj6 /cgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754484455; x=1755089255; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=uMQQAh8WcEu02JuyRqG+sm8RrNuWu2jygYPIttRgVMs=; b=szwWZ6g0PaSWusEeJiKNOKl+9rG9h6p9wGXiv7ZXDOyBGQDuLxGaTYW70XpnOWX2E9 lqbPqU6PjSXoBJ9ZfcETndvWw+x8O9682ZECLn5FJnbZvdVXiIW15/+HL6b/1uPFL4o2 sgOWdEo3w7c70/IEDjVYAyfzrjRuvyNF9nG7Sj3pM6R29/AjzM/V8T2CTfkPZKvEW3vd w9VrPHde2+U5GgHzeEIgHOJmYDD43B5nyr9mqcyx7pCMUxIsDmGiTFxEJ+jQf2MQvkgF B3jxnPvySCICqbue52raLG/NXCHc0SBOn/WW6hOACeTm9ggxFyUjcteSthyJkoKMJ55A S3Gg== X-Forwarded-Encrypted: i=1; AJvYcCWGAZkwag0L3vH/TJJ3skKu5W1iOMvT/gWi9LJrmUG0KwTfsUhDK7XaWhyA4UxYGbD0X8/qWYg11vFg/ko=@vger.kernel.org X-Gm-Message-State: AOJu0Yw1vWCyLnYClcqEY8B4n4F+CLvqv6BB4RtJoXIqvY1d8/ZXaJZm Fjr8KCYIfCLCttrOXWY/Z/FfBjSBCmzQ8R6eJPC8YaOyP3uLz1Xp5fe/DIigo8ezxdE= X-Gm-Gg: ASbGncuKi9xFcAXroLW9H0GbrZnCsVQDUbo5GwpS78epSVlbDe1n5JYXmeIOHH+D6kh 7WoAg8umLS5cKE8IB5ZG26ITK6Wh8atEPWYwd1YaGMdtIPrL3kmgs6gYNiTrN5JPChfqcL3lRaA P3PIeqtFP9cFnkNzIHEQsnH/dKl5y2/N0TA2x8TiSG530E/VkCm/gAK1PvxkxyWrZeK9bwGzP7g vWrZX0vtOdYzRaypiCwHFoiJ8yCgdFY1lcmj6uNaXGbRw8PpC9Q5TFDguqaKYaZ3VX0AxpKpoZL JStz1aH5AdaA4wTMQM/121rb2P5Fimn3fBASqd7Rbp0C0d1Ve5ykks5M/YZNmn/UeoyzYWhdRhQ /8Ehvs9sg5ZCvGajXyeWVksOjGnY= X-Google-Smtp-Source: AGHT+IHxO9MmitvfhjqylFKRguuox3GDfzQYiukqSwzJ38jFMewGzXEj8G2vcOvegX7ujhbfTAcxKg== X-Received: by 2002:a05:6000:188f:b0:3b8:d16a:a4b1 with SMTP id ffacd0b85a97d-3b8f420ee27mr2057195f8f.58.1754484454941; Wed, 06 Aug 2025 05:47:34 -0700 (PDT) Received: from localhost ([2a00:2381:fd67:101:6c39:59e6:b76d:825]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b79c453aeasm23738876f8f.40.2025.08.06.05.47.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Aug 2025 05:47:34 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 06 Aug 2025 13:47:33 +0100 Message-Id: Cc: , , , , , , , , , , Subject: Re: [PATCH v2] arm64: dts: qcom: sm8750: Add adsp fastrpc nodes/support From: "Alexey Klimov" To: "Bjorn Andersson" X-Mailer: aerc 0.20.0 References: <20250805162041.47412-1-alexey.klimov@linaro.org> In-Reply-To: On Wed Aug 6, 2025 at 1:25 AM BST, Bjorn Andersson wrote: Previous version was sent few months back. > On Tue, Aug 05, 2025 at 05:20:41PM +0100, Alexey Klimov wrote: >> While at this, also add required memory region for adsp fastrpc. > > Please https://docs.kernel.org/process/submitting-patches.html#describe-y= our-changes > rather than lazily continue the subject. Ok. It also seems that some other commits that were merged doesn't really describe addition of fastrpc nodes well. > Also, the way you wrote this makes me believe adsp_rpc_remote_heap_mem > is optional, and as I don't know what it's for I don't understand why > that would be part of this patch. Yeah, after looking further at the bindings I agree that this should be described better. Although some of this is confusing: >required memory region >adsp_rpc_remote_heap_mem is optional Anyhow this mem region seems to be optional so I'll try to split it into two patches (need to check that dtbs check will be happy with that). It also seems that when adsp_rpc_remote_heap_mem was merged for other dtsi-es then no questions were asked. >> Tested on sm8750-mtp device with adsprpdcd. > > Just adsprpdcd? Yeah, I forgot to mention that getserial can libcalculator tests. > Is that sufficient to say that fastrpc is functional? Or > at least that the information here is sufficiently tested? The testing of fastrpc for adsp is quite limited. If you or Qualcomm can provide the usable tests to run and verify then please do so. I think what happens is that often the info for fastrpc nodes just being copied and filled in with info from downstream with no requests to provide test results. Here it was tested with adsprpdcd with compressed playback and two tests above I forgot to mention. [..] Thanks, Alexey