From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762209AbdEVUbh convert rfc822-to-8bit (ORCPT ); Mon, 22 May 2017 16:31:37 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:39457 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755309AbdEVUbd (ORCPT ); Mon, 22 May 2017 16:31:33 -0400 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: [PATCH] xprtrdma: Delete an error message for a failed memory allocation in xprt_rdma_bc_setup() From: Chuck Lever In-Reply-To: <3c3f0067-1438-129c-d921-e2c056d5776b@users.sourceforge.net> Date: Mon, 22 May 2017 16:31:08 -0400 Cc: Linux NFS Mailing List , netdev@vger.kernel.org, Anna Schumaker , "David S. Miller" , "J. Bruce Fields" , Jeff Layton , Trond Myklebust , LKML , kernel-janitors@vger.kernel.org Content-Transfer-Encoding: 8BIT Message-Id: References: <3c3f0067-1438-129c-d921-e2c056d5776b@users.sourceforge.net> To: SF Markus Elfring X-Mailer: Apple Mail (2.3124) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On May 22, 2017, at 4:24 PM, SF Markus Elfring wrote: > > From: Markus Elfring > Date: Mon, 22 May 2017 22:18:28 +0200 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle software. > > Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf > Signed-off-by: Markus Elfring Reviewed-by: Chuck Lever > --- > net/sunrpc/xprtrdma/backchannel.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/net/sunrpc/xprtrdma/backchannel.c b/net/sunrpc/xprtrdma/backchannel.c > index 24fedd4b117e..03f6b5840764 100644 > --- a/net/sunrpc/xprtrdma/backchannel.c > +++ b/net/sunrpc/xprtrdma/backchannel.c > @@ -119,11 +119,9 @@ int xprt_rdma_bc_setup(struct rpc_xprt *xprt, unsigned int reqs) > > for (i = 0; i < (reqs << 1); i++) { > rqst = kzalloc(sizeof(*rqst), GFP_KERNEL); > - if (!rqst) { > - pr_err("RPC: %s: Failed to create bc rpc_rqst\n", > - __func__); > + if (!rqst) > goto out_free; > - } > + > dprintk("RPC: %s: new rqst %p\n", __func__, rqst); > > rqst->rq_xprt = &r_xprt->rx_xprt; > -- > 2.13.0 -- Chuck Lever