mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "J, KEERTHY" <j-keerthy@ti.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: "Cousson, Benoit" <b-cousson@ti.com>,
	"devicetree-discuss@lists.ozlabs.org" 
	<devicetree-discuss@lists.ozlabs.org>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"ldewangan@nvidia.com" <ldewangan@nvidia.com>,
	"grant.likely@secretlab.ca" <grant.likely@secretlab.ca>,
	"swarren@wwwdotorg.org" <swarren@wwwdotorg.org>,
	"swarren@nvidia.com" <swarren@nvidia.com>,
	"sameo@linux.intel.com" <sameo@linux.intel.com>,
	"gg@slimlogic.co.uk" <gg@slimlogic.co.uk>
Subject: RE: [PATCH 2/2] ARM: dts: OMAP5: add palmas node and omap specific palmas regulator properties
Date: Mon, 10 Jun 2013 08:19:09 +0000	[thread overview]
Message-ID: <DC88CAD03C0052499C1907B327FC63229EAAC8@DBDE04.ent.ti.com> (raw)
In-Reply-To: <20130610081208.GD24958@gmail.com>

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 6134 bytes --]

Hello Lee Jones,

> -----Original Message-----
> From: Lee Jones [mailto:lee.jones@linaro.org]
> Sent: Monday, June 10, 2013 1:42 PM
> To: J, KEERTHY
> Cc: Cousson, Benoit; devicetree-discuss@lists.ozlabs.org; linux-
> omap@vger.kernel.org; linux-kernel@vger.kernel.org;
> ldewangan@nvidia.com; grant.likely@secretlab.ca; swarren@wwwdotorg.org;
> swarren@nvidia.com; sameo@linux.intel.com; gg@slimlogic.co.uk
> Subject: Re: [PATCH 2/2] ARM: dts: OMAP5: add palmas node and omap
> specific palmas regulator properties
> 
> > Add palmas node and omap specific palmas regulator properties.
> >
> > This patch is based on:
> >
> > 	git://git.kernel.org/pub/scm/linux/kernel/git/bcousson/linux-
> omap-dt.git
> > 	for_3.11/dts
> 
> There's no need for this to be in the commit message.
> 

Ok. I will remove this.

> > Boot tested on omap5-uevm board.
> >
> > Signed-off-by: J Keerthy <j-keerthy@ti.com>
> > ---
> >  arch/arm/boot/dts/omap5-uevm.dts |  145
> > ++++++++++++++++++++++++++++++++++++++
> >  1 files changed, 145 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/omap5-uevm.dts
> > b/arch/arm/boot/dts/omap5-uevm.dts
> > index 927db1e..88172db 100644
> > --- a/arch/arm/boot/dts/omap5-uevm.dts
> > +++ b/arch/arm/boot/dts/omap5-uevm.dts
> > @@ -254,6 +254,151 @@
> >  	pinctrl-0 = <&i2c1_pins>;
> >
> >  	clock-frequency = <400000>;
> > +
> > +	palmas: palmas@48 {
> > +		reg = <0x48>;
> > +		/* SPI = 0, IRQ# = 7, 4 = active high level-sensitive */
> 
> The interrupt property is fairly ubiqutous. There's not really any need
> to document it in this manor.
> 
> > +		interrupts = <0 7 4>; /* IRQ_SYS_1N cascaded to gic */
> 
> Use the IRQ includes in dt-bindings.

Oops Yes I will include.

> 
> > +		interrupt-parent = <&gic>;
> > +	};
> > +
> > +};
> > +
> > +#include "palmas.dtsi"
> 
> I'm a bit confused by this. Is it now common practice to break out
> nodes in this way? I assume to counter mass indentation, but it's a bit
> alien to me.
> 
> > +&palmas {
> > +	palmas_pmic {
> > +		ti,ldo6-vibrator;
> > +
> > +		regulators {
> > +			smps123_reg: smps123 {
> > +				regulator-min-microvolt = < 600000>;
> > +				regulator-max-microvolt = <1500000>;
> > +				regulator-always-on;
> > +				regulator-boot-on;
> > +			};
> 
> Are these all board specific, or are they shared with any other
> platform?

Yes. Hence moved all of them to board file as compared to my
Last approach when I had kept all of them under palmas.dtsi.

> 
> > +			smps45_reg: smps45 {
> > +				regulator-min-microvolt = < 600000>;
> > +				regulator-max-microvolt = <1310000>;
> > +				regulator-always-on;
> > +				regulator-boot-on;
> > +			};
> > +
> > +			smps6_reg: smps6 {
> > +				regulator-min-microvolt = <1200000>;
> > +				regulator-max-microvolt = <1200000>;
> > +				regulator-always-on;
> > +				regulator-boot-on;
> > +			};
> > +
> > +			smps7_reg: smps7 {
> > +				regulator-min-microvolt = <1800000>;
> > +				regulator-max-microvolt = <1800000>;
> > +				regulator-always-on;
> > +				regulator-boot-on;
> > +			};
> > +
> > +			smps8_reg: smps8 {
> > +				regulator-min-microvolt = < 600000>;
> > +				regulator-max-microvolt = <1310000>;
> > +				regulator-always-on;
> > +				regulator-boot-on;
> > +			};
> > +
> > +			smps9_reg: smps9 {
> > +				regulator-min-microvolt = <2100000>;
> > +				regulator-max-microvolt = <2100000>;
> > +				regulator-always-on;
> > +				regulator-boot-on;
> > +				ti,smps-range = <0x80>;
> > +			};
> > +
> > +			smps10_reg: smps10 {
> > +				regulator-min-microvolt = <5000000>;
> > +				regulator-max-microvolt = <5000000>;
> > +				regulator-always-on;
> > +				regulator-boot-on;
> > +			};
> > +
> > +			ldo1_reg: ldo1 {
> > +				regulator-min-microvolt = <2800000>;
> > +				regulator-max-microvolt = <2800000>;
> > +				regulator-always-on;
> > +				regulator-boot-on;
> > +			};
> > +
> > +			ldo2_reg: ldo2 {
> > +				regulator-min-microvolt = <2900000>;
> > +				regulator-max-microvolt = <2900000>;
> > +				regulator-always-on;
> > +				regulator-boot-on;
> > +			};
> > +
> > +			ldo3_reg: ldo3 {
> > +				regulator-min-microvolt = <3000000>;
> > +				regulator-max-microvolt = <3000000>;
> > +				regulator-always-on;
> > +				regulator-boot-on;
> > +			};
> > +
> > +			ldo4_reg: ldo4 {
> > +				regulator-min-microvolt = <2200000>;
> > +				regulator-max-microvolt = <2200000>;
> > +				regulator-always-on;
> > +				regulator-boot-on;
> > +			};
> > +
> > +			ldo5_reg: ldo5 {
> > +				regulator-min-microvolt = <1800000>;
> > +				regulator-max-microvolt = <1800000>;
> > +				regulator-always-on;
> > +				regulator-boot-on;
> > +			};
> > +
> > +			ldo6_reg: ldo6 {
> > +				regulator-min-microvolt = <1500000>;
> > +				regulator-max-microvolt = <1500000>;
> > +				regulator-always-on;
> > +				regulator-boot-on;
> > +			};
> > +
> > +			ldo7_reg: ldo7 {
> > +				regulator-min-microvolt = <1500000>;
> > +				regulator-max-microvolt = <1500000>;
> > +				regulator-always-on;
> > +				regulator-boot-on;
> > +			};
> > +
> > +			ldo8_reg: ldo8 {
> > +				regulator-min-microvolt = <1500000>;
> > +				regulator-max-microvolt = <1500000>;
> > +				regulator-always-on;
> > +				regulator-boot-on;
> > +			};
> > +
> > +			ldo9_reg: ldo9 {
> > +				regulator-min-microvolt = <1800000>;
> > +				regulator-max-microvolt = <3300000>;
> > +				regulator-always-on;
> > +				regulator-boot-on;
> > +			};
> > +
> > +			ldoln_reg: ldoln {
> > +				regulator-min-microvolt = <1800000>;
> > +				regulator-max-microvolt = <1800000>;
> > +				regulator-always-on;
> > +				regulator-boot-on;
> > +			};
> > +
> > +			ldousb_reg: ldousb {
> > +				regulator-min-microvolt = <3250000>;
> > +				regulator-max-microvolt = <3250000>;
> > +				regulator-always-on;
> > +				regulator-boot-on;
> > +			};
> > +		};
> > +	};
> >  };
> >
> >  &i2c5 {
> 
> --
> Lee Jones
> Linaro ST-Ericsson Landing Team Lead
> Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook
> | Twitter | Blog
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

      reply	other threads:[~2013-06-10  8:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-10  6:22 [PATCH 0/2] ARM: dts: Add palmas dtsi J Keerthy
2013-06-10  6:22 ` [PATCH 1/2] ARM: dts: add dtsi for palmas J Keerthy
2013-06-10  6:22 ` [PATCH 2/2] ARM: dts: OMAP5: add palmas node and omap specific palmas regulator properties J Keerthy
2013-06-10  8:12   ` Lee Jones
2013-06-10  8:19     ` J, KEERTHY [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DC88CAD03C0052499C1907B327FC63229EAAC8@DBDE04.ent.ti.com \
    --to=j-keerthy@ti.com \
    --cc=b-cousson@ti.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=gg@slimlogic.co.uk \
    --cc=grant.likely@secretlab.ca \
    --cc=ldewangan@nvidia.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=sameo@linux.intel.com \
    --cc=swarren@nvidia.com \
    --cc=swarren@wwwdotorg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®