From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754813Ab3FLING (ORCPT ); Wed, 12 Jun 2013 04:13:06 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:45077 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752512Ab3FLINB convert rfc822-to-8bit (ORCPT ); Wed, 12 Jun 2013 04:13:01 -0400 From: "J, KEERTHY" To: Stephen Warren CC: "Cousson, Benoit" , "devicetree-discuss@lists.ozlabs.org" , "linux-omap@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "ldewangan@nvidia.com" , "grant.likely@secretlab.ca" , "swarren@nvidia.com" , "sameo@linux.intel.com" , "gg@slimlogic.co.uk" , "lee.jones@linaro.org" Subject: RE: [PATCH v3] ARM: dts: OMAP5: Add palmas MFD node and regulator nodes Thread-Topic: [PATCH v3] ARM: dts: OMAP5: Add palmas MFD node and regulator nodes Thread-Index: AQHOZmUya78ZBPBLBEOVPb41xb+GK5kwJwiAgAGU79A= Date: Wed, 12 Jun 2013 08:12:37 +0000 Message-ID: References: <1370928651-6278-1-git-send-email-j-keerthy@ti.com> <51B749E7.6070808@wwwdotorg.org> In-Reply-To: <51B749E7.6070808@wwwdotorg.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.24.170.142] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: Stephen Warren [mailto:swarren@wwwdotorg.org] > Sent: Tuesday, June 11, 2013 9:32 PM > To: J, KEERTHY > Cc: Cousson, Benoit; devicetree-discuss@lists.ozlabs.org; linux- > omap@vger.kernel.org; linux-kernel@vger.kernel.org; > ldewangan@nvidia.com; grant.likely@secretlab.ca; swarren@nvidia.com; > sameo@linux.intel.com; gg@slimlogic.co.uk; lee.jones@linaro.org > Subject: Re: [PATCH v3] ARM: dts: OMAP5: Add palmas MFD node and > regulator nodes > > On 06/10/2013 11:30 PM, J Keerthy wrote: > > This patch adds Palmas MFD node and the regulator nodes for OMAP5. > > > > The node definitions are based on: https://lkml.org/lkml/2013/6/6/25 > > > > Boot tested on omap5-uevm board. > > > diff --git a/arch/arm/boot/dts/omap5-uevm.dts > > b/arch/arm/boot/dts/omap5-uevm.dts > > > + palmas: palmas@48 { > > + reg = <0x48>; > > + interrupts = ; /* IRQ_SYS_1N > */ > > + interrupt-parent = <&gic>; > > + }; > > +}; > > + > > +&palmas { > > + compatible = "ti,palmas"; > > + interrupt-controller; > > + #interrupt-cells = <2>; > > I don't really see the point of splitting the node into two parts if > it's all going into a single file. It made sense if part of the node > came from a common .dtsi file, but not so much when it doesn't. The intent was to reduce indentation and to declare its sub-nodes outside of i2c1. I will club it and resend. Regards, Keerthy