mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rune Torgersen" <runet@innovsys.com>
To: "Scott Wood" <scottwood@freescale.com>,
	"Dan Malek" <dan@embeddedalley.com>
Cc: <linuxppc-embedded@ozlabs.org>, <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH4/4] [POWERPC] Fix cpm_uart driver
Date: Wed, 26 Sep 2007 15:32:29 -0500	[thread overview]
Message-ID: <DCEAAC0833DD314AB0B58112AD99B93B0368C44B@ismail.innsys.innovsys.com> (raw)
In-Reply-To: <46F8101E.1050000@freescale.com>

> From: Scott Wood
> Maybe that's how it was, but the current code initializes it (more or
> less) directly with IMAP_ADDR, which also gets fed into ioremap.
> 
> One of the two has got to be wrong.

arch/ppc maps the immr area 1:1 into kernel memory, so ioremap and
physical are the same.
See arch/ppc/syslib/m8260_setup.c, line 208 (function m8260_map_io)

Here quoted:
arch/ppc/syslib/m8260_setup.c
196 /* Map the IMMR, plus anything else we can cover
197  * in that upper space according to the memory controller
198  * chip select mapping.  Grab another bunch of space
199  * below that for stuff we can't cover in the upper.
200  */
201 static void __init
202 m8260_map_io(void)
203 {
204         uint addr;
205
206         /* Map IMMR region to a 256MB BAT */
207         addr = (cpm2_immr != NULL) ? (uint)cpm2_immr : CPM_MAP_ADDR;
208         io_block_mapping(addr, addr, 0x10000000, _PAGE_IO);
209
210         /* Map I/O region to a 256MB BAT */
211         io_block_mapping(IO_VIRT_ADDR, IO_PHYS_ADDR, 0x10000000,
_PAGE_IO);
212 }

  reply	other threads:[~2007-09-26 20:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-23 20:17 Jochen Friedrich
2007-09-24 15:57 ` Scott Wood
2007-09-24 17:06   ` Jochen Friedrich
2007-09-24 18:22     ` Scott Wood
2007-09-24 19:16       ` Dan Malek
2007-09-24 19:29         ` Scott Wood
2007-09-26 20:32           ` Rune Torgersen [this message]
2007-09-26 20:41             ` Scott Wood
2007-09-25 12:09       ` Jochen Friedrich
2007-09-25 15:11         ` Scott Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DCEAAC0833DD314AB0B58112AD99B93B0368C44B@ismail.innsys.innovsys.com \
    --to=runet@innovsys.com \
    --cc=dan@embeddedalley.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-embedded@ozlabs.org \
    --cc=scottwood@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®