From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751524AbbGBEoa (ORCPT ); Thu, 2 Jul 2015 00:44:30 -0400 Received: from mail-pd0-f171.google.com ([209.85.192.171]:34368 "EHLO mail-pd0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750943AbbGBEoY convert rfc822-to-8bit (ORCPT ); Thu, 2 Jul 2015 00:44:24 -0400 References: <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <54720DEB.4060109@users.sourceforge.net> <20141124101006.GD4241@x1> <5473736F.8070705@users.sourceforge.net> <558FE386.7060704@users.sourceforge.net> <20150701080612.GG3210@x1> <5593C14A.8020700@users.sourceforge.net> Mime-Version: 1.0 (1.0) In-Reply-To: <5593C14A.8020700@users.sourceforge.net> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8BIT Message-Id: Cc: Lee Jones , Jean-Christophe Plagniol-Villard , Tomi Valkeinen , "linux-fbdev@vger.kernel.org" , Linux Kernel Mailing List , "kernel-janitors@vger.kernel.org" , Julia Lawall , jingoo1han@gmail.com X-Mailer: iPhone Mail (11D257) From: Jingoo Han Subject: Re: [PATCH v3] video-lp8788: Delete a check before backlight_device_unregister() Date: Thu, 2 Jul 2015 13:44:13 +0900 To: SF Markus Elfring Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On 2015. 7. 1., at PM 7:30, SF Markus Elfring wrote: > > From: Markus Elfring > Date: Wed, 1 Jul 2015 12:08:31 +0200 > > The backlight_device_unregister() function tests whether its argument > is NULL and then returns immediately. > Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring It looks good. Acked-by: Jingoo Han > --- > drivers/video/backlight/lp8788_bl.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/video/backlight/lp8788_bl.c b/drivers/video/backlight/lp8788_bl.c > index e418d5b..5d583d7 100644 > --- a/drivers/video/backlight/lp8788_bl.c > +++ b/drivers/video/backlight/lp8788_bl.c > @@ -221,8 +221,7 @@ static void lp8788_backlight_unregister(struct lp8788_bl *bl) > { > struct backlight_device *bl_dev = bl->bl_dev; > > - if (bl_dev) > - backlight_device_unregister(bl_dev); > + backlight_device_unregister(bl_dev); > } > > static ssize_t lp8788_get_bl_ctl_mode(struct device *dev, > -- > 2.4.5 >