From: "Javier Carrasco" <javier.carrasco.cruz@gmail.com>
To: dimitri.fedrau@liebherr.com, "Li peiyu" <579lpy@gmail.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Dimitri Fedrau" <dima.fedrau@gmail.com>
Cc: "Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
<linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
"Chris Lesiak" <chris.lesiak@licorbio.com>
Subject: Re: [PATCH v2 1/2] iio: humditiy: hdc3020: fix units for temperature and humidity measurement
Date: Tue, 02 Sep 2025 20:05:47 +0800 [thread overview]
Message-ID: <DCIAUP552XK1.10SMMK7H3VAVH@gmail.com> (raw)
In-Reply-To: <20250901-hdc3020-units-fix-v2-1-082038a15917@liebherr.com>
On Tue Sep 2, 2025 at 1:51 AM CST, Dimitri Fedrau via B4 Relay wrote:
> From: Dimitri Fedrau <dimitri.fedrau@liebherr.com>
>
> According to the ABI the units after application of scale and offset are
> milli degrees for temperature measurements and milli percent for relative
> humidity measurements. Currently the resulting units are degree celsius for
> temperature measurements and percent for relative humidity measurements.
> Change scale factor to fix this issue.
>
> Fixes: c9180b8e39be ("iio: humidity: Add driver for ti HDC302x humidity sensors")
> Reported-by: Chris Lesiak <chris.lesiak@licorbio.com>
> Suggested-by: Chris Lesiak <chris.lesiak@licorbio.com>
> Signed-off-by: Dimitri Fedrau <dimitri.fedrau@liebherr.com>
> ---
> drivers/iio/humidity/hdc3020.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/humidity/hdc3020.c b/drivers/iio/humidity/hdc3020.c
> index ffb25596d3a8bad01d1f84a9a972561266f65d76..8aa567d9aded9cab461f1f905b6b5ada721ba2f0 100644
> --- a/drivers/iio/humidity/hdc3020.c
> +++ b/drivers/iio/humidity/hdc3020.c
> @@ -301,9 +301,9 @@ static int hdc3020_read_raw(struct iio_dev *indio_dev,
> case IIO_CHAN_INFO_SCALE:
> *val2 = 65536;
> if (chan->type == IIO_TEMP)
> - *val = 175;
> + *val = 175 * MILLI;
> else
> - *val = 100;
> + *val = 100 * MILLI;
> return IIO_VAL_FRACTIONAL;
>
> case IIO_CHAN_INFO_OFFSET:
Reviewed-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
next prev parent reply other threads:[~2025-09-02 12:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-01 17:51 [PATCH v2 0/2] iio: humditiy: hdc3020: fix units Dimitri Fedrau via B4 Relay
2025-09-01 17:51 ` [PATCH v2 1/2] iio: humditiy: hdc3020: fix units for temperature and humidity measurement Dimitri Fedrau via B4 Relay
2025-09-02 12:05 ` Javier Carrasco [this message]
2025-09-01 17:51 ` [PATCH v2 2/2] iio: humditiy: hdc3020: fix units for thresholds and hysteresis Dimitri Fedrau via B4 Relay
2025-09-02 12:04 ` Javier Carrasco
2025-09-02 12:51 ` Dimitri Fedrau
2025-09-02 12:47 ` Andy Shevchenko
2025-09-02 13:54 ` Dimitri Fedrau
2025-09-02 14:22 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DCIAUP552XK1.10SMMK7H3VAVH@gmail.com \
--to=javier.carrasco.cruz@gmail.com \
--cc=579lpy@gmail.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=andy@kernel.org \
--cc=chris.lesiak@licorbio.com \
--cc=dima.fedrau@gmail.com \
--cc=dimitri.fedrau@liebherr.com \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®