From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-182.mta0.migadu.com (out-182.mta0.migadu.com [91.218.175.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 69789136E37 for ; Sat, 6 Sep 2025 11:34:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757158449; cv=none; b=KLG0tgDWdH3BhuyqI9nXmu+r2O97uJJSyLUB4Xrg1N27tCSNxfN0ETZrQpuFZShY4vt2CTvSyjfA8fRz4RUXMGBI2XV+Sr02hBZprrrTrNhC9CUFHa8WLp1ke6FTGKv+AXu4hOTaikS/znNGV9OQGvzDZIqJrnSsfvOJRRm7pY8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757158449; c=relaxed/simple; bh=E12fbjI2HTRA7ZkfyKKtfQFoU8haiXawCcbz5HNdrcM=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=tvX7P/dPPF7clh4+ITUozikgvtBPZRc5GBnMhjX1bv3umauVrBbxUnHVBoJSPgPT4f7M3pKtGRL+4KU4XHDRdVFfiuZfQP1xMbm7wt96TjvTWA5/vHjmvsdI/5sr82Sblv0v42ZTT9Qdr+pLcIzU9Vesdqc9TwxQoHYYHttl9g8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=cknow.org; spf=pass smtp.mailfrom=cknow.org; dkim=pass (2048-bit key) header.d=cknow.org header.i=@cknow.org header.b=dyFLZBBF; arc=none smtp.client-ip=91.218.175.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=cknow.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cknow.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cknow.org header.i=@cknow.org header.b="dyFLZBBF" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cknow.org; s=key1; t=1757158442; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=b+Du9TeIxlEbNhvp61SYY8KuLIZkAqncV6TyBj9h6w4=; b=dyFLZBBFQ3+fJrBybmZ30Ba9rVjhUCsCr/fFpHSIuXFcfGEdnYs6CsyuB+nkg/q+SYdDiM awuWCwVrXjZMBp2hNApyssaAvyMC9X67o/GyMrWC1nbqHBkius1OHU/6jEMgBGWLDWCzIF p423/DIc7w/h0l4nBj1SASmAsOeKs7gDdwezyyYloch8+IUpKPDs+P/JodR3ZQULROR1sE uyunYJfcZ0RxF2SJJpV7RRo9xP5LUK9p0FWF8EnAsklMQhPMN0vYzZ0G+63l8ShA+d1gY9 no8sG2t+eyxEqYUOPIlroUM64WnMFUw8EuFl9NP5PujRF+RIKATjkEISR7LYGA== Content-Type: multipart/signed; boundary=71e10b725da0bb370e79d95e44ae5bd5e7d2c935e23050771e2938286b81; micalg=pgp-sha512; protocol="application/pgp-signature" Date: Sat, 06 Sep 2025 13:33:52 +0200 Message-Id: Cc: "Alex Bee" Subject: Re: [PATCH v2 1/2] arm64: dts: rockchip: add GPU powerdomain, opps, and cooling to rk3328 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Diederik de Haas" To: "Christian Hewitt" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Heiko Stuebner" , , , , References: <20250906112030.1829706-1-christianshewitt@gmail.com> In-Reply-To: <20250906112030.1829706-1-christianshewitt@gmail.com> X-Migadu-Flow: FLOW_OUT --71e10b725da0bb370e79d95e44ae5bd5e7d2c935e23050771e2938286b81 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 On Sat Sep 6, 2025 at 1:20 PM CEST, Christian Hewitt wrote: > From: Alex Bee > > Add GPU powerdomain, opp-table, and cooling map nodes for the Mali > GPU on the RK3328 SoC. Opp-table frequencies are sourced from the > Rockchip Linux v4.4 vendor kernel while voltages have been derived > from practical use and support work: keeping voltage above 1075mV > and disabling the 500MHz opp-point avoids instability and crashes. > > Signed-off-by: Alex Bee > Signed-off-by: Christian Hewitt > --- > Changes since v1: > - Use opp_table_gpu not gpu_opp_table to fix dtb schema warnings > > arch/arm64/boot/dts/rockchip/rk3328.dtsi | 39 +++++++++++++++++++++++- > 1 file changed, 38 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi b/arch/arm64/boot/d= ts/rockchip/rk3328.dtsi > index 6438c969f9d7..01ed2bfa7ee1 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi > @@ -331,6 +331,11 @@ power: power-controller { > #address-cells =3D <1>; > #size-cells =3D <0>; > =20 > + power-domain@RK3328_PD_GPU { > + reg =3D ; > + clocks =3D <&cru ACLK_GPU>; > + #power-domain-cells =3D <0>; > + }; > power-domain@RK3328_PD_HEVC { > reg =3D ; > clocks =3D <&cru SCLK_VENC_CORE>; > @@ -570,9 +575,13 @@ map0 { > <&cpu3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > contribution =3D <4096>; > }; > + map1 { > + trip =3D <&target>; > + cooling-device =3D <&gpu THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > + contribution =3D <4096>; > + }; > }; > }; > - > }; > =20 > tsadc: tsadc@ff250000 { > @@ -651,7 +660,35 @@ gpu: gpu@ff300000 { > "ppmmu1"; > clocks =3D <&cru ACLK_GPU>, <&cru ACLK_GPU>; > clock-names =3D "bus", "core"; > + operating-points-v2 =3D <&opp_table_gpu>; > + power-domains =3D <&power RK3328_PD_GPU>; > resets =3D <&cru SRST_GPU_A>; > + #cooling-cells =3D <2>; > + }; > + > + opp_table_gpu: opp-table-gpu { > + compatible =3D "operating-points-v2"; > + opp-200000000 { > + opp-hz =3D /bits/ 64 <200000000>; > + opp-microvolt =3D <1075000>; > + }; > + > + opp-300000000 { > + opp-hz =3D /bits/ 64 <300000000>; > + opp-microvolt =3D <1075000>; > + }; > + > + opp-400000000 { > + opp-hz =3D /bits/ 64 <400000000>; > + opp-microvolt =3D <1075000>; > + }; > + > + opp-500000000 { > + /* causes stability issues */ > + opp-hz =3D /bits/ 64 <500000000>; > + opp-microvolt =3D <1150000>; > + status =3D "disabled"; > + }; The opp-table-gpu should be moved downwards, right above the pinctrl node. But maybe that can be done by Heiko when committing? Cheers, Diederik > }; > =20 > h265e_mmu: iommu@ff330200 { --71e10b725da0bb370e79d95e44ae5bd5e7d2c935e23050771e2938286b81 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQT1sUPBYsyGmi4usy/XblvOeH7bbgUCaLwcIwAKCRDXblvOeH7b br56AQCWWWvp8dGJgHCWZPupIEljTv62eHRRlJgagXNls350nAD9EjoJ2samkkdH 662TWxKU0z5ftvwqQy8+keNZBlbmpgA= =SwUq -----END PGP SIGNATURE----- --71e10b725da0bb370e79d95e44ae5bd5e7d2c935e23050771e2938286b81--