Hi Guenter, > > static const struct of_device_id sl28cpld_hwmon_of_match[] = { > > - { .compatible = "kontron,sl28cpld-fan" }, > > + { .compatible = "kontron,sl28cpld-fan", .data = &sl28cpld_hwmon_chip_info }, > > + { .compatible = "kontron,sa67mcu-hwmon", .data = &sa67mcu_hwmon_chip_info }, > > Effectively this means that the two chips have completely different functionality. > One reports fan speeds, the other reports voltages and current. > This should be a separate driver. Fair enough. I wasn't sure, the reason why I've chosen to add it to the sl28cpld driver was that I don't want to clutter the directory with many small board specific drivers. They all have the simple-mfd parent driver in common. In the end it's up to you of course, so separate driver? -michael