Re: [PATCH v4 1/3] rust: i2c: add basic I2C device and driver abstractions

["Danilo Krummrich" <dakr@kernel.org>]

On Tue Sep 9, 2025 at 7:53 PM CEST, Daniel Almeida wrote:
>> On 9 Sep 2025, at 14:19, Igor Korotin <igor.korotin.linux@gmail.com> wrote:
>> On 8/27/2025 7:37 PM, Daniel Almeida wrote:
>>>> +    /// Returns the driver's private data from the matching entry in the [`i2c::IdTable`], if any.
>>>> +    ///
>>>> +    /// If this returns `None`, it means there is no match with an entry in the [`i2c::IdTable`].
>>>> +    fn i2c_id_info(dev: &I2cClient) -> Option<&'static <Self as driver::Adapter>::IdInfo> {
>>> Again, perhaps a private member function? I’m trying to simplify the syntax here.
>> 
>> Can you, please, kindly clarify what do you mean? If a function is not pub/pub(crate),
>> it is a private function.
>
> I mean a function that takes &self or &mut self as applicable.

This just turns things around you you have to pass in the Adapter type, which is
required by this function. Having the device ID table and ID info accessors on
the device structure doesn't really make sense.

The current implementation is also in line with what we do in the driver core
code and in other bus implementations, such as PCI.