From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f65.google.com (mail-ej1-f65.google.com [209.85.218.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E40A2BE05F for ; Fri, 12 Sep 2025 07:24:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.65 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757661873; cv=none; b=IoTsyIv6HqBjXZ0rwNB5qWwZN0hrrpx6mivJdk9HrdYQIFgkHCZk8w+pjel4v7pGFT/hyafKc/ebJnAq2x/114jbri3YQJeRnupcxOeZUSsnmCJGmarHK+zZN8kWL4J4rbZq2Paka+vKvFQIB7mPPnv77bzMzELasX0uwnvN51s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757661873; c=relaxed/simple; bh=ov0o+N7VlhjyhV78KxdzxA6UTh8zdhFtw9m5AFWO1II=; h=Mime-Version:Content-Type:Date:Message-Id:To:Cc:Subject:From: References:In-Reply-To; b=TyosBWMklzxjmkhdhUBDSkG4oUh9hAFaN3upesvnRBhqUERREiWgQidW2nOOADB3at7JjaVQwwXqWCC4zifpptJn052z2CtHe7PL+wDHw6kRxl7LOld+Nip0QwFpvjaQCz5j9wOjlKM5KtbkeXhStvqsITTiV+IwFj+tjCkIafQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=diB98gXK; arc=none smtp.client-ip=209.85.218.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="diB98gXK" Received: by mail-ej1-f65.google.com with SMTP id a640c23a62f3a-b079c13240eso255970066b.1 for ; Fri, 12 Sep 2025 00:24:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1757661870; x=1758266670; darn=vger.kernel.org; h=in-reply-to:references:from:subject:cc:to:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=uaHiq8VH1qzCN6aCnAst3zvDqtwjzvVk1OyYrGXolto=; b=diB98gXK4dZXzwzBGUPRLjJ3EBr/uT2s+OXXXAkMiFkwF4lgo6b2pvuj2z46iqVqRV N+CW3ztFuwjuq7r0/lpunEnGISP0ufh8TvG6Af7jvI8bx4YYp2lcYc9Ga6kSFcG54kzS CexscO4HTY9Gvo2NdIgj6M0AzwSD46bd0ZV4DP/uVOeOFKJ3V3r5XKbY6vq2jCfQt6xp KNEC7jzbjQDNDH9BlIprYnz38qiggic1/vwCmWvoShNyeTFiMlwn3otJYR8vpmKA2sYt jWIV6Ubhq2v0R+Qhc65V19p7ahp/iY9lrG+Jp6hkpnzzfeys7lF2shO6g9mfb1yUx7MK dO1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757661870; x=1758266670; h=in-reply-to:references:from:subject:cc:to:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=uaHiq8VH1qzCN6aCnAst3zvDqtwjzvVk1OyYrGXolto=; b=wAtP4crToCrgAJDOMaKZX2yzu8TYgHGFej4uoIu/Ys89oAIXnN4WZepvgiB/2nXVuv +ZW4MRwiJSkLrDYIpW7ijOBJvyYxJILwcOS6XFanBRXmfVeYdpjjWtHSjaY78kis5Abx oYvhtikiFr+fPEnSav4BVLMpcDr7q29AyTyV/WSJdPVid9bYYwlHYMa9+MU+QcykxePs bql1sb8HC69czP3ZR72u0u83vefMwGW2ewAFU+AV0VKVPWX1C4LTJENJPqrXXjxeMpH2 iA0VKcBvek/o2YUF+XfRA0HhagGrQy4NdqDLJCk69qo+3WfrDRqTQmgPUvW76DmY/0Ou 3KBg== X-Forwarded-Encrypted: i=1; AJvYcCXEstyVC50R93H2zOyAm1c17RY8TYQl4JL0TJqEdjo9c6Wsd2Ypc4NGLKmFVxM4+5Jwaz1ld0hnaqITuF0=@vger.kernel.org X-Gm-Message-State: AOJu0YxhMScgwrxzBicXQt6Ku6SKKCs6FmYCEbs3MLJWfajUk+B1j2R6 GsZuENvGaIHPSDJetXahN0ogV7fdrAD+lOmAO/b690FXHeE8Nml7ndzrQaH7lL/Wsko= X-Gm-Gg: ASbGncvP65X3hZbhy5YwcVB4ugzxHBE300PihyUFXVCthUEhUzOmCDgtDmrNOPZOs0b d175a0gtQWoLOXjlrK89vaH3WvEnaaPmgXKzyKpT836vuHgUwbaDYN52CdfP+TXtuoTL0wBqfwK uhfJdQDvNrNNwW5Ho0weXEI0kBIsvOtDFq/c3Q13UI/saZyamVdiYUO94kNrn8bUIP13fwYeSDV PVHnSPzX/fx8HWbETLV1SnS6G10LGRz+jla2H3BxjahzlMEBVw12fVMGM1qbPKhecj5rjh7X7C4 fSWy5ujj3YCdVTLodbD1cN5Ds+4pSdln/qJtD6luNrsMBheIICzocvJrg+rIMBTNGDKFebB0EzX rtbcctfGnaxeSud//ZLbInHKjAonkWoRBRGP5u8/Qf09F6SKS4iqwme+cL3xz2scNPwptU/hGAM YEHfIzYyi0YVwOB5M2fAkRZQTeS6Q+FQM2mPN9xG3l5WY= X-Google-Smtp-Source: AGHT+IElFju5c0ol0hw7nESeIjDDTstVEiLNQomQ5v8H5idD7G4pKPF7+MO6caJyGVA3MvvQLK7alQ== X-Received: by 2002:a17:907:2d0c:b0:b04:1957:8e72 with SMTP id a640c23a62f3a-b07c3ad9ce3mr161741066b.65.1757661870248; Fri, 12 Sep 2025 00:24:30 -0700 (PDT) Received: from localhost (2001-1c00-3b8a-ea00-c4de-d39d-05f4-c77a.cable.dynamic.v6.ziggo.nl. [2001:1c00:3b8a:ea00:c4de:d39d:5f4:c77a]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b07c2d043desm139043466b.40.2025.09.12.00.24.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Sep 2025 00:24:29 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 12 Sep 2025 09:24:29 +0200 Message-Id: To: "Tamura Dai" , "Bjorn Andersson" , "Konrad Dybcio" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Joel Selvaraj" Cc: , , , Subject: Re: [PATCH v2] arm64: dts: qcom: sdm845-shift-axolotl: Fix typo of compatible From: "Luca Weiss" X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <38c24430-16ce-4d9a-8641-3340cc9364cf@kernel.org> <20250912070145.54312-1-kirinode0@gmail.com> In-Reply-To: <20250912070145.54312-1-kirinode0@gmail.com> Hi Tamura, On Fri Sep 12, 2025 at 9:01 AM CEST, Tamura Dai wrote: > The bug is a typo in the compatible string for the touchscreen node. > According to Documentation/devicetree/bindings/input/touchscreen/edt-ft5x= 06.yaml, > the correct compatible is "focaltech,ft8719", but the device tree used > "focaltech,fts8719". +Joel I don't think this patch is really correct, in the sdm845-mainline fork there's a different commit which has some more changes to make the touchscreen work: https://gitlab.com/sdm845-mainline/linux/-/commit/2ca76ac2e046158814b043fd4= e37949014930d70 Regards Luca > > Fixes: 45882459159de (arm64: dts: qcom: sdm845: add device tree for SHIFT= 6mq) > Cc: stable@vger.kernel.org > Signed-off-by: Tamura Dai > --- > arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts b/arch/arm= 64/boot/dts/qcom/sdm845-shift-axolotl.dts > index 2cf7b5e1243c..a0b288d6162f 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts > +++ b/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts > @@ -432,7 +432,7 @@ &i2c5 { > status =3D "okay"; > =20 > touchscreen@38 { > - compatible =3D "focaltech,fts8719"; > + compatible =3D "focaltech,ft8719"; > reg =3D <0x38>; > wakeup-source; > interrupt-parent =3D <&tlmm>;