From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f66.google.com (mail-ed1-f66.google.com [209.85.208.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B8186320A20 for ; Tue, 23 Sep 2025 09:55:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.66 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758621346; cv=none; b=BZPnGAUPIrwlr7TFsf0C5oMzOP38FpRqZaeF/0spG8QKZ1nSU61LBDV5zxHT42/B8nkRFICvTeen50Ah8sm2qTkqW4tEh6MugAf9D+eeHa/Ly1PW5tDX2dgwsxaFgyHUoiLu6nnI7eTw4vFIWkrXGDKeYm6aCEsmBf9cMjIoj5M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758621346; c=relaxed/simple; bh=e5NOGt0T1QOZxsKIPNmxZjkQ42IMvdnLCXJEh6LT0RM=; h=Mime-Version:Content-Type:Date:Message-Id:To:Cc:Subject:From: References:In-Reply-To; b=untaQqx9lj1UI4Ei4DMp8KS9oIkdwKI+sTH6lkLHHrNuJEYbmcOShzu3rlbMwSdCZgKHcUDQ5tcNrDJBp7d85ms6RSe/useiafXUCRYZYmljEsCR7XG17p6wBe0TIwx4ISjE8rKKrnLNR0WDuxPuk7m80/HQ4CR29I1w1IUGSUU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=haF24h/w; arc=none smtp.client-ip=209.85.208.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="haF24h/w" Received: by mail-ed1-f66.google.com with SMTP id 4fb4d7f45d1cf-61cc281171cso8624976a12.0 for ; Tue, 23 Sep 2025 02:55:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1758621342; x=1759226142; darn=vger.kernel.org; h=in-reply-to:references:from:subject:cc:to:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=rJ4iR0ikwChD7GAZnfT4r7240QnDqgcDQ/DHGsIuO5k=; b=haF24h/wrJPNnq2IKcLfxamIIVmyfAVz3ySeeAziwS96OL1SeDhCIiqlWF4E2eueiU LZ5vfILTwTTJ1dO5nZ695CDsD9TcarihFxjCNVZoN/0Hg1p/KZp3RtTg3mBoGFqvLps8 ynI+pIUhDGeN7hRVvGDpJ2rrD49kkb2sLEdnV6ZXa1ot+QLkkK6uwsOnmmMlMKeQBRhf D67J3hRYOEtpm0x06YWsPhuTCdDDJtcdxZcF5QRV9Y0f00uEAlaY9Dq5VhAe/q/qfic2 XarCYdkmAmP+trDiAHj5wC6oqYBOxwi8e4Z8SZhW98xkhA3fE4UnWWZGbcW4yD8tG+DQ ZOEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758621342; x=1759226142; h=in-reply-to:references:from:subject:cc:to:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=rJ4iR0ikwChD7GAZnfT4r7240QnDqgcDQ/DHGsIuO5k=; b=i7eYIJkZz97tQb4zfXA+Eyr5Ujw/ZyL6ULNjtaXnI0ctMLMFk9NIeq+SmaQFHX4mQL yfMfp+Auu30kK+HwT7CKNen6o8mjsoWMpGZnwiErT9Eo3KLNpuWB/sm1gMyPjfz7gKSK flMv8Ltiur2WaKxosV1BWa+Uw7dJLo0IxG3EnCUEVQarQUqyHEMv9y7anqr5So6FhMrK IJGbnPwy0T1QJKkTolnPmEHirtry+TXuJZM5pOPJ3GL5yk9a3v1k6dnMkyg7kISEwm8b 3nbqYYhsjgD3kyaOTWGxk95auFTqjTG2bu3khjo0OEtFqW/i3ldyW3uXRxZdK7iCPWPP gY3A== X-Forwarded-Encrypted: i=1; AJvYcCVhSw1UMJFGZjQGv1/nqGnrBBTcg2ICtnVKqsMjc0R7inOe1yd/CVh3r7oP32YSyrfaqAsni+FreFNlQvc=@vger.kernel.org X-Gm-Message-State: AOJu0YwXN9S2zXRRoaxHpDdhNaLWdS6MnHIUBajtW6EiUo3pw0FC4GUs rT9hvsSYcYcLEuAp8av9v/W1BS+D/OhffSKZGhBqQE3MHr8N+BMwoZQgnRE2sz0TfDI= X-Gm-Gg: ASbGncuvCEMVHcoNAse/Kr3Jmi9OCGBUsvRq6qoDFrE/DzV05Iu/+4LPJJSZNwGq1TY wOknxVO5RicSMnbGNbNIBg5dEGtWuQvLhkTlfaNmgQqIP9yLcgvcBcXZsm99rQ837fT6ifH5ugx 3b2x1HZKWJ6/JVC/JGF+/FrUa4teD7g9cj0WbTPtOGVbR2W4dgDFrx9KHF1zlv1JsXy5iEAwtYa XSZdx+yPHphjRy1V4k2TrgdhwTJo9NB8hY4Pnf0fcBogKgkbGLnJeeCGV8+q6CtMpjQ+f6cHMi/ k2V29tpYB//5I2FhXh5CCICoQ342MML5rZy0PsT2T8el5mXrjF02vwpGDSdPoE9de0rWWsTS623 f19t2uuF8tp52KJdoxA2oJlwlZobXvPAtlEY4usiL51uHe1OgKgHwh8+z5NdLdsCUAvcj X-Google-Smtp-Source: AGHT+IF4qTxhg5Hb9sQ/tJAzBa4Ees7FfG50FOAI9GBuf35fyxLYwKPlFRuv+uHkCbA78L9NSJbk0w== X-Received: by 2002:a05:6402:4389:b0:634:4e0:8360 with SMTP id 4fb4d7f45d1cf-6346779a012mr1708846a12.2.1758621342052; Tue, 23 Sep 2025 02:55:42 -0700 (PDT) Received: from localhost (144-178-202-139.static.ef-service.nl. [144.178.202.139]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-62fa5cfa6f2sm10771105a12.6.2025.09.23.02.55.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Sep 2025 02:55:41 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 23 Sep 2025 11:55:41 +0200 Message-Id: To: "Pavel Machek" , Cc: "Bjorn Andersson" , "Michael Turquette" , "Stephen Boyd" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Stephan Gerhold" , =?utf-8?q?Otto_Pfl=C3=BCger?= , "Linus Walleij" , "Lee Jones" , "Joerg Roedel" , "Will Deacon" , "Robin Murphy" , "Konrad Dybcio" , "Sean Paul" , "Abhinav Kumar" , "Marijn Suijten" , "David Airlie" , "Simona Vetter" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "Dmitry Baryshkov" , "Adam Skladowski" , "Sireesh Kodali" , "Rob Clark" , "Abhinav Kumar" , "Jessica Zhang" , "Srinivas Kandagatla" , , , , , , , , , , <~postmarketos/upstreaming@lists.sr.ht>, , "Konrad Dybcio" Subject: Re: [PATCH v7 6/6] arm64: dts: qcom: Add Xiaomi Redmi 3S From: "Luca Weiss" X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20250831-msm8937-v7-0-232a9fb19ab7@mainlining.org> <20250831-msm8937-v7-6-232a9fb19ab7@mainlining.org> <97ee369f6ffbe42c72c57ebd72887b23@mainlining.org> In-Reply-To: Hi Pavel and Barnabas, On Tue Sep 23, 2025 at 9:22 AM CEST, Pavel Machek wrote: > Hi! >> > Hi! >> >=20 >> > > + led-controller@45 { >> > > + compatible =3D "awinic,aw2013"; >> > > + reg =3D <0x45>; >> > > + #address-cells =3D <1>; >> > > + #size-cells =3D <0>; >> > > + >> > > + vcc-supply =3D <&pm8937_l10>; >> > > + vio-supply =3D <&pm8937_l5>; >> > > + >> > > + led@0 { >> > > + reg =3D <0>; >> > > + function =3D LED_FUNCTION_STATUS; >> > > + led-max-microamp =3D <5000>; >> > > + color =3D ; >> > > + }; >> > > + >> > > + led@1 { >> > > + reg =3D <1>; >> > > + function =3D LED_FUNCTION_STATUS; >> > > + led-max-microamp =3D <5000>; >> > > + color =3D ; >> > > + }; >> > > + >> > > + led@2 { >> > > + reg =3D <2>; >> > > + function =3D LED_FUNCTION_STATUS; >> > > + led-max-microamp =3D <5000>; >> > > + color =3D ; >> > > + }; >> > > + }; >> > > +}; >> >=20 >> > That's single, 3-color LED, right? Please see LED multicolor support. >> As far as i know aw2013 driver does not have multicolor support. >> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree= /Documentation/devicetree/bindings/leds/leds-aw2013.yaml > > I believe that needs to be fixed before more bugs are added on top to > work around that problem... > > ...and before that bug is cemented in the ABI. Honestly I don't think it's reasonable to expect people contributing dts to then first start patching existing LED drivers and adding support for x y or z to it, and block dts addition on that. At least in postmarketOS the user space components we have (e.g. feedbackd) detect the LED things (and most others) automatically since various devices have various different setups. So once/if aw2013 gets multicolor support, the dts can be updated without problems. Sure, maybe today changing something on the N900 which would change sysfs paths is not the best idea because people will probably have 10+ years of random shell scripts lying around, but nowadays we usually have better ways of abstraction that can handle that. Regards Luca > > Best regards, > Pavel