From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 870B230CD84 for ; Thu, 2 Oct 2025 13:14:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759410858; cv=none; b=LQJ92ujXm3agQ8aFmOlhWTgJQnJtuLf9pamzHHTNizQaQzR8YMB2lcbx9BD5kGa5pQb4OhMsloWRHkU/GsoBxYgZFlbeozxcwGW6G8TO92tEDuGqzu1Q+/10bzZJapdF2x7Fp5c/Dymt8T+FI7M9uMUm9nYKfHD+0YAJAEFtalg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759410858; c=relaxed/simple; bh=abn3PG8XEoGYwcyzS9IOIA5hdgX+qSfZsqs7WVvuQUk=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=eKv8KASppKkLKn+eTc0duVqRB+RMapAfRzFc3UaBxS/mPbmEGwV+ioljAWUnuzxkiqwDY6PKp5isH4D6tvROJ1a48lZpVLM1vnqF38vqcfwOoyE+KnotvCklbAuPWxB4DeXJ3RHE5RFDCt19mtsPoRqZeQPto8VjhrgBUf5rSjs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=oNSIoVly; arc=none smtp.client-ip=209.85.218.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="oNSIoVly" Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-b3b27b50090so194250366b.0 for ; Thu, 02 Oct 2025 06:14:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1759410855; x=1760015655; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=yqfTggLDM2JL6k3wlUbLdqaGH8N69rA5/6pVtkxsZXM=; b=oNSIoVly8WAY8ECxlj73sDNml9qZPGLVVqB5sn5bHKVtZlVyfyaGy6bFKQz7ObjVry sDN2p0Ro6RMNzLgr17wcuFSrylh1l1POEvR1fuRhyWjbhrHnj5CilepQoBa+W3ZgDA4B D0m1f+l9VomdMHfHTaQLll7rify2cX56m/kFWPvXc1C6SCqnn2D1h3swKWA46m6eeeKz kI79JorICoNLqz+95+iWGI5RdIeeoZ6+nHZ2KB1A/+Cz2d8orkIRJpaaN3GqRV499Fx2 R0M5SyPhxbeT7ErZ6fY2gy/j2Hg9OUihC+TQf7Gi05rlSUmRPX3xRxL8CIjOf9SyMSRa yESA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759410855; x=1760015655; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=yqfTggLDM2JL6k3wlUbLdqaGH8N69rA5/6pVtkxsZXM=; b=KyOcocwVwWX9wI9R7VRNohqV+ivKBA1BSYGmgz2LbrchDDWgZDi40fO93Pw2sCmO8Y 6rRY6B9DMza6ZjXIffG6QVNg5/gBVoupVgvVw+mtvRUv/aqaC68Z4F89T6SzBk/P71Yh EDfEsoDPS+rSazbhLs+9p4qvZlJsALFk5rouEoTORAtH80KTRf/kvk6mrNgXErBPTaw0 pocgirgHRuWpEqGMYjILKBKVEHL3Sty3PJYWKlZ6v4V+SYrPTeWKJaS3rKeUTJ4tbHwK gfaI7r0vXToX7UlvqNrCgyMEJWbietAj4+CFWGY52WSfxcS1jYpBeY65BNY1zDBZ9vwi ZadA== X-Forwarded-Encrypted: i=1; AJvYcCXrB0hSBtzcnw3Hg6qUWLGyTMQ2Wk3IdBJfvsarNZBoDFiqzrdHlqwIJ3vurYrRsC0OS6Q83n3iq+0TCPo=@vger.kernel.org X-Gm-Message-State: AOJu0Yyqxub9QfCFcHWYxdAOCYNMP4XxJ8+gHfuOQxYsKlJXKtO5CG7G OXOWYJJf3rqdvMhts2uLsNOoFHtH0Gh30riKPnOToWfNPVh65gWoVKqbNx8sS6E88UY= X-Gm-Gg: ASbGncsSB22whB1T9RNLEXf1FQbGWAiY3ZApyHJSJRnID07P+4ffaUR477N/wpIalbn r/Yr4vvCqHC6IejPBlggbgARx1SBM47/ViLZYBB+HnHD2UF/cYv+x+MlbH170rFRVYQQqQv96FO MkocGz5oHXbtnuO1LgpOp7prlklHnI9nQlL7FuXdomoRuutLXkS2/kfFCIIFQVzp8Zh7k1nYIg4 MEQxL+ysYMhnfKdqoOLc4bzKVVRMX1KRS5vjY2lKsl5jaV1qUoyXQkoVn4ZEnwLMnUxpya2EQvf o4vCBluzqnhb3PUka0PD2DWgMfVmubq4TwHRjZ/i3FKfujCkAgNWfFFZNz8Ld6rJL5l5N/a5bDJ MVePqgunNrO7GFbJnlPrhC90b6JA6xinpvJlK4aqg+Yg1jgVJOLG7lgfehp/uPBjPj2bFC8PRCg +Xj0raSHKN+Bil7XeKGddWctcMCkY= X-Google-Smtp-Source: AGHT+IHdC79LilPtaS8UDTu8UX4x3ltn3xPSSVu5zWW7q/miLeA66hPm/5CSpLhwtBO8hi4Phex1ug== X-Received: by 2002:a17:907:3e92:b0:b3d:30d8:b897 with SMTP id a640c23a62f3a-b46e1767bf4mr871148066b.14.1759410854778; Thu, 02 Oct 2025 06:14:14 -0700 (PDT) Received: from localhost (144-178-202-138.static.ef-service.nl. [144.178.202.138]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b4869b4d9f5sm210176266b.66.2025.10.02.06.14.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Oct 2025 06:14:14 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 02 Oct 2025 15:14:13 +0200 Message-Id: Cc: , , Subject: Re: [PATCH 3/4] arm64: dts: qcom: qcm6490-fairphone-fp5: Enable CCI pull-up From: "Luca Weiss" To: "Konrad Dybcio" , "Griffin Kroah-Hartman" , "Mauro Carvalho Chehab" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , , "Daniel Scally" , "Sakari Ailus" , "Bjorn Andersson" , "Konrad Dybcio" , =?utf-8?q?Andr=C3=A9_Apitzsch?= , "Bryan O'Donoghue" , "Wolfram Sang" X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20251002-dw9800-driver-v1-0-c305328e44f0@fairphone.com> <20251002-dw9800-driver-v1-3-c305328e44f0@fairphone.com> <1be80052-3ba5-46de-804a-de995f8db5d4@oss.qualcomm.com> In-Reply-To: <1be80052-3ba5-46de-804a-de995f8db5d4@oss.qualcomm.com> Hi Konrad, Answering on behalf of Griffin :) On Thu Oct 2, 2025 at 2:45 PM CEST, Konrad Dybcio wrote: > On 10/2/25 12:15 PM, Griffin Kroah-Hartman wrote: >> Enable vreg_l6p which is used as a pull-up for the CCI busses, to make >> sure I2C communication works as expected. >>=20 >> Signed-off-by: Griffin Kroah-Hartman >> --- > > Makes me wonder if we should maybe extend the CCI definition > (or maybe the common i2c-bus binding?) to accept an external > pull-up supply, as this is a common problem.. (+Bryan, Wolfram) Yes! Unfortunately though this effort has stalled some years ago. There is "struct regulator *bus_regulator;" in "struct i2c_adapter" already and vbus-supply is documented in i2c-mt65xx but afaik this not functional because some code was ripped out ago because of some AMDGPU regressions. > We could then shut down the regulator when cameras are not > in use, preserving some trace amounts of power. > > Or maybe L6P is already used as a pull-up supply for more things > onboard and should be always-on either way? Could you please > check that, Griffin? L6P is only used as pull-up reg for cci0, cci1 and cci3; and as power for stuff in the camera modules. So if everything camera-related is off, turning it off is actually a good idea. Regards Luca > > Konrad > >> arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts | 2 ++ >> 1 file changed, 2 insertions(+) >>=20 >> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts b/arch/a= rm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts >> index e115b6a52b299ef663ccfb614785f8f89091f39d..2dd2c452592aa6b0ac826f19= eb9cb1a8b90cee47 100644 >> --- a/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts >> +++ b/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts >> @@ -749,6 +749,8 @@ vreg_l6p: ldo6 { >> regulator-name =3D "vreg_l6p"; >> regulator-min-microvolt =3D <1700000>; >> regulator-max-microvolt =3D <1904000>; >> + /* Pull-up for CCI I2C busses */ >> + regulator-always-on; >> }; >> =20 >> vreg_l7p: ldo7 { >>=20