From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f176.google.com (mail-oi1-f176.google.com [209.85.167.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA8962EC57C for ; Tue, 31 Mar 2026 07:01:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774940489; cv=none; b=AfrZHoaElZyxeCmKmg8i+YJeljMNdzBYwNY7c7kyCf8vwn7lSEGDyNJNHaI/JI+dhtQ54oST4xZGuf4mXj2w/NPBuZYLGSxKquZJ+BXm5dyqQazmalDk4+b9K9hNXN5euGaEUAgUBXbo4u6i2z5oEVe88DhY4gjwwq5sS81Qv1o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774940489; c=relaxed/simple; bh=PLN12L/J2iyyWxe2If0sxXyHDGxdLInF1MDvYiDe6+8=; h=Date:From:To:CC:Subject:In-Reply-To:References:Message-ID: MIME-Version:Content-Type; b=ZdeWVKdeZWFUd6qkssRpEuYqxuximhyTUKVsDWIEtULjFPMLrqXJsCLpYvQ9xmq+kYxokAdKmkUj2npFW6riMVKaw9zzHX40CetmwLRizECoYz32dMLQfyZ33OlqLGu/K2Y3gB2Urw73I5Lif2VZXPEx9cyohM/oTrQA28GOM6g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hrcW8w2n; arc=none smtp.client-ip=209.85.167.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hrcW8w2n" Received: by mail-oi1-f176.google.com with SMTP id 5614622812f47-46704177508so3254164b6e.0 for ; Tue, 31 Mar 2026 00:01:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774940487; x=1775545287; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=GbP8tAe8emnfrefImNYaY1sC/mYPUiQj77TYwG/NXDY=; b=hrcW8w2nQecTztnY/LO+sJqcu7TShDtEIFEoI4HA81Dd4QXSxxAX6TnipfyiUThjWZ 6A8QVBYYUNLQw0WIAcg63CLqrpJlXaBdc01rrnHZf7+O95wNe7mhuaMXgOLcc5QqxdpZ seKwGbW3BX6mz7JIFdcK4EYDpmbmmqt0DhdcVY5/6JqAKYmUGg+ia9J63yzRDJiBw4RH ME1Hwn74tLDz/DgfqSMIM56kawpSOgnTczhWyi2CZK4AP+6AgI1NrHUYDISD7LCqfKwt mfjmp60+PG9LT56y/tYLmGOe7eRYIPdqgpsZSfgsDHmI9NlNJFQulAEX5fDKMrq0Ud39 PLZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774940487; x=1775545287; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GbP8tAe8emnfrefImNYaY1sC/mYPUiQj77TYwG/NXDY=; b=skZbxXF1/MwnvTS27nlqs3a0S16jrTZXfZxPuy+noNNkfMq0Rp17QVxZS2XHAlmXUO kV7uy8rKwKZulnwK6s/Ya1JGEnYgOnLxRbTD0ADUQS6CD5vaVOUESTjk1H1bJlhV3Yic KxqILume7pXKkWU+yJ9L/Q8F8lfS+24LMaEP2pdwtFBXN/MzBDEJGbsTpHSH45ZLMXEs QV3zCOf662VuXxPi3rYrKa6fDbTOrK+3Aqf0/2GwoIIvlecQAxDXH5aqLJxu8nsTFQGO jKkVQ7+jI+NlQ8I+STnyO5v8PI9bIZIQPo/x3q2Wz+8si9v+MhntnymtWbpq41atwlJK +J1A== X-Forwarded-Encrypted: i=1; AJvYcCX/nol3KCxzi4sf81rmUVnA6UGhCvA7YyS6JoteOpCB9VLfrsu7L6chr95i+a2YzGNNmKyueYNtVpTNI/M=@vger.kernel.org X-Gm-Message-State: AOJu0YzpvzVugsOmiKuTZ4bRUuRSo7wyNZb4pT1o3v3Q3TheoZrjJPp8 rmIhibfLHTkakLKINuGJ3RPg8nJ1DKH42dZlbGLctgiatj7S3Zs0q/ChagDN9A== X-Gm-Gg: ATEYQzz5Bdhyxitx7Jq7u5myqPT0UCyPvTka8uy36JSejo3ezToX4JAHUTynvwlaM2I 0XfebQo01OEPeYFn21a2MGK3IMZSDOo5C2hfnZdnFNM3Cs2yuq8PMIFF5b3qkvd7EOE8C+s8SCM 79N5tdE8Sinup0KH85sCnD9RolwRrjOk4gK7FPF6T6JVSaLZCXbHwphFhklEsYfV3c6c23YVr2F JKy9joQz/DAoE/AWRKVDmdzREWVucrsndx0ykJ1vdS//9pmIja2A0ycvx7hNi1LtWxWukdI6+S2 ca4ORKsVvMNcE/I4Yxri/B0mBlXwDgNpo7hJt3AUySYPrkzvsnSY5w1irkjvF030hMangKVjMrx c0SIqXajijoDDCv4P8hUDE4082Iw0WZsq33b9huWDWwH8+LK9cppCagqS5EWBwHX8GytqBE0xnQ 1P3FvFyCwW6368IDPYlCvzC1DdcDsgdaXW6fkOdVrADBQ= X-Received: by 2002:a05:7022:4393:b0:12a:94ab:e20 with SMTP id a92af1059eb24-12ab28d8bb8mr9317994c88.20.1774939957860; Mon, 30 Mar 2026 23:52:37 -0700 (PDT) Received: from ehlo.thunderbird.net ([2601:647:5e00:4acd:7f58:87c9:ef3d:71ac]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12ab983f904sm13792148c88.9.2026.03.30.23.52.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Mar 2026 23:52:37 -0700 (PDT) Date: Mon, 30 Mar 2026 23:52:34 -0700 From: Dmitry Torokhov To: Andy Shevchenko CC: Bartosz Golaszewski , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Daniel Scally , Heikki Krogerus , Sakari Ailus , Aaro Koskinen , Janusz Krzysztofik , Tony Lindgren , Russell King , Kevin Hilman , Arnd Bergmann , brgl@kernel.org, driver-core@lists.linux.dev, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org Subject: Re: [PATCH v4 2/3] driver core: make software nodes available earlier User-Agent: K-9 Mail for Android In-Reply-To: References: <20260330-nokia770-gpio-swnodes-v4-0-b68592e977d0@oss.qualcomm.com> <20260330-nokia770-gpio-swnodes-v4-2-b68592e977d0@oss.qualcomm.com> Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On March 30, 2026 11:25:33 PM PDT, Andy Shevchenko wrote: >On Mon, Mar 30, 2026 at 02:46:45PM -0700, Dmitry Torokhov wrote: >> On Mon, Mar 30, 2026 at 11:24:45PM +0300, Andy Shevchenko wrote: >> > On Mon, Mar 30, 2026 at 02:40:47PM +0200, Bartosz Golaszewski wrote: > >=2E=2E=2E > >> > > -static void __exit software_node_exit(void) >> > > -{ >> > > - ida_destroy(&swnode_root_ids); >> > > - kset_unregister(swnode_kset); >> > > } >> > > -__exitcall(software_node_exit); >> >=20 >> > Why? What's wrong with the __exitcall? >>=20 >> It's dead code=2E Always was, always will be=2E >>=20 >> Maybe split in a separate patch, but I sometimes feel the idea of "one >> change" is taken to extreme and adds to both developer's and maintainer= s >> burden by needing to keep track of extra patches=2E > >Why does __exitcall() exist then? It's also used in other places=2E >I think it's generally good to have a possibility to clean up >after run=2E > The code section will be discarded when the kernel finishes booting so it = only increases image size on disk=2E=20 >A bit of archaeology: > >The first time it appeared was in the bcc2152647b8 ("Import 2=2E4=2E0-tes= t3pre3")=2E >Then somehow spread a bit (but not much)=2E > And it shows how useful it is=2E Maybe it had some purpose a long time ago= , but at present time this code will never be executed since it cannot be b= uilt as a module=2E Thanks=2E=20 --=20 Dmitry