From: "Anirban Sinha" <ASinha@zeugmasystems.com>
To: "Oleg Nesterov" <oleg@redhat.com>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
<linux-kernel@vger.kernel.org>
Subject: RE: FW: avoiding run_workqueue() recursion
Date: Wed, 15 Jul 2009 11:52:39 -0700 [thread overview]
Message-ID: <DDFD17CC94A9BD49A82147DDF7D545C501CFAFCD@exchange.ZeugmaSystems.local> (raw)
In-Reply-To: <20090715183941.GA13341@redhat.com>
Hi Oleg:
>If we just return silently, we do not flush but hide the problem ?
>And in this can lead to other problems which are very hard to
>trigger/debug.
True. I think flushing is an invalid operation for a thread that is
already walking the work-queue, like keventd. It is inherently bug in
the code somewhere else (may be in a work function?). I liked your idea
of replacing WARN_ON() with BUG_ON() but I do understand that a panic
could be a bigger hammer here. May be we can have some sort of
restrictions or conventions for writing work functions? I don't know.
Ani
prev parent reply other threads:[~2009-07-15 18:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <DDFD17CC94A9BD49A82147DDF7D545C501CFAE3D@exchange.ZeugmaSystems.local>
2009-07-15 18:39 ` Oleg Nesterov
2009-07-15 18:52 ` Anirban Sinha [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DDFD17CC94A9BD49A82147DDF7D545C501CFAFCD@exchange.ZeugmaSystems.local \
--to=asinha@zeugmasystems.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®