From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DEFC328D8DA for ; Wed, 15 Oct 2025 16:36:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760546191; cv=none; b=rngzjGtnbEzZ2VhSIsnqKn48ywv4GVS9Iz89nUlPEwoEkNJjS2doits2Q/49P/9CMlow65EefB68Wg6nnrZ/fO+Ts+DwHnu034ARWNbmEXOValp+p8KNcKUks5u0kr1UYOWSIMzlhzWJE6sqhOFXP96c8PyO6caYSCO1zUz/eoU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760546191; c=relaxed/simple; bh=xyZHNhiJS/pHhq2vsxbLXqxnAxxt00CfAgWHeW4ulKQ=; h=Mime-Version:Content-Type:Date:Message-Id:From:To:Cc:Subject: References:In-Reply-To; b=uGcJKmpq5jduQsgh6fVpT6h7w7v6pMLX6sDCy8PaHvqbrbJpyA1HraWCE/9hulH7pRckNHmdB1TdzdAT2WPX+zaqourryTN+DjBKtoYFYD0LcpCNXcYsq5npnPu7lfgAhUIMBRui/DKGeANrnnBYNGfQbm+8Lw6pyzzWK6KBs8g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=oC8FmeTe; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="oC8FmeTe" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-46b303f7469so47316325e9.1 for ; Wed, 15 Oct 2025 09:36:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1760546187; x=1761150987; darn=vger.kernel.org; h=in-reply-to:references:subject:cc:to:from:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=J/6PIHQYpxFdcD3g1Rb8LKFnlbKq4ABhAEEAfugnKj4=; b=oC8FmeTeCyfVOQsBN63xBIgkfByxyiOlGP51OSIMZqCLycjDVO0Tv2ejEKLyEbyuGR YoP0Wn4P+g52AEG6x1em/qhXtvtssv6DVeycUqZpQfngKgL7Uz4Is+07LiGgb5zu3tuH oPDDvbF3+ipN9NUQS0ymPARy0P2HYyOcpfSlCV2IJLw1Wb1+kTdUZzNne9syb9TdEyTN OJ8u5GPZioMlNa9nH2HGvgTNsPOeP9IvuOuD+O/uJ+sLe6jfFna1olKNMejsJMUqi50x +qUaqmxWsbd/92MrnuTKuGpsttnJD+ZypNN3j2z602nDwV5iQN/hSXdDE+c3Pl20CaEs MTpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760546187; x=1761150987; h=in-reply-to:references:subject:cc:to:from:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=J/6PIHQYpxFdcD3g1Rb8LKFnlbKq4ABhAEEAfugnKj4=; b=lzN5cHC6LpQLBGrewc3hLWEQkTE/P0u7GFCHZguNMEAt+W2Sc1+79HA6fCpvHERvz+ z50Qxsjd944Jd5mzaWVqjSXb++uwIWNAGzjWoQY4bQKbM77UkDt4T87YwL6R48DWYktp AwM21HVDigHfSRyHYTGKNaCmtYgoworj+zrv+aHIRGqJ2b5Q1AYOF7VdhJDCjuDsKogO 1PF26gU3sudSpfPCQkJ1aZvCfboJVC20TR8bug1sSKbjoknIfOmOFruCBeKldi6wpfB/ tgji1nfOIXyIoa3rbXLM+FikjnVyotdJdRDh9pUeR7unr1cQSXJjeCIzxTBBiZFoYOvt jXFA== X-Forwarded-Encrypted: i=1; AJvYcCXl+xSWcparDTp9+ibgO0VGCuK6JK8JsQTwaa73R0WEQzU5okrKuPiUARg0TOzwB0AXx0aP1ogpf3rMAsE=@vger.kernel.org X-Gm-Message-State: AOJu0YyUP9Q49RUwMSTAQx47VJZ7bioQ8NbcK5R8s2f2foGVKIIPWmUr mZJioj62cluKCF7VCL1uC5Kb0CK9AhlO746pZVB5QdYuYCYxlLbMh88KoLzhnD0P5iVxkjAr5AF JzsDm X-Gm-Gg: ASbGncvb26tb9unc6R0+bzvJMrGCVwgtl63Mpm4ws0/Tc7NXGNyk529f63cB1pPzLzK 6fmmHHEHIvRMEVdRshiglylmnZUSCsDu50zmSGP5zvjw7LiRnUFw9vgpojkaxJUqB5wBglNrmhe xY9msJzzwBEUZE33RgqqqU2Hdhoe2a6DbDQ5+cX2DxprQXTBslFtOznyWkIf8z6WCsE48E7lfLV 3a4pugA4mkfVU2kr4NPj3fhCmwlj/X4LGXOrDWRLDTOkIA+Ij9pwAf1BiXbLBDHwx/TeAQJx5E9 rmg9M+9cajn0uYGiRZbmk4QoFWdQGhubyt9iZ0gzx1BwR4HdLoTeFTXGE8yoDDdk1kZW98SUiXV dcCNFLT+p8yCG4YRVNdO9sgOid1oa2IZZjNaLKbtrC3M0fgXL X-Google-Smtp-Source: AGHT+IGVsX4Z6gvhEdWFe8CVNUsZF7cB3CGnm3rlIg452iDvItLU2/Uzxwubc3knG3XtRNgXtynQjw== X-Received: by 2002:a05:6000:2910:b0:405:3028:1bf2 with SMTP id ffacd0b85a97d-4266e8db2abmr17050645f8f.62.1760546187091; Wed, 15 Oct 2025 09:36:27 -0700 (PDT) Received: from localhost ([2a02:c7c:7259:a00:da1:8747:bd91:8232]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-426ce57d3b9sm30734345f8f.11.2025.10.15.09.36.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Oct 2025 09:36:26 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 15 Oct 2025 17:36:25 +0100 Message-Id: From: "Alexey Klimov" To: "Vinod Koul" Cc: "Jaroslav Kysela" , "Takashi Iwai" , "Srinivas Kandagatla" , "Liam Girdwood" , "Mark Brown" , "Patrick Lai" , "Annemarie Porter" , , , , , "Krzysztof Kozlowski" , , "Ekansh Gupta" , "Pierre-Louis Bossart" Subject: Re: [PATCH v3 1/3] ALSA: compress: add raw opus codec define and opus decoder structs X-Mailer: aerc 0.20.0 References: <20250917-opus_codec_rfc_v1-v3-0-7737ad40132e@linaro.org> <20250917-opus_codec_rfc_v1-v3-1-7737ad40132e@linaro.org> In-Reply-To: On Thu Sep 18, 2025 at 6:08 AM BST, Vinod Koul wrote: > On 17-09-25, 08:32, Alexey Klimov wrote: >> Adds a raw opus codec define and raw opus decoder structs. >> This is for raw OPUS packets not packed in any type of container >> (for instance OGG container). The decoder struct fields are >> taken from corresponding RFC document: RFC 7845 Section 5. >>=20 >> Cc: Srinivas Kandagatla >> Cc: Vinod Koul >> Co-developed-by: Annemarie Porter >> Signed-off-by: Annemarie Porter >> Signed-off-by: Alexey Klimov >> --- >> include/uapi/sound/compress_params.h | 43 +++++++++++++++++++++++++++++= ++++++- >> 1 file changed, 42 insertions(+), 1 deletion(-) >>=20 >> diff --git a/include/uapi/sound/compress_params.h b/include/uapi/sound/c= ompress_params.h >> index bc7648a30746f4632ecf6695868e79550a431dfa..faf4fa911f7fc2830c3ae42b= 93650fe40d8a776b 100644 >> --- a/include/uapi/sound/compress_params.h >> +++ b/include/uapi/sound/compress_params.h >> @@ -43,7 +43,8 @@ >> #define SND_AUDIOCODEC_BESPOKE ((__u32) 0x0000000E) >> #define SND_AUDIOCODEC_ALAC ((__u32) 0x0000000F) >> #define SND_AUDIOCODEC_APE ((__u32) 0x00000010) >> -#define SND_AUDIOCODEC_MAX SND_AUDIOCODEC_APE >> +#define SND_AUDIOCODEC_OPUS_RAW ((__u32) 0x00000011) >> +#define SND_AUDIOCODEC_MAX SND_AUDIOCODEC_OPUS_RAW >> =20 >> /* >> * Profile and modes are listed with bit masks. This allows for a >> @@ -324,6 +325,45 @@ struct snd_dec_ape { >> __u32 seek_table_present; >> } __attribute__((packed, aligned(4))); >> =20 >> +/** >> + * struct snd_dec_opus - Opus decoder parameters (raw opus packets) >> + * @version: Usually should be '1' but can be split into major (4 upper= bits) >> + * and minor (4 lower bits) sub-fields. > > Please clarify, if that should be 1.0 so a value of 0x10 Sorry for the delay. So the spec says that the value must be '1' for 8-bit field for that version of specification which it seems it should be 0x1. The spliting into two 4-bit fields is for backward compatibility and in such case any version in minor fields will be accepted (15 or less). Anything starting with version 16 or 0x10 is treated as incompatible version for this version of spec. Well, at least that's how I understand the spec. Value 0x10 in this case seems to signal incompatibility unless I am missing something? Thanks, Alexey