From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16B8D2E0922 for ; Thu, 30 Oct 2025 12:54:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761828882; cv=none; b=MZsueF5+G/LQhyDF6RpMtQIiUM7bvZrAO7C4BKgdfcUD7qXJQl695zlJjWEyUlN71gTNfNJpEkqqQu9SK/Z28/CgTQ8YIghiz1FOr3EMoJaloLP7eabmO/KGQEHiZEOyPJUrSe0sDFuCqoRGz05HebATZ3+RAdyDGmzN9nn2sxU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761828882; c=relaxed/simple; bh=Aj9GZ008QzUzXkooekBjbFcppgAMbSxcHVyDcsJ/Xj0=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=UY/1gG6DoqTt2DkhC8IZmsaEzVsbdC3ayL/AnohcloZeLQgkhoxqDFx0xcCcA2kDML/Lp5+T8fZjPBSEOlqD3WzX8UjK3k3FudrcQOCozyTP8cFJBSkUmvQ9e2IC2RfCql3sAg63DUbVgz3km30grOtiajYU1D0QN9vhBremfhc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=dDRPXxFq; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="dDRPXxFq" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 6C4E34E413F3; Thu, 30 Oct 2025 12:54:36 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 3A2276068C; Thu, 30 Oct 2025 12:54:36 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 5C64011808A35; Thu, 30 Oct 2025 13:54:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1761828875; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=Aj9GZ008QzUzXkooekBjbFcppgAMbSxcHVyDcsJ/Xj0=; b=dDRPXxFqLQfdPMh32gGnTc2/SmpBp6YBxCrNHSWhaPl/FhC3ncwmGD5dFpF/1QOViBjWtv k71/ZyjEkgcNW6vJW356l+c70qnktSysYC3P0KmCcKQKck0yMPlalzfqZjvajjUDSfWXX4 dG/x++236sSrVFzu0gCmNSZjF4iVYwBtwBQbeHFFxn+lkMjTlykbCXp9Bl+A4pj/qT7F3s ufiR6vTnHU0b1UL3TVi7R4/+PMq88hdRVPCPyVIx6k03jvuiP3HsgwlxOgwtYsbLbPEKcJ s/QTKSbaC3JA6btc18m24FwyN5L2ktKVmcNrSgXMGfkMIA0ksgTXjZeE+qIU/w== Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 30 Oct 2025 13:54:29 +0100 Message-Id: Cc: "jingoohan1@gmail.com" , "tomi.valkeinen@ti.com" , "lee@kernel.org" , "tony@atomide.com" , "pavel@ucw.cz" , "deller@gmx.de" , "jjhiblot@ti.com" , "linux-fbdev@vger.kernel.org" , "thomas.petazzoni@bootlin.com" , "saravanak@google.com" , "herve.codina@bootlin.com" , "dri-devel@lists.freedesktop.org" , "alexander.sverdlin@gmail.com" , "linux-kernel@vger.kernel.org" , "daniel.thompson@linaro.org" Subject: Re: [PATCH v6] backlight: led-backlight: add devlink to supplier LEDs From: "Luca Ceresoli" To: "Daniel Thompson" , "Sverdlin, Alexander" X-Mailer: aerc 0.20.1 References: <20250519-led-backlight-add-devlink-to-supplier-class-device-v6-1-845224aeb2ce@bootlin.com> <6e6039c815c7125e35b43ca2f8d32a0fa3103fea.camel@siemens.com> In-Reply-To: X-Last-TLS-Session-Version: TLSv1.3 Hello, On Wed Oct 29, 2025 at 6:45 PM CET, Daniel Thompson wrote: > On Thu, Oct 23, 2025 at 12:41:30PM +0000, Sverdlin, Alexander wrote: >> Hi Lee, Daniel, Jingoo, >> >> On Mon, 2025-05-19 at 22:19 +0200, Luca Ceresoli wrote: >> > led-backlight is a consumer of one or multiple LED class devices, but >> > devlink is currently unable to create correct supplier-producer links = when >> > the supplier is a class device. It creates instead a link where the >> > supplier is the parent of the expected device. >> > >> > Fixes: ae232e45acf9 ("backlight: add led-backlight driver") >> > Signed-off-by: Luca Ceresoli >> > Reviewed-by: Herve Codina >> >> I've noticed that the patch in archived in the patchwork [1] but I wasn'= t >> able to find it in any branch of the backlight tree [2]. >> >> Could it be that the patch somehow slipped through? >> It does solve a real-world crash, could you please consider to apply it? > > Sorry folks. I overlooked this in my backlog and never posted the R-b > (which helps Lee figure out what to hoover up). > > Reviewed-by: Daniel Thompson (RISCstar) Thanks Alexander for pinging and Daniel for reviewing! I double checked right now and can confirm: * the bug is still present on v6.18-rc3 * the patch applies cleanly on v6.18-rc3 * the patch is still fixing the bug Best regards, Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com