From: "Alexandre Courbot" <acourbot@nvidia.com>
To: "Danilo Krummrich" <dakr@kernel.org>,
"John Hubbard" <jhubbard@nvidia.com>
Cc: "Alexandre Courbot" <acourbot@nvidia.com>,
"Joel Fernandes" <joelagnelf@nvidia.com>,
"Timur Tabi" <ttabi@nvidia.com>,
"Alistair Popple" <apopple@nvidia.com>,
"Edwin Peer" <epeer@nvidia.com>, "Zhi Wang" <zhiw@nvidia.com>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
nouveau@lists.freedesktop.org, rust-for-linux@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Nouveau <nouveau-bounces@lists.freedesktop.org>
Subject: Re: [PATCH] gpu: nova-core: apply the one "use" item per line policy
Date: Fri, 07 Nov 2025 23:17:15 +0900 [thread overview]
Message-ID: <DE2IZB6X5QQN.NZHOR450WZSZ@nvidia.com> (raw)
In-Reply-To: <DE2D56N69NP8.2X1SGEBDM92DG@kernel.org>
On Fri Nov 7, 2025 at 6:42 PM JST, Danilo Krummrich wrote:
> On Fri Nov 7, 2025 at 3:10 AM CET, John Hubbard wrote:
>> As per [1], we need one "use" item per line, in order to reduce merge
>> conflicts. Furthermore, we need a trailing ", //" in order to tell
>> rustfmt(1) to leave it alone.
>>
>> This does that for the entire nova-core driver.
>>
>> [1] https://docs.kernel.org/rust/coding-guidelines.html#imports
>>
>> Signed-off-by: John Hubbard <jhubbard@nvidia.com>
>
> Thanks for doing this!
>
> Few nits below, I assume Alex will fix them up on apply, so no need to resend.
>
> With those fixed,
>
> Acked-by: Danilo Krummrich <dakr@kernel.org>
Applied these suggestions, thanks!
I've also noticed that sometimes the trailing `//` on the final line are
not always necessary if some intermediate sub-blocks already had one,
I've also removed such cases that do not affect rustfmt.
Planning on pushing tomorrow.
prev parent reply other threads:[~2025-11-07 14:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-07 2:10 John Hubbard
2025-11-07 3:49 ` Alexandre Courbot
2025-11-07 9:42 ` Danilo Krummrich
2025-11-07 14:17 ` Alexandre Courbot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DE2IZB6X5QQN.NZHOR450WZSZ@nvidia.com \
--to=acourbot@nvidia.com \
--cc=a.hindborg@kernel.org \
--cc=airlied@gmail.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=apopple@nvidia.com \
--cc=bhelgaas@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=epeer@nvidia.com \
--cc=gary@garyguo.net \
--cc=jhubbard@nvidia.com \
--cc=joelagnelf@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=nouveau-bounces@lists.freedesktop.org \
--cc=nouveau@lists.freedesktop.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=simona@ffwll.ch \
--cc=tmgross@umich.edu \
--cc=ttabi@nvidia.com \
--cc=zhiw@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®