mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Alexandre Courbot" <acourbot@nvidia.com>
To: "Alexandre Courbot" <acourbot@nvidia.com>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"David Airlie" <airlied@gmail.com>,
	"Simona Vetter" <simona@ffwll.ch>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Alex Gaynor" <alex.gaynor@gmail.com>,
	"Boqun Feng" <boqun.feng@gmail.com>,
	"Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <lossin@kernel.org>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Trevor Gross" <tmgross@umich.edu>
Cc: "John Hubbard" <jhubbard@nvidia.com>,
	"Alistair Popple" <apopple@nvidia.com>,
	"Joel Fernandes" <joelagnelf@nvidia.com>,
	"Timur Tabi" <ttabi@nvidia.com>, "Edwin Peer" <epeer@nvidia.com>,
	<nouveau@lists.freedesktop.org>,
	<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
	<rust-for-linux@vger.kernel.org>,
	"Danilo Krummrich" <dakr@kernel.org>,
	"Nouveau" <nouveau-bounces@lists.freedesktop.org>
Subject: Re: [PATCH v3 0/6] gpu: nova-core: remove use of `as` for integer conversions
Date: Sat, 08 Nov 2025 08:30:55 +0900	[thread overview]
Message-ID: <DE2UR8B3NFSN.27WJF1J897R4Z@nvidia.com> (raw)
In-Reply-To: <20251029-nova-as-v3-0-6a30c7333ad9@nvidia.com>

On Wed Oct 29, 2025 at 8:12 AM JST, Alexandre Courbot wrote:
> Using the `as` operator for integer conversions is discouraged, as it
> silently strips data if the destination type is smaller than the source.
> Many such conversions can be replaced with `from`/`into` or (when
> justified) `try_from`/`try_into`, but these traits cannot unfortunately
> cover all conversions satisfyingly.
>
> There is for instance the case of converting a `usize` to `u64`, which,
> in the case of the kernel today, is completely lossless but cannot be
> done because the Rust standard library does not provide a `From`
> implementation for conversions that are not future-proof.
>
> Still, in the kernel it is very practical to be able to perform such
> conversions when they are safe to do for the current build target.
>
> This patchset tries to eradicate the use of `as` in nova-core, by using
> existing means and introducing new ones.
>
> The first 4 patches use the already-available `From` and `TryFrom` trait
> where it is possible or advisable.
>
> The fifth patch introduces a new module that proposes conversion
> functions for those that are infallible under the current build target.
> This is done through a set of const functions, and the `FromSafeCast`
> and `IntoSafeCast` extension traits which, as their names lightly
> suggest, offer conversion for those types on which the `as` operator can
> be used losslessly.
>
> This new module is put to use in the sixth patch.
>
> The idea was first suggested by Danilo.
>
> As Danilo suggested, this could eventually find its place in the kernel
> crate if the implementation is deemed to be fit, but for now let's
> review and let it mature in nova-core.

All patches pushed to drm-rust-next, thanks!

      parent reply	other threads:[~2025-11-07 23:31 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-28 23:12 Alexandre Courbot
2025-10-28 23:12 ` [PATCH v3 1/6] gpu: nova-core: replace `as` with `from` conversions where possible Alexandre Courbot
2025-10-28 23:31   ` Alexandre Courbot
2025-10-28 23:12 ` [PATCH v3 2/6] gpu: nova-core: vbios: do not use `as` when comparing BiosImageType Alexandre Courbot
2025-11-03 20:31   ` Joel Fernandes
2025-11-04 13:34     ` Alexandre Courbot
2025-10-28 23:12 ` [PATCH v3 3/6] gpu: nova-core: use `try_from` instead of `as` for u32 conversions Alexandre Courbot
2025-10-28 23:12 ` [PATCH v3 4/6] gpu: nova-core: add functions and traits for lossless integer conversions Alexandre Courbot
2025-10-28 23:12 ` [PATCH v3 5/6] gpu: nova-core: replace use of `as` with functions from `num` Alexandre Courbot
2025-10-28 23:12 ` [PATCH v3 6/6] gpu: nova-core: justify remaining uses of `as` Alexandre Courbot
2025-11-07 23:30 ` Alexandre Courbot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DE2UR8B3NFSN.27WJF1J897R4Z@nvidia.com \
    --to=acourbot@nvidia.com \
    --cc=a.hindborg@kernel.org \
    --cc=airlied@gmail.com \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=apopple@nvidia.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=dakr@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=epeer@nvidia.com \
    --cc=gary@garyguo.net \
    --cc=jhubbard@nvidia.com \
    --cc=joelagnelf@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=nouveau-bounces@lists.freedesktop.org \
    --cc=nouveau@lists.freedesktop.org \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tmgross@umich.edu \
    --cc=ttabi@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®