From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932245Ab2DQMzy (ORCPT ); Tue, 17 Apr 2012 08:55:54 -0400 Received: from mga14.intel.com ([143.182.124.37]:13983 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756072Ab2DQMzx convert rfc822-to-8bit (ORCPT ); Tue, 17 Apr 2012 08:55:53 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.71,315,1320652800"; d="scan'208";a="89990482" From: "Liu, Jinsong" To: Konrad Rzeszutek Wilk CC: "xen-devel@lists.xensource.com" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH 2/2] Register native mce handler as vMCE bounce back point Thread-Topic: [PATCH 2/2] Register native mce handler as vMCE bounce back point Thread-Index: AQHNHA92/TdpFhoPSxCwxlIbh3KVRpae+H1Q Date: Tue, 17 Apr 2012 12:55:49 +0000 Message-ID: References: <20120416202821.GC14982@phenom.dumpdata.com> In-Reply-To: <20120416202821.GC14982@phenom.dumpdata.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Konrad Rzeszutek Wilk wrote: > On Mon, Apr 16, 2012 at 01:07:35AM +0000, Liu, Jinsong wrote: >>> From 76e40a60878ff72986fd8d92611400195ae0f997 Mon Sep 17 00:00:00 >>> 2001 >> From: Liu, Jinsong >> Date: Mon, 16 Apr 2012 00:16:58 +0800 >> Subject: [PATCH 2/2] Register native mce handler as vMCE bounce back >> point >> >> When xen hyeprvisor inject vMCE to guest, use native mce handler to >> handle it > > hypervisor > >> >> Signed-off-by: Liu, Jinsong >> Signed-off-by: Ke, Liping >> Signed-off-by: Jiang, Yunhong >> Signed-off-by: Jeremy Fitzhardinge >> --- arch/x86/xen/enlighten.c | 10 +++++++--- >> 1 files changed, 7 insertions(+), 3 deletions(-) >> >> diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c >> index 15628d4..346ba64 100644 >> --- a/arch/x86/xen/enlighten.c >> +++ b/arch/x86/xen/enlighten.c >> @@ -614,8 +614,8 @@ static int cvt_gate_to_trap(int vector, const >> gate_desc *val, /* >> * Look for known traps using IST, and substitute them >> * appropriately. The debugger ones are the only ones we care >> - * about. Xen will handle faults like double_fault and >> - * machine_check, so we should never see them. Warn if >> + * about. Xen will handle faults like double_fault, >> + * so we should never see them. Warn if >> * there's an unexpected IST-using fault handler. */ >> if (addr == (unsigned long)debug) >> @@ -630,7 +630,11 @@ static int cvt_gate_to_trap(int vector, const >> gate_desc *val, return 0; #ifdef CONFIG_X86_MCE >> } else if (addr == (unsigned long)machine_check) { - return 0; >> + /* >> + * when xen hyeprvisor inject vMCE to guest, >> + * use native mce handler to handle it >> + */ >> + ; > > > Can you just take the check out? What do you mean by 'check out'? remove else if (addr == (unsigned long) machine_check) { ; } ? That would fail to register mce bounce back point. > > >> #endif >> } else { >> /* Some other trap using IST? */ >> -- >> 1.7.1