mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Luke Howard <lukeh@padl.com>
To: cedric.jehasse@luminex.be
Cc: Andrew Lunn <andrew@lunn.ch>, Vladimir Oltean <olteanv@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Simon Horman <horms@kernel.org>,
	Russell King <linux@armlinux.org.uk>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Kieran Tyrrell <kieran@sienda.com>,
	Max Hunter <max@huntershome.org>
Subject: Re: [PATCH net-next 2/2] net: dsa: mv88e6xxx: add support for credit based shaper
Date: Tue, 26 May 2026 15:37:45 +1000	[thread overview]
Message-ID: <DED39BA6-C627-431F-B406-2C5A19DCE2E4@padl.com> (raw)
In-Reply-To: <C0F865AD-24CD-4EA7-B0AB-16D91914ABAD@padl.com>

Hi Cedric,

One followup:

I could be missing some patches from you due to netdev volume but, do you have a separate patch set for hardware offloaded MQPRIO?

Your example uses hw 0 (software MQPRIO) which doesn’t program the switch’s FPri/QPri mapping. For switches excepting the 6390 family, this mapping is per-chip, which means one needs to validate it is identical for every port on which CBS can be enabled.

Cheers,
Luke

> On 26 May 2026, at 10:32, Luke Howard <lukeh@padl.com> wrote:
> 
> Hi Cedric,
> 
> We sent RFC patches for mv88e6xxx support for both MQPRIO [1] and CBS [2] last year. (We have since made a few small changes which can be found in our working tree at [3].)
> 
> We have been using these patches successfully for the past year with our SRP stack [4] on a custom board with a 88E6352. The CBS and MQPRIO patches remain unsubmitted because we also needed extend the Netlink API and software bridge with a flag indicating a FDB/MDB entry is managed by SRP.
> 
> I would be happy to work together to harmonise our patches to avoid duplicated effort.
> 
> Cheers,
> Luke
> 
> [1] https://lists.openwall.net/netdev/2025/09/27/34
> [2] https://lists.openwall.net/netdev/2025/09/27/26
> [3] https://github.com/PADL/linux/tree/rpi-6.18.y-xebros-rmu
> [4] https://github.com/PADL/OpenSRP



  reply	other threads:[~2026-05-26  5:38 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-22 10:56 [PATCH net-next 0/2] " Cedric Jehasse via B4 Relay
2026-05-22 10:56 ` [PATCH net-next 1/2] net: dsa: mv88e6xxx: use the hw tx queues Cedric Jehasse via B4 Relay
2026-05-25  9:26   ` Marek Behún
2026-05-26  8:57     ` Cedric Jehasse
2026-05-26 12:13     ` Andrew Lunn
2026-05-26 13:15   ` Paolo Abeni
2026-05-22 10:56 ` [PATCH net-next 2/2] net: dsa: mv88e6xxx: add support for credit based shaper Cedric Jehasse via B4 Relay
2026-05-26  0:32   ` Luke Howard
2026-05-26  5:37     ` Luke Howard [this message]
2026-05-26 11:28     ` Cedric Jehasse
2026-05-26 12:35       ` Luke Howard
2026-05-28  0:17       ` Luke Howard
2026-05-28  8:11         ` Cedric Jehasse
2026-05-28 10:15           ` Luke Howard
2026-05-28 12:46             ` Andrew Lunn
2026-05-28 23:13               ` Luke Howard
2026-05-26 13:15   ` Paolo Abeni
2026-05-27 23:52   ` Luke Howard
2026-05-28  9:19     ` Cedric Jehasse
2026-05-28  9:49       ` Luke Howard
2026-06-19  5:00       ` Luke Howard
2026-06-19  5:59         ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DED39BA6-C627-431F-B406-2C5A19DCE2E4@padl.com \
    --to=lukeh@padl.com \
    --cc=andrew@lunn.ch \
    --cc=cedric.jehasse@luminex.be \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kieran@sienda.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=max@huntershome.org \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®