From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vs1-f45.google.com (mail-vs1-f45.google.com [209.85.217.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF9262C11DF for ; Tue, 2 Dec 2025 17:49:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.217.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764697766; cv=none; b=WkSvqklzWm5OTn3liutslyFogipl3hm2FtuIbRG8iakh73BhEbLfS3f3Wswzy5O6zAsXuaEMI/1fzqiVlLCjXW2AtaFT3SOhGEtpj8eUjuADwQ52fSodohAkERH/QhAb3+Q+17LDdX21G5f9tnOsguWlPuTRdc8i4tSNhsdk7PI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764697766; c=relaxed/simple; bh=lFD7YqZqIOM9zNsrKDqdar20gGVc1+ve8YCHIZohhpM=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=Vx/JghEZCJbK/nCh5OgJfOcThp1Cgqt25FfMo52FiZbFZkZlW8JFe06hfX1QwXvsVjx9oyAEoSHmvfcd9gnKMVnBDb9FqEmMaYjZchJlfvaDag/+DgyyGwOanAUzIepOoLmfC6YH8EYjWbWQa4YBadRhr1QrmGLyTKOW6WEPG4Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=URILl8/V; arc=none smtp.client-ip=209.85.217.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="URILl8/V" Received: by mail-vs1-f45.google.com with SMTP id ada2fe7eead31-5dbd1421182so4705716137.1 for ; Tue, 02 Dec 2025 09:49:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764697763; x=1765302563; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=lFD7YqZqIOM9zNsrKDqdar20gGVc1+ve8YCHIZohhpM=; b=URILl8/VJruojCS6f31vNbZIiVbeMhvow2XTLdM+aRSUgEbYITrpCJdqmzRqSPhOKi +Xr1DOivvb/Ez4kdeM3/a0Nlyg+qf2FwZOpYGjmPfZEnJnQ3m2MN7w0TvqcQgl24ULZc IbJsLnbqKFBgT+DuDrg3t+pSYrtl6naxOkFs1Nk965BG4WBPV4P+aVkSTiYmrI2vK8Mj byZ6qg7frR6de97B87+sA6e2uy5O4cx0NcPE9G49Xq7BU8a0dKiAAdGYH5T4jhYSJmjg AyJ1/U14rBuFaWLuy0BuzGZHc6WJ5fcMas0Mv5hw6UZfsNkaHldWJKCWayQlWq77AuEn 6uIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764697763; x=1765302563; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=lFD7YqZqIOM9zNsrKDqdar20gGVc1+ve8YCHIZohhpM=; b=dvrkpSI/1kZjHg5NjehzNdM7aG1MriEnZXNH3Dnn/zU7qlCSuxV9fCoek+U447yGcM Vm/Y5zHoGLXJ+Cn5oSciOwqKK/+BCes2b6wcE1FYwho71kzxN7oYSkdENqAqcxTA9TB/ s0AnkMrghzcdCwOl2TH1wYbr6+J+PwoibR/XqLCb1GWdQ0+zFbFGmD1452rCAg3Gp7XR 878lbacaP8Ij7ZEQ8KrtsnCSKeeCGvFA+S8AzrnzFlpfcy/PHlEgg3iACfkdK9OEDcWn gwmgRAN+DqYfTOcwe/Pb6fj0+Ug2REYLEDLJQVVppQkav+ddBOTHyhe9B6SKa6+O+0kQ rK9g== X-Forwarded-Encrypted: i=1; AJvYcCU8PX+HbIF17gjK4joPhfGAqLz6HeH5yRpQokC37gbQFQ0MxFWrasIQ6AIP3WKsUbUodPA8ufkKWsz2t3Y=@vger.kernel.org X-Gm-Message-State: AOJu0YzFBcvz6rdVPZQKwitZ++IEhqCEB7te+TzaWbPDPirqU2AWmIyS B6GtqnECP597p36wx4KE6SEw5Zr0DnfHLvyareFDh2XMxpE9S4C3v+jg X-Gm-Gg: ASbGncukiHRUYVGRuVfv+8hE9+IKGLEDTAzSCRXDCboDmQ8/6OvY5FkO73cXKo/mY+y 391a+pZCQyQky/3v8nezUNPGnEJH3NIl+iLcmQy8XeHbqu8b858f3TEx524cM7szEz8xgjIciVW Omqkyq39ZUpj+b6LqJu2zaDQu7BquMl+YtuiwGT7axBBRJmYfWZ9Y1QyZwR9gx1CNGyOVxO8D7u gJDDy5gBfNN20zlVnKh/JngE6ltK5OLORFAgsH0TGCr2x4JF96LMU6jhgYS34vaVWm/2C8lKDBT 8EVkrFbrSwFQZhwR0LqO7V/rsF8IDLZ2uc5fmA0XKYfxD5CWbb53ioer5Yt8dVhgCP7Qyfy5aes RS4rxsPjS+hDcbbBTZRZ8o25CmShPtojoAgCPusE653JuEgHgOIIQ8cD8Sr59AcZ0+SDxHL60ua DCsYFRFKx8QAexaHKg X-Google-Smtp-Source: AGHT+IE1CcIiiEo8CpEWTWXoBBMghBqvdzUH0ukhewnvrLWZreULDTL/mlRBc0qJBYu4mG8WzyOq3g== X-Received: by 2002:a05:6102:54a8:b0:5df:c10a:6683 with SMTP id ada2fe7eead31-5e2243e1470mr12768970137.35.1764697763507; Tue, 02 Dec 2025 09:49:23 -0800 (PST) Received: from localhost ([2800:bf0:4580:3149:7d4:54b1:c444:6f2f]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-5e24dce4a6fsm6362031137.9.2025.12.02.09.49.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Dec 2025 09:49:23 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 02 Dec 2025 12:49:21 -0500 Message-Id: Cc: "David Lechner" , "Jonathan Cameron" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Tobias Sperling" , =?utf-8?q?Nuno_S=C3=A1?= , "Andy Shevchenko" , , , , "Jonathan Cameron" Subject: Re: [PATCH v3 2/2] iio: adc: Add ti-ads1018 driver From: "Kurt Borja" To: "Andy Shevchenko" , "Kurt Borja" X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20251128-ads1x18-v3-0-a6ebab815b2d@gmail.com> <20251128-ads1x18-v3-2-a6ebab815b2d@gmail.com> In-Reply-To: On Tue Dec 2, 2025 at 9:59 AM -05, Andy Shevchenko wrote: > On Tue, Dec 02, 2025 at 09:39:34AM -0500, Kurt Borja wrote: >> On Mon Dec 1, 2025 at 6:09 PM -05, David Lechner wrote: > > ... > >> I agree, this naming is a bit confusing. >>=20 >> Andy, are you okay if I revert this back to __ads1018_read_raw()? I can >> add a comment on context. > > Only if it doesn't start with __ (double underscore), just find the best = suffix > (or prefix?) for it. > > TL;DR: I'm against functions without clear semantics to start with __. Us= ually > this means unlocked in terms of spinlock/mutex/etc. Is it the case here? = IIRC > it is not. It is the unlocked (iio_device_claim_direct() mutex) version of ads1018_read_raw() which is the .read_raw callback passed to iio_info. You might be thinking of ads1018_read_locked() which is an spi_sync_locked() wrapper. I will rename it to ads1018_spi_read_locked() to avoid confussion. --=20 ~ Kurt