From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vk1-f172.google.com (mail-vk1-f172.google.com [209.85.221.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 27EF723B604 for ; Sun, 7 Dec 2025 15:59:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765123182; cv=none; b=jQeEJJvSkxSuVCjkRn6+aOVVR1Aa+OC7a1ZCoirdHIN/K3OmIJF85Y3ovoYB2WUCIevbCayBuSweoWcHzk/5Jxv5j4UKkOQWgsPvQ8gahUT8H/FTShHgYG9Uv3mfZSx51CqafVwFjIScAMqYAyM1LVRL8u35FS1StJLYmH4zx6k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765123182; c=relaxed/simple; bh=yyNUlROQCvKp4HOi2SP71/oqKu0yWaC+JHckQnMu9DQ=; h=Content-Type:Date:Message-Id:From:To:Cc:Subject:Mime-Version: References:In-Reply-To; b=C0Y6CP2MQA3rHU9LEq10LULF58prIsy8uo34tc66z9pTcaMkeT2V9kHr9J3aV9QrWPgfKTz/oI6MN0+6SbMif/8SEbMkQMECeAJZ9VDzy4yL+5xmxJBxDbnNByax/PTt2nGVeZjuUCPZGJ0WVjxc+xmC3vj4AHTTT/WHWbwg/l4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Q7apaoMR; arc=none smtp.client-ip=209.85.221.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Q7apaoMR" Received: by mail-vk1-f172.google.com with SMTP id 71dfb90a1353d-55e8c539b11so603333e0c.2 for ; Sun, 07 Dec 2025 07:59:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765123180; x=1765727980; darn=vger.kernel.org; h=in-reply-to:references:content-transfer-encoding:mime-version :subject:cc:to:from:message-id:date:from:to:cc:subject:date :message-id:reply-to; bh=h1tqJEH0nvtzunebE0gFQ9Z6ukbX9uGV2B9981sp0bk=; b=Q7apaoMR8IQXj/ugax8lNuArcR7ygGwodTrfhDEIeVtEdgORzkx5l9K4+1xKXv/zzQ gbiZLuVOLHa1HxDt1+Vv02v27u5CdOSDojovSrWUObZAYFGHlga+3sU7XUnW3zQ+odDJ U2YBGQM6jmfMl02sv3p2vb+Bj2LagdxuIiwAl4kTbrnX5zLYa+DgutDWLYXSBS1hOaCq Cu6lZKmzMfiY8eLzuGXujNuyxFlIzjLRWNNfo+gvpNGtLyX/N8ZU7QQlXK246dWJglNr MMT/fkNwvMlg7XsuQ1YfLApPyzoowJvmv4WMuspmwAEy3LsDpi3/p1YbrEaipQd3c3NL CGvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765123180; x=1765727980; h=in-reply-to:references:content-transfer-encoding:mime-version :subject:cc:to:from:message-id:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=h1tqJEH0nvtzunebE0gFQ9Z6ukbX9uGV2B9981sp0bk=; b=XKTHNf7EkGHHYaH49HCxQ2kviP452dVTWyC+pF2So/5YglZx+8ZqAXsFekzfbBAjmr unC/T7p/jBYJrG8n743RXzwoSgvv93jfcSciPjKEmExdsJOg/s649rVQpmmdgwAG9qFe yu4rXXqpFBRvkzlqb7fT+n5Jm0cvtletUdFHqeFFn6rrM+b6nPA2tZoq406EDEZFIPLB lV6NGLRg7Z5tw7zypYyXhMDdJrjgxqAcI2/6FV8ghUqxHxbYfMqq4mIz3mIdjUnez7PE YuPTLqWNxvLl8U9i6wZ1bIn2fOCF8MZw7KzreVCPJlVYfe+dTLwQcZlGPHh9bgNEt1Ud LY5g== X-Forwarded-Encrypted: i=1; AJvYcCU6kHuRQo4YvobJGCEv6cDYrsToRCxhxyxyTM6kAko+ynMRMvuE0ObbPh3XdNK0URmjO1x1WBHZPfDk5RA=@vger.kernel.org X-Gm-Message-State: AOJu0YxNVGVDmZla1GLnE5CMadxMfQ/5AJM7ENruw8FF1ZZfA2GANMvd CoDTbRLtuDWVrktcpoDKqSZfRUoefJ+j4w7rZlQ6U2XIC8WtDEgfctmC X-Gm-Gg: ASbGncuxtA51G16M59lH3OXVUvSMk6wSkGhPM3JOrn4alcWbdily2DNJQ29lES7fIEc y7nBzY4Fgha+Up/mE+jvhp3nhkmeMOdw/R0aLpU/t368WnLwcrbWT7Uj0f82pcEGSN/tns+HP4t hv+RNHgnxO7kcNB4TgnS0c9HpMefh9xMBB0jMA89gjO2jgJ220Lld6nP2FB4ihJqppFOhTw3CIF 6UavNs6qewLJzZVHJskuiT8p8pDNorffXlY/uQhudNDdfSNUxLTQ0R69YIBdvMZidjwk1Aqdne0 nL4O38tVacEgi8rtAyYTOgsZXslCChCFMVk2oAF4bvbEF66Bg8XVvAIWjWvSVagWgbezjFLkODH vm/j/5zWBQT+KdQGqTgFYpfx8VCCAC56q7d4CscriGklOMHmAU1aUb7pi2fDaO87QBX5hVreoen xHIvM= X-Google-Smtp-Source: AGHT+IH3R7zodvMeVJJJJ7fn2S6JQ+o/S6MOmjVgK3nMnTwxe+33R4LGyRZImJUof8loaB4NiZRB9Q== X-Received: by 2002:a05:6122:6598:b0:55b:d85:5073 with SMTP id 71dfb90a1353d-55e84587aeamr1556249e0c.4.1765123180107; Sun, 07 Dec 2025 07:59:40 -0800 (PST) Received: from localhost ([2800:bf0:82:3d2:875c:6c76:e06b:3095]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-55e6c972414sm4860987e0c.15.2025.12.07.07.59.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 07 Dec 2025 07:59:39 -0800 (PST) Content-Type: text/plain; charset=UTF-8 Date: Sun, 07 Dec 2025 10:59:37 -0500 Message-Id: From: "Kurt Borja" To: "Jonathan Cameron" , "Kurt Borja" Cc: "David Lechner" , "Andy Shevchenko" , "Lars-Peter Clausen" , "Michael Hennerich" , "Benson Leung" , "Antoniu Miclaus" , "Gwendal Grignou" , "Shrikant Raskar" , "Per-Daniel Olsson" , =?utf-8?q?Nuno_S=C3=A1?= , "Andy Shevchenko" , "Guenter Roeck" , "Jonathan Cameron" , , , Subject: Re: [PATCH RFC 5/6] iio: health: max30102: Use cleanup.h for IIO locks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20251203-lock-impr-v1-0-b4a1fd639423@gmail.com> <20251203-lock-impr-v1-5-b4a1fd639423@gmail.com> <20251206181758.2bfefde1@jic23-huawei> In-Reply-To: <20251206181758.2bfefde1@jic23-huawei> On Sat Dec 6, 2025 at 1:17 PM -05, Jonathan Cameron wrote: > On Thu, 04 Dec 2025 12:47:08 -0500 > "Kurt Borja" wrote: > >> On Thu Dec 4, 2025 at 12:35 PM -05, David Lechner wrote: >> > On 12/4/25 11:07 AM, Kurt Borja wrote: =20 >> >> On Wed Dec 3, 2025 at 4:52 PM -05, David Lechner wrote: =20 >> >>> On 12/3/25 1:18 PM, Kurt Borja wrote: =20 >> > >> > ... >> > =20 >> >>> I would write the whole function like this: >> >>> >> >>> static int max30102_read_raw(struct iio_dev *indio_dev, >> >>> struct iio_chan_spec const *chan, >> >>> int *val, int *val2, long mask) >> >>> { >> >>> struct max30102_data *data =3D iio_priv(indio_dev); >> >>> int ret; >> >>> >> >>> switch (mask) { >> >>> case IIO_CHAN_INFO_RAW: { >> >>> /* >> >>> * Temperature reading can only be acquired when not in >> >>> * shutdown; leave shutdown briefly when buffer not running >> >>> */ >> >>> guard(iio_device_claim)(indio_dev); =20 >> >>=20 >> >> AFAIK you can't guard() inside switch-case blocks. I don't know the >> >> exact reason, but it has to be scoped_guard(). =20 >> > >> > You can. You just need the braces like I showed in my suggestion. >> > >> > The reason is that guard() is declaring local variables and some >> > compilers like LLVM don't like declaring local variables in a >> > switch case. By adding the { } scope, the variables are limited >> > to that scope and the issue goes away. =20 >>=20 >> Ah - You're right. I dind't see the braces. >>=20 >> Now it is overly complicated. In this case I see why guard() isn't >> really an improvement. > > This bit of guard() usage is fairly well known and I think people are > getting familiar with it. > > So I'd prefer the form David suggested. It is nice to get rid > of the mode claiming dance in here. Ok, that's good to hear. I'll take David's suggestions for the next version. > > Jonathan --=20 ~ Kurt