From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA7F61DEFE7 for ; Mon, 8 Dec 2025 07:39:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765179583; cv=none; b=pStYZKTw9vlPjnHc1tMsNKtNoczQL4RSngVH0IqJ77DVLRAooba+gTDv8iLJrzFbZPQldK22v3VOKaKKzwEo45IXIrdabbVwXVxSuODKTnWTKlRmQ3sPj0mgJhaouVmPjfoVx+vk7bCv8s944BnBbKWUDvxFIpaPX+e9QpSeDfc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765179583; c=relaxed/simple; bh=EeUvP8/5rtip2kMQhBrOSahB2ZnNFc+Y3ZX8VhH2o0k=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=NYJjn2ZijM5BWsJHdQU5css67otri0FxQgC0MtvR8lpxNFWih2QWPIXwp89bwP2U9/WipJxjqmuzCHwsBcm/u5gP+5648krMAhugozc7w7tmEBVB9K9bHYmS2dqeOCkoyrM/68WR+tJ6cjdnXA1M5HavHeeEfnj2aLvs3mYJS7M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=SYOkF8c8; arc=none smtp.client-ip=209.85.128.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="SYOkF8c8" Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-4775d110fabso40051565e9.1 for ; Sun, 07 Dec 2025 23:39:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1765179580; x=1765784380; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=v+1ssDKimEy1YWQnfRj6jC4uzuK7az5xDxnS/OPdEg0=; b=SYOkF8c8kvH6j2NqbzQ+tKDVkZxjF3eT+0/EfQ3uknYXjRloxCAvxgbhVx7lCg1mU2 Fdjf30JFwrxRZGakrrxG3LNkT8Oso+z3fTjvVY1Bg8Sb6KOOuo0LTk0bZr87Nlz5kACX 9MYmS43sTBtYA54wPX+Np1QthabXcwqKjuHY+FPjbdznwdtgdtwgWRKvjKSFgvXMBKL2 PrTFKRiFbtyWLVEnrmv62hOFo4NjIufqkvMV1wo6gceYUABIp3h5B4vPQ9Lsjp1YDPwJ H+fRFDJc2P7+tJCteXji6P5iAP1LoRtDOQTBzLDhQ51+rn4YCwmc1c9VUVt7LWVlb5/6 RQxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765179580; x=1765784380; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=v+1ssDKimEy1YWQnfRj6jC4uzuK7az5xDxnS/OPdEg0=; b=JWRMqIQp39r7GpL0NNUfBynqsQmAU+zZZRFeCg2TL1IVSJx2uAgy62aIu/HznHr2hB QxbI6pFJJpmCOPTC5QKaefjxW4EiuFwlBCyn7jpzwC92ybuVJlYUeizCJ8RIWidwM/ED Ih+XihS9v/3Zbrm3qd2RWSTeL9MPk0VtAQ0tb/8PAX69AUSxDeYawegJ9wt0Zx9VUaDn 0r/Oil2sCuJ1JKm8mSL2KI5YVAP1THmGjtMD5xL4JJiLb4AFxZjGBYuPyu6/LNN279Tp dHrTATpH27d8q/Il8gQkeMOOqVUF4qICnTq+o+RSVWQl6bd+p/oPMgpd6Uc7WI9J+Rr3 xFrA== X-Forwarded-Encrypted: i=1; AJvYcCWnNA4+ynq5RVmSr36bKfqyqYXgGHUEE/U77Nc1s9NIfBZNRZHWibepF0aZYJf0jHcI2PEnAWlp4wGmO3Y=@vger.kernel.org X-Gm-Message-State: AOJu0YyF8psDRezopjYg5YVgvhX4EQG7kGPw23CiZIEHfl8P2uPYa/N1 Qvkde0so7A1KvT0brmNz3WsI72fSstL+ygfg7nTwoM2ezcP/y3KmsXCXYkDe07NFiAuJ1PhUZZm +uMoVKoTrFF5HeA== X-Google-Smtp-Source: AGHT+IHvVBiPRFe3ztaMxMTZdIQQQD0RDtpj8NlE3BbQLqpyQhxnvDTt5CPJ2CvTqc9YXyalpRNMld9mzGp21w== X-Received: from wmfu9.prod.google.com ([2002:a05:600c:1389:b0:477:98b9:1e26]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:6289:b0:477:7a95:b971 with SMTP id 5b1f17b1804b1-47939e48f61mr76546105e9.31.1765179580124; Sun, 07 Dec 2025 23:39:40 -0800 (PST) Date: Mon, 08 Dec 2025 07:39:39 +0000 In-Reply-To: <96aa9bf7-1f1d-4870-90d2-84d3d6d4254c@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20251208-b4-vmalloc-might_alloc-v1-1-94a9bb8ecb08@google.com> <96aa9bf7-1f1d-4870-90d2-84d3d6d4254c@arm.com> X-Mailer: aerc 0.21.0 Message-ID: Subject: Re: [PATCH] mm/vmalloc: clarify why vmap_range_noflush() might sleep From: Brendan Jackman To: Anshuman Khandual , Brendan Jackman , Andrew Morton , Uladzislau Rezki Cc: , Content-Type: text/plain; charset="UTF-8" Hi Anshuman, thanks a lot for taking a look. On Mon Dec 8, 2025 at 6:41 AM UTC, Anshuman Khandual wrote: > Please add in mm/vmalloc.c - otherwise it does not > get built as GFP_PGTABLE_KERNEL is not available. But otherwise LGTM. Oh, but that's not correct, IIUC we shouldn't directly be including asm-generic headers from here. So while in principle GFP_PGTABLE_KERNEL is a sensible common demoninator here, it doesn't actually exist at all everywhere, e.g. it doesn't look like m68k defines it for Motorola. So maybe the best way here is a really vague: /* * Different archs allocate pagetables in different ways, assume * GFP_KERNEL as a common denominator. */ might_alloc(GFP_KERNEL) ... a bit yucky but I think still useful. Any thoughts?