From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 585BF312808 for ; Thu, 11 Dec 2025 13:14:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765458851; cv=none; b=nxYxwEb0LxYHa4/WWCW7woEPAlIoHG1hu2WeTfyu9sAMj+TA2sX2b/30gGVTTlRsNiVzUJUSItNpjO4v3BtDoNK5MooFQKSArN26KKuS56VBAYNLVw14rgT3ebSildOI3fRtOU3isazMmEngEVYfcUaDR/dRCFWqdBSsXGEq8/s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765458851; c=relaxed/simple; bh=XIqiZt60uLQglTTo5Pq+ym7qDtMv5j4vzyppbp2/0t0=; h=Mime-Version:Content-Type:Date:Message-Id:From:To:Cc:Subject: References:In-Reply-To; b=h/p9aP4ayE4u5dAhOFo6UQcFzSIMI8QYOw+u800tSXrhmdm8wsj1+LZOpsI3JunQrT5wPkCMnDdXvtu+vGBq3SKWclEdH5DmQzuLP+AXAZH8PYSvxe/Knr0IlwJ8mXoQ6koIkjE7yk0i7VbdBgsr4tYUMgmg4T038GjOZEhSuL4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=TTGHjlrb; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="TTGHjlrb" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-42e2ba54a6fso32244f8f.3 for ; Thu, 11 Dec 2025 05:14:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1765458847; x=1766063647; darn=vger.kernel.org; h=in-reply-to:references:subject:cc:to:from:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=cF0nCy3K8ZLd3O9dxWEhMzL6K3i/vuZmXtZs4+t9Dxw=; b=TTGHjlrbxPPfSc/q2pzcTVQNTtBju/RrnmMkjAa9kEWZtK3wemL0csefDXvHZIpuKg 5euXS5wJfy470Iafdwb7lPc7bfq25lBCqn1rWeD+wvOEVAm0IdB4P5vlbjMemZMLlO6C niI3GHYR6O02i+S1ytNfaLKTyLKXE/fdmJrqXWOQf1Yl6wSdcdGdYHU28GU3dE3is+k5 G9Z+YaTjp8SiSgU8/jsEaXN4v1QZITJA4ggYVmT7kmFoItxlEZizXMXwGqdJC+heDjOC +PZBkW7qI5uSxFYkGP2yQwOnm5PVNjzy5V3VX08DaQdeGdn1XYAL0M885+I/DRIktZSI JdjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765458847; x=1766063647; h=in-reply-to:references:subject:cc:to:from:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=cF0nCy3K8ZLd3O9dxWEhMzL6K3i/vuZmXtZs4+t9Dxw=; b=O2VAYZRlXH/kpeh3P0F2touzquZSwRyCx0ACUpAmXh+FSjpE63de+780n3L6MpnlYB 6QSTboucNF8fcK7KLGgkY2cjnmO4f/IELKyZuYxEWiUFYAuVUomDd8PkVVkJG3/IpHry PcRVwNnSKHYwkBue79KZcOZL1YP2Ugvq15YExxs2c4ewJ7oXFHHbetaq2805tw7LwvlK DmDQSPearvc2pW/O4k7Mtb9wNhjReUfWn5PQY/7TumF/Z8A6Z7MIABY2Bp5pGpGkSTqb rd404gjyePzfjKstu8bww/5yGMBZboi2oXV3rGQD2EF2b39xaSKoKv2sz+sMA7Bxa3tF dBUw== X-Gm-Message-State: AOJu0YwHlwOSLRXOclASnt9CKq+aDZ/GrdXVoBb7POaiSJDM4fB2qKsU xWazr3OxMQFO6a6Uvs72vd15ED0+tsTMmxAiffkBnlhOPESIUjh7H4iDfpurdejk6mI= X-Gm-Gg: AY/fxX4K2aMmBDx5CawcQTkbHPjzTQ2CuW8oUy4elJNurHn4GeNEdbWqDWHNovtCmV0 jzRSYi0EmOqu1hpbhLIJEV1yu5elJ54FBYk66KWZY4IJQk3/96smjXYKCc5F2DapNBKBKexpvS+ ervyA4poDXu7a0AWcl7pvthw8yof7D9atOWLD+TJ3UynvAzMU1IidzH+RNhV9v1DryWD+54SZ1U XV96mEyeUe6b+FgL2XMDe8VmeZVkSLa17RlTYPZH1HvmfoNcgEZpd/ibTfkkU6bIDRHd+2lTuGQ yBLEhf9S/83KlWqLovZOdfDzM3sKtgjt7PSVl05Qp7ssv1zSr9u1zk6tstiJEPHrRpgKMF6NEou CbztW71MO1WJQbpqv/Cmgg+aKndldGJg5zuqk7JJ3bWj94EAkYyet2CSk/06AtpWGXjtPvMf6s4 YR7VvwI60aWIuccd42 X-Google-Smtp-Source: AGHT+IFuFpTFsvxTJRwslx5ZMVgnCZWiNXSiHVXO7iLSyGUOA6ovHk2vIf/10hdCpVsmTmaoDOpjWQ== X-Received: by 2002:a05:6000:25c5:b0:42b:43cc:9827 with SMTP id ffacd0b85a97d-42fa3af896dmr7158361f8f.38.1765458847497; Thu, 11 Dec 2025 05:14:07 -0800 (PST) Received: from localhost ([2a02:c7c:5e34:8000:c186:ec41:4ac0:f434]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42fa8a702a1sm6260871f8f.13.2025.12.11.05.14.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Dec 2025 05:14:07 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 11 Dec 2025 13:14:06 +0000 Message-Id: From: "Alexey Klimov" To: "Vivek Aknurwar" , , Cc: , , , Subject: Re: [PATCH 1/1] firmware: arm_scmi: Increase MAX_OPPS to 64 X-Mailer: aerc 0.20.0 References: <20251014073454.461999-1-vivek.aknurwar@oss.qualcomm.com> <6af5945e-7d5c-4596-ac42-c5898b4c49b7@oss.qualcomm.com> In-Reply-To: <6af5945e-7d5c-4596-ac42-c5898b4c49b7@oss.qualcomm.com> On Wed Dec 10, 2025 at 11:28 PM GMT, Vivek Aknurwar wrote: > Hello Sudeep/Cristian, > > Just following up on this patch. If there=E2=80=99s anything missing or > needs adjustment, please let me know. Vivek, please avoid top-posting. > On 10/14/2025 12:34 AM, Vivek Aknurwar wrote: >> Some upcoming SoCs define more than 32 operating performance points (OPP= s), >> exceeding the current SCMI protocol limit. Increase MAX_OPPS to 64 >> (next power of 2) to support these configurations. Didn't touch for a while. The way it is stated confuses me a bit. Should the value defined by protocol be updated out of the blue? Should the protocol (defined by spec) be changed first? If protocol changes, then should the version/minor version be updated/added? Thanks, Alexey >> Signed-off-by: Vivek Aknurwar >> --- >> drivers/firmware/arm_scmi/perf.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >>=20 >> diff --git a/drivers/firmware/arm_scmi/perf.c b/drivers/firmware/arm_scm= i/perf.c >> index 683fd9b85c5c..2249ef7fe790 100644 >> --- a/drivers/firmware/arm_scmi/perf.c >> +++ b/drivers/firmware/arm_scmi/perf.c >> @@ -27,7 +27,7 @@ >> /* Updated only after ALL the mandatory features for that version are m= erged */ >> #define SCMI_PROTOCOL_SUPPORTED_VERSION 0x40000 >> =20 >> -#define MAX_OPPS 32 >> +#define MAX_OPPS 64 >> =20 >> enum scmi_performance_protocol_cmd { >> PERF_DOMAIN_ATTRIBUTES =3D 0x3,