From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C843F2836A4 for ; Thu, 11 Dec 2025 13:54:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765461245; cv=none; b=tQOWcJIS+95yJ6JBLfaWOZjF6NYjlI53JJ0FpQoaJSqjwbxuFNbbxABZ18aaS9ITpdVn+BcoTBIIMx8XDDUqYtTE3z2zX7GT91WNRKDuUvXevIvZCxTmKSAKXozZFzdYISvqeX9XgyETYCtmvmqnktyE76HOV+MTUq3GyTx0u0s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765461245; c=relaxed/simple; bh=LaMjw6WZXgqTfqGi1P4GQQSrO0jGN82EJsNdVi5wyRw=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=YAwO/q0XsyUM7QhWxJT3fW06ge/IeMikvFmuDULZil8pk3SaarlIhymO/TaPT9zjxKJOYUziTYOtLupf3Ugh+UoPVAecCDnHIqPu45EkLng9PuWeJFhqeycRl/Os91oCdKuwwh3+kel2F2791GC7+T4LsdGSCnxPUpZ4xav21rw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=DN/ClVNK; arc=none smtp.client-ip=209.85.208.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DN/ClVNK" Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-640c1fda178so240010a12.1 for ; Thu, 11 Dec 2025 05:54:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1765461242; x=1766066042; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=CIXIt+IFeFpXZPRj0PX+jv/KP6j4AjZrxFu7fBe+lEU=; b=DN/ClVNKRk1BAy7P7ctmfJ7w6xJwFxVfnuxwcmkLkn1OzRidlzxLvF1fQ8ceCtOc3c 8ksEovZKRkw4voN8+TCUCr2o1On7a2VMvrer5aRkr+IDyY9FEA2cdKqp7XYPovsYNJmU MkWLy6YlDQMejE1o75xMNSLJg5HBxrHDsRIfOiqeIQQM9fk3HE1EdXlNsbybBGyt6SXc IvCzsg7tvhySCB7J1JMhDQKocoL42ixAaT5FjSkYfluO5KoS4y5xU3vl9wEmoX3ahHPM m7AnfAQR9BKVV1Lmv4zSJV6hOTKEML7PIH9VLNwFolIY2AVTax7Cv0fgobGrz0tK5HFC ADLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765461242; x=1766066042; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=CIXIt+IFeFpXZPRj0PX+jv/KP6j4AjZrxFu7fBe+lEU=; b=LwPSB+9YLPe0B0E83fTfUGFhfNnQDOIcStgZqLgQxE+cAjfPky6lcThOOcDovN0EV6 A5IVzye/eA+b25XgHqzy+5kGMyYFpHdEjXL77JCmEjeNbJhusLQ0a1HMTga4+iyX/acr cmVyp/C4fgPw/JAUoaYu3MYBW+HaA69RT2WrlXu9KfO8qPOx8CejW6ygH+YvNO13OIff BCNjNCbfYU9JiIfn2PRjS4EpkU+eDCDrIS20NXfDrr/ULKptBCtSOnTqLNI38wjmmrCX JegS7Vvc//GzrNwT6gMfIbiVSoDZRfy22X2JjnR7sGKls+qHa737zmgdGSp5L1cGWWs0 pZeQ== X-Forwarded-Encrypted: i=1; AJvYcCVsdPZlUICus2zzV0gUk6LRpZpHM8Lch98LycesWybzHyoJkIEQwTutmS873cPZcfLshmPlfvsQWJoPOIA=@vger.kernel.org X-Gm-Message-State: AOJu0Yz27rH/gscA8yMjVWIt+nfq74oALysR7vK0mT7rdA5rqtvQMiDW biPreWbLlAQEUIoU9gMBnPqQmrn6/umMpZa/bPLSWij+jF2nNXObGnPvQb1RpfhbCTY= X-Gm-Gg: ASbGnctHxvgbJaiorfKvihQxVkBiMp8OqcixGeDDT3z6Sb8y0k6sQMhvgM8WBg5HVI/ RbCDITkh8AKIztsM/IVcTBHqoallpTcipoZjcdYbY2XwVY/urKLdWmVP3nPSj+uBoOyelIzBZJs JWi+v5qzdoR9ncHx8nmCKxm29L1gDD4CVWHp2zE9LNCIy7U85IEdKpzpT4scxEkm1rZ5Hkl6OpS WDe9PhXJw8wydzIlNeBN7YAXvEDMN/AvJylOGIkHg/08mk/8XUY82tV0EmmxlWsiqTKtylnuJ4u E6Spe/Q56Zs/86e2rcWE6s/uw3fa2Z15X+VbUG/L9DkqhmSG+omJnKwsOmaj+QGJORh4TI28/+q Ot1ouah/4T2QTwc4qcb5Ib1mXhpl98e9T437tpCk4BJ3eP/1Fvscb4U9CJ3TSPDUXUPK12tTsnb JUz9WgRe2bCoUMzU96 X-Google-Smtp-Source: AGHT+IGpApL3VVGRNVrShbz2gpArNfF9x0CWWaOzqj6DXl7ZGwWDs4SYfO44oU/8DNb+tdYYpYB3Jg== X-Received: by 2002:a17:907:3f18:b0:b76:277b:9a5b with SMTP id a640c23a62f3a-b7ce82d3515mr657352366b.6.1765461242068; Thu, 11 Dec 2025 05:54:02 -0800 (PST) Received: from localhost ([2a02:c7c:5e34:8000:c186:ec41:4ac0:f434]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b7cfa5c8e59sm278436266b.62.2025.12.11.05.54.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Dec 2025 05:54:01 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 11 Dec 2025 13:54:01 +0000 Message-Id: Cc: "Vivek Aknurwar" , , , , , Subject: Re: [PATCH 1/1] firmware: arm_scmi: Increase MAX_OPPS to 64 From: "Alexey Klimov" To: "Sudeep Holla" X-Mailer: aerc 0.20.0 References: <20251014073454.461999-1-vivek.aknurwar@oss.qualcomm.com> <6af5945e-7d5c-4596-ac42-c5898b4c49b7@oss.qualcomm.com> <20251211-masterful-caterpillar-of-love-bc2d4c@sudeepholla> In-Reply-To: <20251211-masterful-caterpillar-of-love-bc2d4c@sudeepholla> On Thu Dec 11, 2025 at 1:48 PM GMT, Sudeep Holla wrote: > On Thu, Dec 11, 2025 at 01:14:06PM +0000, Alexey Klimov wrote: >> > On 10/14/2025 12:34 AM, Vivek Aknurwar wrote: >> >> Some upcoming SoCs define more than 32 operating performance points (= OPPs), >> >> exceeding the current SCMI protocol limit. Increase MAX_OPPS to 64 >> >> (next power of 2) to support these configurations. >>=20 >> Didn't touch for a while. The way it is stated confuses me a bit. >> Should the value defined by protocol be updated out of the blue? >> Should the protocol (defined by spec) be changed first? >>=20 > > Ah good point on confusing commit message. I just assumed it is limitatio= n > of the implementation. I can update the log when applying. It is not spec > or protocol limitation for sure. > > How about this ? > > | firmware: arm_scmi: Increase performance MAX_OPPS limit to 64 > | > | Some platforms expose more than 32 operating performance points (OPPs= ) > | per performance domain via the SCMI performance protocol, but the > | driver currently limits the number of OPPs it can handle to 32 via > | MAX_OPPS. > | > | Bump MAX_OPPS to 64 so that these platforms can register all their > | performance levels. This is an internal limit in the driver only and > | does not affect the SCMI protocol ABI. > | > | 64 is chosen as the next power of two above the existing limit. Yeah, that sounds better :) I also thought that this was a driver limitation, not the protocol/spec one as stated in the original patch. I don't mind updating the commit message like this (but I am not the author of the original patch). Best regards, Alexey