From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C017336EFE for ; Mon, 15 Dec 2025 15:06:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765811164; cv=none; b=FSg6TppdXb6Q2c8kxmD/vDX6kTqZWXULUG+noMRwMgzYrL45jf6OZ1vrIRoJDCtaKCZ36X/0qhFsgZP48q9PAosAm0WF+YPqs295JfSi8K3JUx4kYtpBQ9qkjkpBGRgcrTkjoe6q4NiO+UZLmX2+NLAXXpZZKQc6RLgm/RA9AKc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765811164; c=relaxed/simple; bh=nrOkWpxHjNEBOqPfArlOaEnMZvp+OVYYOoIRNrFkLbo=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=bPZ0x47i6STDFFZfr5TrL0eqK9704PMeb6VCMGf0VvdqjrPrurbv4xL2VRu9Cz7zJtfBHD9kEiulYDUat6J0jD/5S7eyEh7K/mRQN+eAUuhYj9LTjPdDIczpje7KesHhCYzf5EZeYu6M1/6Iut3PFQCDdyyqd9hQ1jzhOVQNOJA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=etsalapatis.com; spf=pass smtp.mailfrom=etsalapatis.com; dkim=pass (2048-bit key) header.d=etsalapatis-com.20230601.gappssmtp.com header.i=@etsalapatis-com.20230601.gappssmtp.com header.b=xFwZGIFh; arc=none smtp.client-ip=209.85.160.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=etsalapatis.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=etsalapatis.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=etsalapatis-com.20230601.gappssmtp.com header.i=@etsalapatis-com.20230601.gappssmtp.com header.b="xFwZGIFh" Received: by mail-qt1-f179.google.com with SMTP id d75a77b69052e-4f1b147eaa9so28511591cf.3 for ; Mon, 15 Dec 2025 07:06:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=etsalapatis-com.20230601.gappssmtp.com; s=20230601; t=1765811160; x=1766415960; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=K8UioMReDfbBNUZGk/2S8/TUNrw8scab+rc++O6vx8U=; b=xFwZGIFhlhmgfZXj/ZUqZH6quTujULFhcT0ipZWAdDU9iZChxe7LYMMdsxV423+aFT krfCq5z2UpjfP3eRuv/Sw9LoWVFuwYD7ZIAPFMjGAfkUzDu+d/OU9O5qb5KuCC3+AGPh 9b9Tsv7a4oGzZVuPpXLvUPnxEKUu1NMUlMy41XxRytx2gJQA7hLz22a+kntjc040C2mZ UXeroXIMQEsZwDYkEODaIiKrAoNP5HIE459SF0YoEYdlnbRP7xTo0mFnq/buvGrkWfHm /ki5SPEO6nkuXBH4nZNT7YcDvpxl/boUpa4q6Ooe/RMOHxBJYE+ehsXLSR/YcNY2nLQ5 LX3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765811160; x=1766415960; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=K8UioMReDfbBNUZGk/2S8/TUNrw8scab+rc++O6vx8U=; b=iZe68TbdltZ8z8OIPvtT+F6zMTdCCBZ6Zt4a2nVuYeHXLPp6sPh7gy8dD9CEX+S1TW V2NPIoFbLrhLqAM2v8WztOdCWbDDJck0h7F5DisMc+d3WETdVp7rcUTsIZFtsjuWvhgM eNgrmihn2IY19XyW7jpR8bkZAnnqU5G96saSafPEUFwPrckhMb0pCFkfUphCXZ5LxcJb hon2mPjNxKi33K0uFlgLL4T4Gzb+MmG3ra1+kKhfpFm5GMuNl186fdoB3o8CZxxb7G9k rGJVZ4Eo+KmErFLBe3qFnmibMh/yRVPatxf9R/Tf+at3FXJv6b3wd5daYSjlShG+WDuL D3+w== X-Forwarded-Encrypted: i=1; AJvYcCVvRX5EMKE7L6P2IkZoAlWDudsjJ0lUWXGUluc9ckIk4oc8knHx7fySghh08ZEwbNURajvmDm+fiQm3kEc=@vger.kernel.org X-Gm-Message-State: AOJu0Yy6QqY6sa44Yx8LhonyU53LgELT3D/lAHj3sBabwosM1TduF4Yc Xx7PvW18UQjIeQ8dOu9XMCQQvFGdja7O7vpVKZj371SDvu/ETEAbTHbGTpYa4Wt9W6I= X-Gm-Gg: AY/fxX7Gs9ctAUJyVCFuq+8liaMhRH1ra6fZO3gvuPLXK0nFm8jqkFWPKoAoGYasXxA ZeKETJlqgZ4Bjh32WKoecvtZdu5l60/CAt8trcf9gdVWXbBoDqWgUKpxNncZEcVs7yJjpswY4dk TRvd3zw053+58AmN+vCyHjfMYIX6diNjA4K5EXSkT4q2e0RiR2GsfGl1U09QxjWYSUc/lIWspUt PvoHEfCUg8eGY+o0BzPhDpFNBz2a/BwquSVDOzBhPMXq/0wvJOZoFsSdhKL0OS1fomyWwpCoMaD kVwqQZbBlG7Givmu4sw3f4rblBGPlgrYjfiSjp+KAjUyy2b+alqwofUaGuv7fhIYa9RHVcvawh/ oywv7RV1vt/aIz5ihydGp9hkt1d43pFqY2L9auDfd8bZoWC1Q240f/5O8u/rkMe+c1fXLNq/OWH 1F654XMRXkPMI= X-Google-Smtp-Source: AGHT+IFf/1z4E8WernvLA0LqWEq8FCxr779h9f4/oeq1UH2bhP28LEaUKg0/8EUQOpyKrasmcQwaLA== X-Received: by 2002:a05:622a:2c1:b0:4ee:18e7:c4de with SMTP id d75a77b69052e-4f1d0622d74mr168157141cf.78.1765811156465; Mon, 15 Dec 2025 07:05:56 -0800 (PST) Received: from localhost ([140.174.219.137]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8bb78f21a50sm639135285a.40.2025.12.15.07.05.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Dec 2025 07:05:56 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 15 Dec 2025 10:05:54 -0500 Message-Id: Cc: , Subject: Re: [PATCH] sched_ext: Remove unused code in the do_pick_task_scx() From: "Emil Tsalapatis" To: "Zqiang" , , , , X-Mailer: aerc 0.20.1 References: <20251215112940.23640-1-qiang.zhang@linux.dev> In-Reply-To: <20251215112940.23640-1-qiang.zhang@linux.dev> On Mon Dec 15, 2025 at 6:29 AM EST, Zqiang wrote: > The kick_idle variable is no longer used, this commit therefore remove > it and also remove associated code in the do_pick_task_scx(). > > Fixes: 4c95380701f5 ("sched/ext: Fold balance_scx() into pick_task_scx()"= ), > Signed-off-by: Zqiang The change seems reasonable, but why is there a fixes up? This is followup cleanup, the original patch is perfectly fine. > --- > kernel/sched/ext.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/kernel/sched/ext.c b/kernel/sched/ext.c > index 695503a2f7d1..94164f2dec6d 100644 > --- a/kernel/sched/ext.c > +++ b/kernel/sched/ext.c > @@ -2446,7 +2446,7 @@ static struct task_struct * > do_pick_task_scx(struct rq *rq, struct rq_flags *rf, bool force_scx) > { > struct task_struct *prev =3D rq->curr; > - bool keep_prev, kick_idle =3D false; > + bool keep_prev; > struct task_struct *p; > =20 > /* see kick_cpus_irq_workfn() */ > @@ -2488,12 +2488,8 @@ do_pick_task_scx(struct rq *rq, struct rq_flags *r= f, bool force_scx) > refill_task_slice_dfl(rcu_dereference_sched(scx_root), p); > } else { > p =3D first_local_task(rq); > - if (!p) { > - if (kick_idle) > - scx_kick_cpu(rcu_dereference_sched(scx_root), > - cpu_of(rq), SCX_KICK_IDLE); > + if (!p) > return NULL; > - } > =20 > if (unlikely(!p->scx.slice)) { > struct scx_sched *sch =3D rcu_dereference_sched(scx_root);