From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f175.google.com (mail-qk1-f175.google.com [209.85.222.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59A66334C0A for ; Mon, 15 Dec 2025 15:06:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765811208; cv=none; b=MdTKcbaMCzFa0vRC7MNcWeaasr1kWHCjr5TYXv/gtXb4RylDWAn/wtiJtQpua48uYgwbf+AgJw0Ipd4PvKJrkiRMPkn9zdxp8PKuWDPGWXRWyvizgaqMg0K6VGqTk1i/rY7rrZGeGSNJLGSUD+eGFFdCjsVpMFc8ZizVZfzJIts= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765811208; c=relaxed/simple; bh=OjWyaveieyQFwEuXihYRsT8yTNIoJywqA/5FdNOoCs4=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=uKiQ3NFKG8Lr/S1i1S+ElAZT6ZRhS1GSG2OiNFPWT8kYqfkcnHt2fPDGEuEAMb2qd1ZzTnXpE/t4J8nJNj2CF5omjooyMpteB+UOOjU8GCAQxFLyTra4UGsNs8uQlyEreDg45UZ+OItRR166GWT78MuAQGBDH86LSuqC90oxQ1M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=etsalapatis.com; spf=pass smtp.mailfrom=etsalapatis.com; dkim=pass (2048-bit key) header.d=etsalapatis-com.20230601.gappssmtp.com header.i=@etsalapatis-com.20230601.gappssmtp.com header.b=hXxl20Xa; arc=none smtp.client-ip=209.85.222.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=etsalapatis.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=etsalapatis.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=etsalapatis-com.20230601.gappssmtp.com header.i=@etsalapatis-com.20230601.gappssmtp.com header.b="hXxl20Xa" Received: by mail-qk1-f175.google.com with SMTP id af79cd13be357-8b5ccceb382so396458485a.1 for ; Mon, 15 Dec 2025 07:06:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=etsalapatis-com.20230601.gappssmtp.com; s=20230601; t=1765811205; x=1766416005; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=79+wzmXa71VTx6agEVBXAhqr4t3bPb9GBjmcnaSZdD4=; b=hXxl20XaeA8/PZNElqcKj0dNhaj4KRku2i2IPYW1xkuavBvF8UhwdEb3Emrarcc/Gq wCkzFwmCZy0RfwfcbGRmJn24O3gn8P3VfAZOpK4hQzISy2diTKQwb/rFt3BdnRfbkFEg 9otYZIYQFYzAGGssA6G9y/0hV7sPCSYXGUfx2eHfH915kXC7GTAEbXV19yy9spwUJSz3 GEVeA8kRXAJOF2GsqOh1JgSch4Xqvelje54v6GghKQ0PRKcuXHv8Q8TzLsZvr9UCLTF3 aR+mrWy2O+iqQUH3fMY+UyvPICBM9dfTWOHhc7AoDmqxA3ztNiu9ciY7QmIMbTXm+2YN ys+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765811205; x=1766416005; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=79+wzmXa71VTx6agEVBXAhqr4t3bPb9GBjmcnaSZdD4=; b=EYBAsmI/Rddbjawoz/29LDn7eZls0NxDoeXUpmzvcQfcQgI4I3/+BaCCbGEhmxcjrV yOQ9+2iSI+/nkUJQBQeY368N0t5OlE7+z2XNf77LEEFRGwKz/Cif+CbYNjlqMig0Nqcr f9WsU3wMUZ71Htd2wv7+Hndc9pL8P/HZYxW3N02RsQWfp1bPHFxePMqhPat3a8VdFtAh nYAJsTLPpDuwtSObe7eswR8mrBVKtZhaA/8cGCCM5zMBCCR6lju2BWUbiuvCIkHJyDyf Rq/RPl60mOLA58F3SwOlOLqr2cPzlAj+RzqL6ejtUwaNXClBwP4mxvdLm8wuE8AUQD1N K/7w== X-Forwarded-Encrypted: i=1; AJvYcCVJGKJJfXOVeaSDhbrzcOZXynNk1jg8Xz5qDZMQKus4NkVOJjZvRebuiK+KxlVerZ+LuxbWA071nEu990Q=@vger.kernel.org X-Gm-Message-State: AOJu0YwcC6t/oJb3wQmUMm9DX3cbptz3HOl2AkOuc/BgSh/rCOaiNxUS QJI6Vl7XFKN367YRWbwBXp30zQVSJMLGGudgpFMRxicfJqmyip+/pB7GRKJqntRQqSQ= X-Gm-Gg: AY/fxX4XuCgVUh1DkrE1X4198pLSvSHI4EkCFfA6FjnVhm3d2g3jL6xYsoUJjtrLwq/ oxrDmt2qCo4YQ89dG5l2iOgkIMFIqPSAl06tmHGOT5L2KX18VwQgcTj3Dn6jNjLi5mDZaDTrjqy pVgdNHOhkMc6xczNOlxRSD+9tGM5eBqWwYnO+UalGhW8Hy2n2eJNXV19L5SOl/KkTwA/eYByWw1 feue7B8GXfrPmhOXhOXUT2v6ho+hDfgoPykOzu3RpbyOlmFX77UBhL323V747+8YiYffJLDcKaQ uGgQU71/NtafkPHXKw0RFVCW3jrUWy73iD3+Y2xKmnhME4T0xO5iO50XRKK5B56P482CHXG3aoC X6RhDlGEA2oTx2Q45UvVvn8AaSQnGFBxJRVqggG1mHN1KTtdf2qjEKAHTCmZKveUL11adUONpxh 1sCduhFRkid/Y= X-Google-Smtp-Source: AGHT+IGbxYRqlHlBsLcHTx/J0KOfAKQ1jXoSnZf/7OIJzM1fXf3Ycfphh2QqPatWllCjKZJ4YyHFgQ== X-Received: by 2002:a05:620a:4015:b0:8b2:dccd:7315 with SMTP id af79cd13be357-8bb3a39e901mr1472596185a.88.1765811203619; Mon, 15 Dec 2025 07:06:43 -0800 (PST) Received: from localhost ([140.174.219.137]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8bab47f6f15sm1121603685a.0.2025.12.15.07.06.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Dec 2025 07:06:43 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 15 Dec 2025 10:06:41 -0500 Message-Id: Cc: , Subject: Re: [PATCH] sched_ext: Remove unused code in the do_pick_task_scx() From: "Emil Tsalapatis" To: "Emil Tsalapatis" , "Zqiang" , , , , X-Mailer: aerc 0.20.1 References: <20251215112940.23640-1-qiang.zhang@linux.dev> In-Reply-To: On Mon Dec 15, 2025 at 10:05 AM EST, Emil Tsalapatis wrote: > On Mon Dec 15, 2025 at 6:29 AM EST, Zqiang wrote: >> The kick_idle variable is no longer used, this commit therefore remove >> it and also remove associated code in the do_pick_task_scx(). >> >> Fixes: 4c95380701f5 ("sched/ext: Fold balance_scx() into pick_task_scx()= "), >> Signed-off-by: Zqiang > > The change seems reasonable, but why is there a fixes up? This is > followup cleanup, the original patch is perfectly fine. > Oh and of course tag aside: Reviewed-by: Emil Tsalapatis >> --- >> kernel/sched/ext.c | 8 ++------ >> 1 file changed, 2 insertions(+), 6 deletions(-) >> >> diff --git a/kernel/sched/ext.c b/kernel/sched/ext.c >> index 695503a2f7d1..94164f2dec6d 100644 >> --- a/kernel/sched/ext.c >> +++ b/kernel/sched/ext.c >> @@ -2446,7 +2446,7 @@ static struct task_struct * >> do_pick_task_scx(struct rq *rq, struct rq_flags *rf, bool force_scx) >> { >> struct task_struct *prev =3D rq->curr; >> - bool keep_prev, kick_idle =3D false; >> + bool keep_prev; >> struct task_struct *p; >> =20 >> /* see kick_cpus_irq_workfn() */ >> @@ -2488,12 +2488,8 @@ do_pick_task_scx(struct rq *rq, struct rq_flags *= rf, bool force_scx) >> refill_task_slice_dfl(rcu_dereference_sched(scx_root), p); >> } else { >> p =3D first_local_task(rq); >> - if (!p) { >> - if (kick_idle) >> - scx_kick_cpu(rcu_dereference_sched(scx_root), >> - cpu_of(rq), SCX_KICK_IDLE); >> + if (!p) >> return NULL; >> - } >> =20 >> if (unlikely(!p->scx.slice)) { >> struct scx_sched *sch =3D rcu_dereference_sched(scx_root);