From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f50.google.com (mail-qv1-f50.google.com [209.85.219.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6203339868 for ; Tue, 16 Dec 2025 15:19:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765898398; cv=none; b=sw1NNgsyr+fmnORNFXnHM9sriTug9BYceTJqufeGy3MBw+/60Yw3HR9/8gqdUHf0HAZ1IgTtEbjJrdgvmydRxzoYhYTcHte+ZODVsj7W+zSiUdaG5bCQIM8xISyStUDu56rdNWehL0IrjAuvQWQNs1yNA2f0qfifHMnmmRNHxSk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765898398; c=relaxed/simple; bh=kWN2MI6koeKtF8HsSKiv5FqBa6vC6RWlP5GfVuKDaD4=; h=Mime-Version:Content-Type:Date:Message-Id:To:Cc:Subject:From: References:In-Reply-To; b=tUx7cquo4R2fL3PdiXZG7aYoJa36K3kr2fDg2NvL9fl5vdlk9gSUnvKbQChtkQi49wvdsmvRCmfRbqDCyH6Uu9JqU/G3uLiz+HrZo7zECZVd74GI74g3SoGuXJYeZQyyNfzRJXnOQm666ke+oS7sXSXQyCZBmNhF7PAFax/OHL0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=etsalapatis.com; spf=pass smtp.mailfrom=etsalapatis.com; dkim=pass (2048-bit key) header.d=etsalapatis-com.20230601.gappssmtp.com header.i=@etsalapatis-com.20230601.gappssmtp.com header.b=ccmouJAC; arc=none smtp.client-ip=209.85.219.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=etsalapatis.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=etsalapatis.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=etsalapatis-com.20230601.gappssmtp.com header.i=@etsalapatis-com.20230601.gappssmtp.com header.b="ccmouJAC" Received: by mail-qv1-f50.google.com with SMTP id 6a1803df08f44-88a2f2e5445so31009876d6.1 for ; Tue, 16 Dec 2025 07:19:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=etsalapatis-com.20230601.gappssmtp.com; s=20230601; t=1765898394; x=1766503194; darn=vger.kernel.org; h=in-reply-to:references:from:subject:cc:to:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=de3zjk2T60rUddmors6D20z+BqVsAlEXYVeufQpJ9X0=; b=ccmouJACfw30pzMKcpDIFR1alLpC80JQXPSQCMH1bwXUcUZ16JH1Qe11hxl+E5vnLS 70le5UEXrgwpb+HHMyncCq6ce2xv9adIPwIccvJ4zBWjL25uRfSx5gvNTH3WU4TkZ24i Udqi4+Rs6ra9UpPvHoEf0KcVqldy14LCRhKlZ8OR9rigv3PrvClp3SAKfXurJwJijJze RCDXjWDEEAI0XBFJolf9dCD5t7xNMs6gNrDKXFKDOWTL40nIAq0sYDFMgOC3XwoDA9AW l9SyJjJ6Q0Efy9DrGbbYgQACX40Cw30ugXtf/Zw6pg+ALgLQmHmQ6crdeJq6PluzD4+O V8Wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765898394; x=1766503194; h=in-reply-to:references:from:subject:cc:to:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=de3zjk2T60rUddmors6D20z+BqVsAlEXYVeufQpJ9X0=; b=GZyNHoC/P+Sus45XlkzSzlAY3GajXoRSMJZZysnmorqCB5zgChBUIHIQ85AAetXIWK aKcxSg8IHXccKsp8RdsoLD162nGHA1Qr3LzBZbCb0WUWraQbuu8Y/VN1ZgC7+QFFWxpd hyJjeJ+HQnSu+SYjDQaWGIFdUklE/zyWl65evUuJpa1hMJAFFZbEAEWdbcdpw8QFXqc4 7Dzu5GerpCbzP70Av4vh+mW8nNrIrtoKBFe4GO5w/cOmb9DtLwddT+eso9bcrTM103Ae Kt7a9ABTh9/SCUIPK/za48I6ARb8X0LZnJaJqJhhBTc+FDDKJU5rsZFZ5EZIWprf4zQQ qb8w== X-Forwarded-Encrypted: i=1; AJvYcCXb0VREv5XHjCLLPZ/NZ4s3lOgbjtchnScRLZnjVy98GxOSWhV1GLWhxC806e/EI4t3b0PzwGRQTF1aMM8=@vger.kernel.org X-Gm-Message-State: AOJu0YwJj8ExVrZjSnl8oLboxaE93p14PiN99izb/HjjOYqtOCVpb4rs Z5+WESC3zDeIMVjuSiQ+f3bddlw+edfL/lSWaUoLIZDB8HdxpSRTCOnoKy3Abj4H0co= X-Gm-Gg: AY/fxX4gIuwaSDEzmKzGTjrw0HbMtyW1y5WjXIoOn9FnFWH7X1B4omcDSyKvaJDMiUU er7OnXTHgLZGZGipfNBlTOIauXwAL65/2NW4D8Yqw1jZ7WRO+MuIzfmRqW6qGPBmc8VRHV+Yf7M ukYC8DnrOBm9N+PV/5XlCgVkywc5rmNSnT5NhckOmxorAV75osdKNy7gyuN9aSCrAd+/U08ApoZ Zh6QPeKZhb/YWX3BW3rB9KEvqlqSWYX2Yj4cRxtqNemOEnIXzlJcBVyDXmMZLXF6OV5aIjd6Txu SfvfkrZBzG0UigMPnhFPxUFCFfCYv7tDCg03AqKt3GPJB4DBluzX+QVzADlKRVnXrejy6UetLdv P2Qw8I4nVx6+UbITNXq6DhUpZNB/lnD92ePLZrR3623DfxnrJkvWvwGjuGwHgwRJhxa/dvRzyVJ Lv2TGxFjm+beA= X-Google-Smtp-Source: AGHT+IEgQ4A3mnKdkt35J/Vxw0tq/W1jv3GLGeI7wstC8gZ0t+wa8jAv3mHNJ47OyvRfcAaLRhcXvA== X-Received: by 2002:ad4:5fc7:0:b0:882:4632:cf7e with SMTP id 6a1803df08f44-8887dfe38c2mr215260436d6.12.1765898394528; Tue, 16 Dec 2025 07:19:54 -0800 (PST) Received: from localhost ([140.174.219.137]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8be31c75e91sm204006285a.47.2025.12.16.07.19.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Dec 2025 07:19:54 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 16 Dec 2025 10:19:52 -0500 Message-Id: To: "Liang Jie" , "Tejun Heo" , "David Vernet" , "Andrea Righi" , "Changwoo Min" , "Ingo Molnar" , "Peter Zijlstra" , "Juri Lelli" , "Vincent Guittot" , "Dietmar Eggemann" , "Steven Rostedt" , "Ben Segall" , "Mel Gorman" , "Valentin Schneider" , "open list:SCHEDULER - SCHED_EXT" , "open list:SCHEDULER" Cc: , "kernel test robot" , "Dan Carpenter" Subject: Re: [PATCH] sched_ext: fix uninitialized ret on alloc_percpu() failure From: "Emil Tsalapatis" X-Mailer: aerc 0.20.1 References: <20251216093955.2928453-1-buaajxlj@163.com> In-Reply-To: <20251216093955.2928453-1-buaajxlj@163.com> On Tue Dec 16, 2025 at 4:39 AM EST, Liang Jie wrote: > From: Liang Jie > > Smatch reported: > > kernel/sched/ext.c:5332 scx_alloc_and_add_sched() warn: passing zero to= 'ERR_PTR' > > In scx_alloc_and_add_sched(), the alloc_percpu() failure path jumps to > err_free_gdsqs without initializing @ret. That can lead to returning > ERR_PTR(0), which violates the ERR_PTR() convention and confuses > callers. > > Set @ret to -ENOMEM before jumping to the error path when > alloc_percpu() fails. > > Reported-by: kernel test robot > Closes: https://lore.kernel.org/r/202512141601.yAXDAeA9-lkp@intel.com/ > Reported-by: Dan Carpenter > Fixes: c201ea1578d3 ("sched_ext: Move event_stats_cpu into scx_sched") > Signed-off-by: Liang Jie > --- Reviewed-by: Emil Tsalapatis > kernel/sched/ext.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/kernel/sched/ext.c b/kernel/sched/ext.c > index 05f5a49e9649..8ea243b04dc9 100644 > --- a/kernel/sched/ext.c > +++ b/kernel/sched/ext.c > @@ -4761,8 +4761,10 @@ static struct scx_sched *scx_alloc_and_add_sched(s= truct sched_ext_ops *ops) > } > =20 > sch->pcpu =3D alloc_percpu(struct scx_sched_pcpu); > - if (!sch->pcpu) > + if (!sch->pcpu) { > + ret =3D -ENOMEM; > goto err_free_gdsqs; > + } > =20 > sch->helper =3D kthread_run_worker(0, "sched_ext_helper"); > if (IS_ERR(sch->helper)) {