From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D554C27FD71 for ; Mon, 22 Dec 2025 04:25:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.68 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766377517; cv=none; b=ZagLJNXwe0VbJdcReLU+rSSg2ohkf7AfATs8Z2PCRWYzvV1zV2onUo/lTNnJkgsZzJyEvobaSqKWq9w9bc9w75JJLO907XofGLWiaD8WVnGUE//oEzvBG5WgNaf1zbKsW569qlfmbhRHFBaXAko+Atsbt0g+awX/mX8QajsBKOw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766377517; c=relaxed/simple; bh=zx+0zrUpNplPzxs7nAKriwd+5omooaKME7WghPYhMn8=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=X7U7goYRdL1+S1fSQkuvHRUh1rwK/ekL0YZicAKq8jwDk0SopEi8W7hVSyMdI0V4h9R/rWiRTnajSeZYdUSKAnVqvhxhIuaoYO5uU6FlpCYEKOqqAeAcxOt1wvETj9/sPnbdrmF4CQgTOu7NA7eKLPnPqPCCYoP19tpkAc/zTo4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=n4pxWTDw; arc=none smtp.client-ip=209.85.128.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="n4pxWTDw" Received: by mail-wm1-f68.google.com with SMTP id 5b1f17b1804b1-477b198f4bcso22495065e9.3 for ; Sun, 21 Dec 2025 20:25:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766377514; x=1766982314; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=zx+0zrUpNplPzxs7nAKriwd+5omooaKME7WghPYhMn8=; b=n4pxWTDwr3YFj+V7OStUlZBkWUATtB2BS874+3yKeoORGhQhhdjWGa+OfOAtX9E6ct kxLFr2VuLA8cWkD0oDjCTwkzTkYP09Dx5OaaDCKc8inKIutpa6IrHLa/oT0gtu353zVj T5zK5E/v/nIcSM/5jtu5NqZlQgXMQBmxmollcD4VrHKBPH7GkCtSRS/YfVwEBOCTM9tB dlSDQiOw2yzaHp2jpOQ9tckTgEfEwlExnYuZTleP1tLCiVsob0KWNAdQlNnARt8ZcUwl U122PFq4L2fSb01w57PhM1CZ3UwSQ5UwvWK8nReL7nXun4ky1+bYnUAMdfcbDZfCpxZo stBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766377514; x=1766982314; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=zx+0zrUpNplPzxs7nAKriwd+5omooaKME7WghPYhMn8=; b=S2LR0SR3VKBjX3tyF6IRnCg6HO6yMFJhYcOILnpROUbAqPTmqg0Z1K0a/RiZPaOORd tMkTS9o0gZTmsOP7lW9zSJ0k8iiktUzsp4w+N7tw3vONyPzEtt1AhQFQBJdWw5uc9zcE h0plot+AMQIRO0VC4b4yvo1Ifyc0+V0Fq9c41QHHmZoZpJXNym8ycERFENeUDJsFOwTs FxzMu/F7uYdrWACzI5P98eaLONZKjoauu4pESnxkRd+rAu0F5PfZzAumMZyUuSluxc4C vZJZyDLN8iBqVimK88F2avVzWqKl2b/h4u4bIeg3n5v7vpdCSXEvuS4l2aJkYGnIRnmN rhWw== X-Forwarded-Encrypted: i=1; AJvYcCWUy0jfj+6IMOhC/Z07gWChwIOfcUpl7VwUwgcTVUZN/xfxhsjPUIWafBjiZAPi5M2JQDoPG4uIcOTtljA=@vger.kernel.org X-Gm-Message-State: AOJu0Yweo/+ztxQc2x2kmTBLQPm9oBQA3jXh1C00sbPIREnmVr0iKVuC RVvYkNOl07LqqzQ+13QxgZppL0AxwJ1pR91RTc2mv+Bp4H/IWWGamVvhx0DWCHVHr1Y= X-Gm-Gg: AY/fxX4ArbB0OVm50nHlXnkSLoEpUCOAAGit3oYVHUkIUJP6LC943nH9PuNwzoJ4xbu 7Cqu0b8FByg7kkQ5cD9aiW6c6YRArYjJWCXGJurhzsh0cSUXQKFd+cgz77uwmAu56vHn+nHM9Tb XUYnR+/DOAwEy8XZ5YnhgyQNqs30yGQGwOhKtMIhh7bGjcbJMek5m0QqkWIEyO2aODVv/A9uU+/ L3lRFagsIQPULL6aPkQgYFeCGW1huYfbiDelxaNv/yAPrtGpI7vAPH/PxGWx4J0OPPVZ8rafp6d 6vEr/rTtXYfDpBkXWqiJZ9ChafR3s1LYr2jn3IlRFcsb52uT0LJu3VAUMZkLJSugNYBLksFz5XG zTActUGhED1/+3LJpfDaIeKNQS1xRDwQzFbOf7yBJMnEtKaQmReFsz8ZVL5d/hus7hROqgSgJ5k eZIyDD9hDIZUT/4YTh X-Google-Smtp-Source: AGHT+IEFPw6BHurC+yxPzjyCPrPhsx+XJDFA6UxzACnVNeSrnr8kjsZNwCOidsPpjrowChadwhrkMQ== X-Received: by 2002:a05:600c:4595:b0:477:a1a2:d829 with SMTP id 5b1f17b1804b1-47d1953ead3mr95117845e9.13.1766377514186; Sun, 21 Dec 2025 20:25:14 -0800 (PST) Received: from localhost ([2a02:c7c:5e34:8000:7db7:794c:2c30:e530]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d193cba81sm168582455e9.10.2025.12.21.20.25.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 21 Dec 2025 20:25:13 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 22 Dec 2025 04:25:12 +0000 Message-Id: Cc: , , , , , Subject: Re: [PATCH v2 0/2] ASoC: qcom: q6dsp-lpass-ports: Expand sampling rate and PCM format constraints From: "Alexey Klimov" To: "Srinivas Kandagatla" , "Ravi Hothi" , "Srinivas Kandagatla" , "Liam Girdwood" , "Mark Brown" , "Jaroslav Kysela" , "Takashi Iwai" X-Mailer: aerc 0.20.0 References: <20251210065157.2775514-1-ravi.hothi@oss.qualcomm.com> <370a9d69-1706-438a-bb36-01a22e5cf540@oss.qualcomm.com> In-Reply-To: On Wed Dec 17, 2025 at 12:56 PM GMT, Srinivas Kandagatla wrote: > > > On 12/17/25 11:38 AM, Alexey Klimov wrote: >> On Mon Dec 15, 2025 at 7:29 AM GMT, Ravi Hothi wrote: >>> >>> >>> On 12/10/2025 7:26 PM, Alexey Klimov wrote: >>>> On Wed Dec 10, 2025 at 6:51 AM GMT, Ravi Hothi wrote: >>>>> This patch series expands the existing constraints in >>>>> the q6dsp-lpass-ports driver to improve compatibility >>>>> and flexibility for audio stream configurations. >>>>> >>>>> The first patch extends the supported sampling rates to cover a wider >>>>> range, from 8000 Hz to 192000 Hz, ensuring better compatibility with >>>>> diverse audio hardware and allowing more flexible audio stream setups= . >>>>> >>>>> The second patch adds support for the 32-bit PCM format >>>>> (SNDRV_PCM_FMTBIT_S32_LE) alongside the existing 16-bit >>>>> and 24-bit formats, enabling handling of high-resolution >>>>> audio streams and improving audio quality for supported hardware. >>>> >>>> Is q6dsp-lpass-ports involved in compress offloaded playback on >>>> existing devices? If yes, then how is it gonna play with >>>> explicitly setting format/sampling rate to s16le/48k in sndcards drive= rs? > > be_hw_params_fixup callback in machine drivers can select any format > that fits the usecase. currently this is hardcoded for s16le samples and > 48K rate, but its not limited to this. This patch is expanding the > allowed range in the dais so that machine drivers should be able to > select other options, ex: for HDMI its better to be at S24LE or S32LE. Yes. Exactly. So, should we add kcontrols to machine driver to handle these usecases like selecting s24le instead of s16le? Or what's the plan? >>> Support for s16le/48k is already available; these patch will expand the= =20 >>> existing constraint so that customers can use a wider range. >>=20 >> Unfortunately, you didn't answer any of my questions or answered >> a different one. >>=20 >> Perhaps the main one: is q6dsp-lpass-ports involved in compress offloade= d >> playback on existing devices? > > lpass-ports are the Backend DAI ports, So yes, they will be involved in > all the usecases that deal with handling sinks or sources irrespective > of pcm or compressed content. Thanks, Alexey