From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4FF41EEA55 for ; Sat, 27 Dec 2025 08:55:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766825747; cv=none; b=AiTrbNoZyxzfqWmIVFWpCsIZajVcxWEoLf7d5gZ7Wa6mDNCQhVUBqP9MAKawIFq5Q7SCE70Emz+17IoMUvtZ+RnitN/MZ+nUtbHV2YplrHU7+SQ3jOMe0Qjst1TFMxLkUwu7F2Mlgs5bcbeJ9k5bWUvzMTERVMA6+giRkWvRnss= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766825747; c=relaxed/simple; bh=7cfeEWuv8uK+fyIOJzcnge3KyxIGEGN/rqeXvKxcwQY=; h=Mime-Version:Content-Type:Date:Message-Id:From:Subject:Cc:To: References:In-Reply-To; b=XN8VyPXgnIxdd5E+nPJfNJogwhvMpPm/QuYxbMAKJw1Sz4v6ooeSlck4zz3xeSOUhK76+UX8VTN6pm6KYaP2xHtb8bbskBn/nXZzpAje0/DKlYSLBVQYBCE8fmId+SecPguajfZpjYqkBp90MArYyafEWwFtS+X47PSKdthYrkY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XKEkjg2p; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XKEkjg2p" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-34c3cb504efso8957433a91.2 for ; Sat, 27 Dec 2025 00:55:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766825745; x=1767430545; darn=vger.kernel.org; h=in-reply-to:references:to:cc:subject:from:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=IMTRZi0Y5Cq2uagABxlNiFBOS1A/ftQM7so1PS5Zrb0=; b=XKEkjg2pgaUS+n46C33EXXSsj17kG4J8UcDyt7wJglxXPW7l8Et2oCfdFX5RJjqjBM qlhcKvGozTd/cXW8iMuGui1xvoNwAQgR4mQWdubEGJzgKuqkCQVVmcaAltoMZJewevbS yuOxveiW91vL+NyAO2L8QFsLmtoVSEnke3nCZnsTP8wzg7uiFrkPTqLUJzulyY2cxIyT 17RvpwtUf6Zn3m7orwBwiXu6mx8LWDlt/1YPSAWmYli9vKv9v9ZWgzhmd13Of3y+IaO+ c6g3hrxf2M9mHARmBq5EE3mR0ZOiAgFJe1kaQgCPKj+v3Pue7WtCfuJqqouNcUxEAJut g0OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766825745; x=1767430545; h=in-reply-to:references:to:cc:subject:from:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=IMTRZi0Y5Cq2uagABxlNiFBOS1A/ftQM7so1PS5Zrb0=; b=UYXBVDjeAb5cS0oxZ1MMp1TQpjUYXlwyxaha0H1Jp9s/KdGzS4fxfdJiBJCfOOacwt 2ZyAG6alxLB9uiEhwv3yin9/V6DGFo5KTRP8N5KHHW9pI0uN9f4g5UKTbP431m9q5xn0 6GwUklXB6UoFazPD4F+IT0F3lkTR1jwBVq4sd0SN/8cCPg6d5m5+RExNfyGSafsJbp8s Czf7okU0c7pcqx7oH0SAq6SFHIotRqGzfenTu848rdsCCyyZwpdMCnbmcGwkAtZfqixk uWqRMyGYMNCEy0E/bQ7Cm7jFMtuGz4vZaItW5KAvM9C0RswxPKkCIvYIsSw/hbd1HEvv 92RQ== X-Forwarded-Encrypted: i=1; AJvYcCVGDHXkNEPc+aXLaWhZkfqX2caYD9mzsMDXUorgjuVL13bG8MS1vsqNwH+ulikDZiuHgvANsU5uLESIwl8=@vger.kernel.org X-Gm-Message-State: AOJu0YzjdpjBkN5l0yM9pB2Grhhno5d6PhhDL894v7dvtjQ6kirt1rSh cvt77+Bk3+ZCwNA0C7h4LVHFcOuCIBNkUIXBgtignw89qwkRMNrjDBVi X-Gm-Gg: AY/fxX72wX5Jiqjv2/v7fIclRzUjh23Ja92RZiS+PyzcOMicua0zrfxzKvZMxH6lyuy 5IKcOC9AMfWWetnxPwPalrNUK4L6DlmoGPG0L8ney/fIzmuBO4g9I8xlXwDUrxClyFZwtjmhZYR zcP3ptTdGJ8LjylEoKk81fzWph9kI4BbPwGaqgoZK4P0ZCTRjzJEiRmr7s0shRTCSaKyAHodsi5 QzvfBRmxRUli/+NBAk6jnhq0AvFBGwoqlcqn2OJx8K9uEF653yxpqM7dCSgE3DT1iBLVd9dxBGK 5hmceKlqR3Ac3QXDI90DvtdeCTVf7vYhLx3G87QoWgnhMGX0t9fat5ewUaSaw++abtS6WuAGcMK DMBD5r2L9K0MNCUeb1yvh8OQAdccdZZHmk8jCQZD+tkwG2BvUHNCOI0IdfPFGxhXO5oW4Qhr0rF Q16H5Ro4u72L8tMrg= X-Google-Smtp-Source: AGHT+IExxrbtPED9ni4GJa40wGb0R3hBItrv0Ks+I02DdqHnMckn6gYR3u8VGUXE6TLPlay0EBHTDg== X-Received: by 2002:a05:6300:210b:b0:34f:ec81:bc3a with SMTP id adf61e73a8af0-376a8bc2ef7mr25671076637.28.1766825744954; Sat, 27 Dec 2025 00:55:44 -0800 (PST) Received: from localhost ([61.82.116.93]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-34e70d4f7e2sm25192194a91.2.2025.12.27.00.55.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 27 Dec 2025 00:55:44 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Sat, 27 Dec 2025 17:55:40 +0900 Message-Id: From: "Yeounsu Moon" Subject: Re: [PATCH net] net: dlink: mask rx_coalesce/rx_timeout before writing RxDMAIntCtrl Cc: "Andrew Lunn" , "David S. Miller" , "Eric Dumazet" , "Jakub Kicinski" , "Paolo Abeni" , , To: "Andrew Lunn" , "Yeounsu Moon" X-Mailer: aerc 0.21.0 References: <20251223001006.17285-1-yyyynoom@gmail.com> In-Reply-To: Hi Andrew, Sorry for the late reply. I recently started a new job and have been busy. On Tue Dec 23, 2025 at 6:43 PM KST, Andrew Lunn wrote: > > It would be better to do range checks in rio_probe1() and call > netdev_err() and return -EINVAL? > > Anybody trying to use very large values then gets an error message > rather than it working, but not as expected. > I was planning to add the range checks in rio_probe1() in the next merge window to keep this patch small, but I agree it's better to include them no= w. I'll send a v2 with the checks added. Thanks for the review. Yeounsu Moon