From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-180.mta1.migadu.com (out-180.mta1.migadu.com [95.215.58.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 675F51397 for ; Wed, 31 Dec 2025 13:37:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767188239; cv=none; b=kvg1D6V0C8ukMz5TWnhKE6UOumizRQ9Dn2kqoWJc95IlBA2tuGQM9eQ2q5u7Gf+0/v7NnTBMxemYU2d/k7IXo0ppGoqozfgsrtygJF2wmwF2c7BXexUOA4mw/DAdQZPGpwb4paebaQ3NwNyBVi5840SVZW/AxyZgxXz6i+pynec= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767188239; c=relaxed/simple; bh=zQkbLJ9+ChyawRukk6req34uy0Zchq0gALUZsor6F2s=; h=Mime-Version:Content-Type:Date:Message-Id:To:Cc:Subject:From: References:In-Reply-To; b=FNMIwwqZuXpIOz7C2ryaY5tTJR4Q9VpeK6/Auyy8Qxp8e0z6j03K/E+4rCvnQ5CXaA4qN43rqjFYEtVkNP1xzCzGCstLmKCcGO2CA+TbIUU8kCCxiJgg3KUU/4bjJyVqROAtPSKM42mzfEyzoeJqySxw67Yt5UGFVk1VlkQsmUU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=cknow-tech.com; spf=pass smtp.mailfrom=cknow-tech.com; dkim=pass (2048-bit key) header.d=cknow-tech.com header.i=@cknow-tech.com header.b=Sj5RDxgV; arc=none smtp.client-ip=95.215.58.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=cknow-tech.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cknow-tech.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cknow-tech.com header.i=@cknow-tech.com header.b="Sj5RDxgV" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cknow-tech.com; s=key1; t=1767188231; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I/DC5HGhzFn6eB9/q1rg3HbClxsdFAQDVLotSyZqTjw=; b=Sj5RDxgVWnEDDcM9EBb0Gi/q7VYGbi+rT2nD7JGMjgJ9zW6p+kqq35EyeX8fYYA+MiaSTx SFAUZgiqGHSuQdjoO9eQ4pFhtvfqexwiCl3hyr7+aTG5TESwqfUQJu2bJvBt2xdDNCj7Ra tp2ze9+u8+5iOGbICApuMCaE7hNkXkMHaHHd6O0rjVbR8Mm46ylb0jP+mqjWP4V3RW9hPs PsC4gzIuHxtQfqZBIVL39vUFG518ZS4IHyPnWiU64Pwr8kjNCwpuLkZLYXZrbzJW/RD9D9 Exsgj+f0W+tOYZStonu+Gj0ObO3jIsoeNcarKWjuCqxKwJAtwDj5Vb3XnQGP1w== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 31 Dec 2025 14:36:48 +0100 Message-Id: To: "Joseph Chen" , , , , , , Cc: , Subject: Re: [PATCH v1 1/2] dt-bindings: mfd: Add rk801 binding X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Diederik de Haas" References: <20251231030951.818-1-chenjh@rock-chips.com> <20251231030951.818-2-chenjh@rock-chips.com> In-Reply-To: <20251231030951.818-2-chenjh@rock-chips.com> X-Migadu-Flow: FLOW_OUT On Wed Dec 31, 2025 at 4:09 AM CET, Joseph Chen wrote: > Add DT binding document for Rockchip's RK801 PMIC > > Signed-off-by: Joseph Chen > --- > .../bindings/mfd/rockchip,rk801.yaml | 199 ++++++++++++++++++ > 1 file changed, 199 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/rockchip,rk801.= yaml > > diff --git a/Documentation/devicetree/bindings/mfd/rockchip,rk801.yaml b/= Documentation/devicetree/bindings/mfd/rockchip,rk801.yaml > new file mode 100644 > index 00000000000..d591125dfe8 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/rockchip,rk801.yaml > @@ -0,0 +1,199 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mfd/rockchip,rk801.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: RK801 Power Management Integrated Circuit > + > +maintainers: > + - Joseph Chen > + > +description: | > + Rockchip RK801 series PMIC. This device consists of an i2c controlled = MFD > + that includes multiple switchable regulators. > + > +properties: > + compatible: > + enum: > + - rockchip,rk801 > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + rockchip,system-power-controller: > + type: boolean > + description: > + Telling whether or not this PMIC is controlling the system power. > + > + system-power-controller: true Why add 'rockchip,system-power-controller' while also adding 'system-power-controller'? Property 'rockchip,system-power-controller' was deprecated in commit 961748bb1555 ("dt-bindings: mfd: rk8xx: Deprecate rockchip,system-power-con= troller") And because of that I submitted this patch/commit: b99ac7e2a1cc ("arm64: dts: rockchip: Drop rockchip prefix of s-p-c PMIC pro= p from rk356x") to replace the deprecated variant with the non-deprecated one. Cheers, Diederik > + > + wakeup-source: > + type: boolean > + description: > + Device can be used as a wakeup source. > + > + vcc1-supply: > + description: > + The input supply for DCDC_REG1. > + > + vcc2-supply: > + description: > + The input supply for DCDC_REG2. > + > + vcc3-supply: > + description: > + The input supply for DCDC_REG3. > + > + vcc4-supply: > + description: > + The input supply for DCDC_REG4. > + > + vcc5-supply: > + description: > + The input supply for LDO_REG1. > + > + vcc6-supply: > + description: > + The input supply for LDO_REG2. > + > + vcc7-supply: > + description: > + The input supply for SWITCH_REG. > + > + regulators: > + type: object > + patternProperties: > + "^(DCDC_REG[1-4]|LDO_REG[1-2]|SWITCH_REG)$": > + type: object > + $ref: /schemas/regulator/regulator.yaml# > + unevaluatedProperties: false > + unevaluatedProperties: false > + > +required: > + - compatible > + - reg > + - interrupts > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + #include > + i2c { > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + > + rk801: rk801@27 { > + compatible =3D "rockchip,rk801"; > + reg =3D <0x27>; > + interrupt-parent =3D <&gpio0>; > + interrupts =3D ; > + pwrctrl-gpios =3D <&gpio0 RK_PC1 GPIO_ACTIVE_HIGH>; > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&pmic_int_l>; > + rockchip,system-power-controller; > + wakeup-source; > + > + vcc1-supply =3D <&vcc12v_dcin>; > + vcc2-supply =3D <&vcc12v_dcin>; > + vcc3-supply =3D <&vcc5v0_sys>; > + vcc4-supply =3D <&vcc5v0_sys>; > + vcc5-supply =3D <&vcc3v3_sys>; > + vcc6-supply =3D <&vcc3v3_sys>; > + vcc7-supply =3D <&vcc3v3_sys>; > + > + regulators { > + vdd_cpu: DCDC_REG1 { > + regulator-name =3D "vdd_cpu"; > + regulator-min-microvolt =3D <500000>; > + regulator-max-microvolt =3D <1500000>; > + regulator-initial-mode =3D <0x1>; > + regulator-boot-on; > + regulator-always-on; > + regulator-state-mem { > + regulator-mode =3D <0x2>; > + regulator-off-in-suspend; > + regulator-suspend-microvolt =3D <950000>; > + }; > + }; > + > + vcc3v3_sys: DCDC_REG2 { > + regulator-name =3D "vcc3v3_sys"; > + regulator-min-microvolt =3D <3300000>; > + regulator-max-microvolt =3D <3300000>; > + regulator-initial-mode =3D <0x1>; > + regulator-boot-on; > + regulator-always-on; > + regulator-state-mem { > + regulator-mode =3D <0x2>; > + regulator-on-in-suspend; > + regulator-suspend-microvolt =3D <3300000>; > + }; > + }; > + > + vcc_ddr: DCDC_REG3 { > + regulator-name =3D "vcc_ddr"; > + regulator-boot-on; > + regulator-always-on; > + regulator-state-mem { > + regulator-mode =3D <0x2>; > + regulator-on-in-suspend; > + }; > + }; > + > + vdd_logic: DCDC_REG4 { > + regulator-name =3D "vdd_logic"; > + regulator-min-microvolt =3D <500000>; > + regulator-max-microvolt =3D <1500000>; > + regulator-initial-mode =3D <0x1>; > + regulator-boot-on; > + regulator-always-on; > + regulator-state-mem { > + regulator-mode =3D <0x2>; > + regulator-off-in-suspend; > + regulator-suspend-microvolt =3D <900000>; > + }; > + }; > + > + vdd0v9_sys: LDO_REG1 { > + regulator-name =3D "vdd0v9_sys"; > + regulator-min-microvolt =3D <900000>; > + regulator-max-microvolt =3D <900000>; > + regulator-boot-on; > + regulator-always-on; > + regulator-state-mem { > + regulator-off-in-suspend; > + regulator-suspend-microvolt =3D <900000>; > + }; > + }; > + > + vcc_1v8: LDO_REG2 { > + regulator-name =3D "vcc_1v8"; > + regulator-min-microvolt =3D <1800000>; > + regulator-max-microvolt =3D <1800000>; > + regulator-boot-on; > + regulator-always-on; > + regulator-state-mem { > + regulator-off-in-suspend; > + regulator-suspend-microvolt =3D <1800000>; > + }; > + }; > + > + vcc_3v3: SWITCH_REG { > + regulator-name =3D "vcc_3v3"; > + regulator-boot-on; > + regulator-always-on; > + regulator-state-mem { > + regulator-off-in-suspend; > + regulator-suspend-microvolt =3D <3300000>; > + }; > + }; > + }; > + }; > + };