From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECA3634252C for ; Mon, 5 Jan 2026 11:20:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.171.202.116 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767612044; cv=none; b=eXebzWHoGsaegs44Fqo8tsSmp2f3IY0DZDVJNcxaY1UMypn8+DHi06jvS1kiM2rIBWgjcmN3wwUHGeWmTbcYcKk4QZF/OGbDKJAUTowYBUqVzM2mn0wWTD/+vW0QM9IkaG8nAcJrctKXsXC0Mn1j9IkHPhmYyBQ4OS0IPNXRjFw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767612044; c=relaxed/simple; bh=xas6ibraHS+4BjCQ6d0c56e4JsDJrT30DIcEVJwysKg=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:Cc:To:From: References:In-Reply-To; b=bQset1OLTp/hUa77yXPQcWEeSqznMRDpRG9TJ/x9GIkIMacZTo2PSTCyjbUOx4rMK8nEDvNgVwNJKTlOdnVUjDUWW65aaywnBgbJj3LnRkQpu/JUDGjvPyEqc/lSfCIlcfvNFB78jFwYIevjBRjV1jmfi9ybICvmE6YxTN66Xm4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=aXC4ZQt/; arc=none smtp.client-ip=185.171.202.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="aXC4ZQt/" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id 28A84C1E482; Mon, 5 Jan 2026 11:20:13 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id EDAFE60726; Mon, 5 Jan 2026 11:20:38 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 0F7AD103C84F6; Mon, 5 Jan 2026 12:20:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1767612038; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=xHfSjWqxfxYko+txDt328icuQQjBRyghGWUrAKeMZGE=; b=aXC4ZQt/tBGsEBvst0PIkyYqOv3hYJstIf/OF8pstvJqyA0Y4aula3YQ0sHilDNmEf/ipm /IEBWpQ/gs3V/5bs88HH9Lmsrz/tWplLbOfp8r4GggLJ3/XL18wIi+xSkr9XuFsK6nXYgG 762gW/GIPU+fBfEzSZHbhq/NALxbI6iYmZz7bBV3EFfn1oQSL49OLDuX6J61SZOyHFzBGW cFnOZclhfSbTm0/d0qvxDXzHlTxXoaQ1fH+lRTmN/tZcur9Cy9URVtPFvQyWLyT2muTNqd xetmz2PV/PctmCclnzH+p9q4hennbiLcYDIa34tL1Ro6ousggUuYLSGa6u3fGA== Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 05 Jan 2026 12:20:30 +0100 Message-Id: Subject: Re: [PATCH v3] drm/bridge: synopsys: dw-dp: fix error paths of dw_dp_bind Cc: , "Andrzej Hajda" , "Neil Armstrong" , "Robert Foss" , "Laurent Pinchart" , "Jonas Karlman" , "Jernej Skrabec" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "David Airlie" , "Simona Vetter" , "Dmitry Baryshkov" , , To: "Osama Abdelkader" , "Andy Yan" From: "Luca Ceresoli" X-Mailer: aerc 0.20.1 References: <20260102155553.13243-1-osama.abdelkader@gmail.com> In-Reply-To: <20260102155553.13243-1-osama.abdelkader@gmail.com> X-Last-TLS-Session-Version: TLSv1.3 Hello Osama, On Fri Jan 2, 2026 at 4:55 PM CET, Osama Abdelkader wrote: > Fix several issues in dw_dp_bind() error handling: > > 1. Missing return after drm_bridge_attach() failure - the function > continued execution instead of returning an error. > > 2. Resource leak: drm_dp_aux_register() is not a devm function, so > drm_dp_aux_unregister() must be called on all error paths after > aux registration succeeds. This affects errors from: > - drm_bridge_attach() > - phy_init() > - devm_add_action_or_reset() > - platform_get_irq() > - devm_request_threaded_irq() > > 3. Bug fix: platform_get_irq() returns the IRQ number or a negative > error code, but the error path was returning ERR_PTR(ret) instead > of ERR_PTR(dp->irq). > > Use a goto label for cleanup to ensure consistent error handling. > > Fixes: 86eecc3a9c2e ("drm/bridge: synopsys: Add DW DPTX Controller suppor= t library") > Cc: stable@vger.kernel.org > > Signed-off-by: Osama Abdelkader Thank you for the improvements! Reviewed-by: Luca Ceresoli Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com