Re: [PATCH] rust: macros: support `#[cfg]` properly in `#[vtable]` macro.

["Gary Guo" <gary@garyguo.net>]

On Tue Jan 13, 2026 at 1:39 PM GMT, Tamir Duberstein wrote:
> On Tue, Jan 13, 2026 at 8:11 AM Gary Guo <gary@kernel.org> wrote:
>>
>> From: Gary Guo <gary@garyguo.net>
>>
>> Currently, we generate `HAS_` constants as long as the definition exists in
>> the source, regardless if it is cfg-ed out or not.
>>
>> Currently, uses of `#[cfg]` present in both trait and impl, so it is not a
>> problem; however if only the impl side uses `#[cfg]` then `HAS_` constants
>> will incorrectly be true while it shouldnt't.
>>
>> With `syn` support, we can now implement `#[cfg]` handling properly by
>> propagating the `#[cfg]` attributes to the constants.
>>
>> Signed-off-by: Gary Guo <gary@garyguo.net>
>> ---
>>  rust/macros/helpers.rs |  6 ++++++
>>  rust/macros/vtable.rs  | 13 ++++---------
>>  2 files changed, 10 insertions(+), 9 deletions(-)
>>
>> diff --git a/rust/macros/helpers.rs b/rust/macros/helpers.rs
>> index adfa60d8f42d8..11117b4c95d25 100644
>> --- a/rust/macros/helpers.rs
>> +++ b/rust/macros/helpers.rs
>> @@ -7,6 +7,7 @@
>>          Parse,
>>          ParseStream, //
>>      },
>> +    Attribute,
>>      Error,
>>      LitStr,
>>      Result, //
>> @@ -53,3 +54,8 @@ pub(crate) fn file() -> String {
>>          proc_macro::Span::call_site().file()
>>      }
>>  }
>> +
>> +/// Obtain all `#[cfg]` attributes.
>> +pub(crate) fn gather_cfg_attrs(attr: &[Attribute]) -> impl Iterator<Item = Attribute> + '_ {
>> +    attr.iter().filter(|a| a.path().is_ident("cfg")).cloned()
>> +}
>
> There's also no need to clone; `ToTokens::to_tokens` takes `&self`.
>
> https://docs.rs/quote/latest/quote/trait.ToTokens.html#tymethod.to_tokens

Indeed. In that case I feel like the line is short enough and we can just inline
these and skip the helper function?

Best,
Gary