mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Alexandre Courbot" <acourbot@nvidia.com>
To: "Shivam Kalra" <shivamklr@cock.li>, "Miguel Ojeda" <ojeda@kernel.org>
Cc: <rust-for-linux@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] rust: num: clean up Bounded::__new documentation and comments
Date: Sun, 25 Jan 2026 15:08:49 +0900	[thread overview]
Message-ID: <DFXG2DJ228U0.2ZUKAOIOGUJHG@nvidia.com> (raw)
In-Reply-To: <20260123132132.53854-1-shivamklr@cock.li>

On Fri Jan 23, 2026 at 10:21 PM JST, Shivam Kalra wrote:
> Remove the redundant paragraph in the documentation of __new now that
> the Safety section explicitly covers the requirement. Additionally,
> add an INVARIANT comment inside the function body where the Bounded
> instance is actually constructed to document that the type invariant
> is upheld.
>
> Link: https://lore.kernel.org/rust-for-linux/CANiq72mUCUh72BWP4eD1PTDpwdb1ML+Xgfom-Ys6thJooqQPwQ@mail.gmail.com/.
> Suggested-by: Miguel Ojeda <ojeda@kernel.org>
> Signed-off-by: Shivam Kalra <shivamklr@cock.li>

Thanks for following up on this!

Acked-by: Alexandre Courbot <acourbot@nvidia.com>

  reply	other threads:[~2026-01-25  6:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-23 13:21 Shivam Kalra
2026-01-25  6:08 ` Alexandre Courbot [this message]
2026-01-26  3:14 ` Miguel Ojeda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DFXG2DJ228U0.2ZUKAOIOGUJHG@nvidia.com \
    --to=acourbot@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=shivamklr@cock.li \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®