From: "Gary Guo" <gary@garyguo.net>
To: "Alice Ryhl" <aliceryhl@google.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Viresh Kumar" <viresh.kumar@linaro.org>,
"Igor Korotin" <igor.korotin.linux@gmail.com>,
"Daniel Almeida" <daniel.almeida@collabora.com>,
"Len Brown" <lenb@kernel.org>
Cc: <rust-for-linux@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-pm@vger.kernel.org>, <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH 0/4] Re-export Zeroable and zeroed() from ffi module
Date: Mon, 26 Jan 2026 13:15:53 +0000 [thread overview]
Message-ID: <DFYJRWUHCOMQ.3L6ZVLOJTNDNO@garyguo.net> (raw)
In-Reply-To: <20260126-zeroable-ffi-v1-0-0ef101d1ed85@google.com>
On Mon Jan 26, 2026 at 1:05 PM GMT, Alice Ryhl wrote:
> Currently, the Zeroable trait is defined by pin-init because pin-init
> happens to use the trait. However, zeroed types are useful for many
> purposes other than pin-init. Also, we wish to implement Zeroable for
> types generated by bindgen. For both of these reasons, re-export
> Zeroable from the ffi crate, which is a already dependency of the crates
> with bindgen output.
I don't see a benefit of re-exporting these from the `ffi` crate? Especially
that we re-export `ffi` crate from kernel crate anyway, and `Zeroable` is
already in the kernel prelude.
We already derive `Zeroable` for bindgen via `MaybeZeroable` derive in
rust/bindgen_parameters.
Best,
Gary
>
> Signed-off-by: Alice Ryhl <aliceryhl@google.com>
> ---
> Alice Ryhl (4):
> rust: ffi: reexport Zeroable and related items
> rust: cpufreq: import pin_init::zeroed() from ffi
> rust: i2c: import pin_init::zeroed() from ffi
> rust: acpi: import pin_init::zeroed() from ffi
>
> rust/Makefile | 9 ++++++---
> rust/ffi.rs | 7 +++++++
> rust/kernel/acpi.rs | 2 +-
> rust/kernel/cpufreq.rs | 2 +-
> rust/kernel/i2c.rs | 4 ++--
> 5 files changed, 17 insertions(+), 7 deletions(-)
> ---
> base-commit: 8f0b4cce4481fb22653697cced8d0d04027cb1e8
> change-id: 20251202-zeroable-ffi-2beb542376c3
>
> Best regards,
next prev parent reply other threads:[~2026-01-26 13:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-26 13:05 Alice Ryhl
2026-01-26 13:05 ` [PATCH 1/4] rust: ffi: reexport Zeroable and related items Alice Ryhl
2026-01-26 13:05 ` [PATCH 2/4] rust: cpufreq: import pin_init::zeroed() from ffi Alice Ryhl
2026-01-27 5:20 ` Viresh Kumar
2026-01-26 13:05 ` [PATCH 3/4] rust: i2c: " Alice Ryhl
2026-01-26 13:05 ` [PATCH 4/4] rust: acpi: " Alice Ryhl
2026-01-26 13:15 ` Gary Guo [this message]
2026-01-26 13:25 ` [PATCH 0/4] Re-export Zeroable and zeroed() from ffi module Alice Ryhl
2026-01-26 16:08 ` Benno Lossin
2026-01-26 16:11 ` Gary Guo
2026-01-26 16:14 ` Alice Ryhl
2026-01-27 10:21 ` Benno Lossin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DFYJRWUHCOMQ.3L6ZVLOJTNDNO@garyguo.net \
--to=gary@garyguo.net \
--cc=a.hindborg@kernel.org \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=igor.korotin.linux@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=rafael@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®