From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f74.google.com (mail-ej1-f74.google.com [209.85.218.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C9BD2D7DEE for ; Wed, 28 Jan 2026 11:18:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769599120; cv=none; b=GeJ+O+EwBKWHtlrH0dgLZ/QspFBGN+R26fSZuxnF/eT5jdgc0TNr/4od3LazD89nMtL5LKNHRekKvZ2qhUpmgoxr3eyXPtVsFg9ah4ts3ApeDTDpV6/bDag66j0r0IXqvvdPGHoH/UVkxvdSwhR0blzMqFBrhkbKHG/QZ79Yzfs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769599120; c=relaxed/simple; bh=EC4CajeL8lDheWSIIcXP+9QcBRi+1c/g3PBKw5bAIR0=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=TUx/78T/aXawJCgVIhIDjTgXA/18o4sj/iIy2SCnMaFlamlETII8PS/+nhca6lADFK9KDwXrrmhAm9LANDdjvZ6AwRR5wTrhBp2mLr4OSk/pd4w4q08fM47zGBOBtvsVcf7Ne/3qrlP9SzEQZY4Yp/laQjzt5xO0AOHWonS0WsI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=kUOAFaU9; arc=none smtp.client-ip=209.85.218.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="kUOAFaU9" Received: by mail-ej1-f74.google.com with SMTP id a640c23a62f3a-b88632ba0b5so431881966b.2 for ; Wed, 28 Jan 2026 03:18:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1769599116; x=1770203916; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=EC4CajeL8lDheWSIIcXP+9QcBRi+1c/g3PBKw5bAIR0=; b=kUOAFaU9kSU9MjXoCaqRWuCL92t/2MoW43yQr/Qbxz0JSpqLWtpzkzqNelGBV0i+78 KgBg+GZH99j5KUGCvUoo0H+BfADaDYpWxvq9Zqp4sTZNAUuD0TQihCs3r/Ok/DIx3UXs 8Qgu3fvV37uMt8lJlzqQDavzDMz0dsGLPInc0/QxOXTopLTUPAyf6IVRVT8n0+K9LpU/ p0ybA7jXuJ4iIHojiDN0ajP5FVxiUKWUdB5tuNqQgCnU/FIzj7Bp8xsltiSnGYFszAU8 FTR8fNy3OVe7aHwnqdyxrLysG4ZrKV8BgVjpYcfVx1tppbn/xk3WJL2pUf5Ma4EuJPtH js4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769599116; x=1770203916; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=EC4CajeL8lDheWSIIcXP+9QcBRi+1c/g3PBKw5bAIR0=; b=hYgkAXY1NwcItkVMaaJQ6SKmEvc9wSBj55UOakeKhVicIuuRVchoTDwODlT3yLsjz+ d12TDcYxYYuVViORUAVc+O5J/4uDncdHpkOKSpFSlaEGpYM2De8TN6QXMm9lQuat/ph2 7cclt0zMtTUbdca2LWDuKkhbIN/qZ7IcKXLbKpkRNt2ClWCfpcY6rfEXPpbB6xeDk+2s RWmicCuq7Dnj6Itv0cYgGS++Uts2SZnq5AGaoeDw4OMmY6MomyYGUT6rXQyUqO0Jzuxv A6UaxAMCKYs/AoGk8q5K9RACVo0koHIsWSrOrpbZMi/reCMeDbffHg/XbHPsCr/sUA+b yPkA== X-Forwarded-Encrypted: i=1; AJvYcCUd7olUDk58coJNE2Ioy62jnvdWk+T6oG16AhOZvFjiFjwP+BhSG8BPtEUrdxt/pimt3g2rJ6BMSa2EoEU=@vger.kernel.org X-Gm-Message-State: AOJu0YxxyMHM2+aoPBKSO9YO+0aYLClNB8UcLRZ2ldIeJOkjHIVFa0sa iziOtE1yWQ0ZdKGUzoJtmQFvAN6wOFsmCwqXPSq8Siz+WLaiCTE8nqlKJtH81oQBzQzaNJvZ51v l1jZ9n1E4t5WWog== X-Received: from ejckj13.prod.google.com ([2002:a17:907:764d:b0:b73:5208:4052]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a17:907:3da5:b0:b87:7a69:226e with SMTP id a640c23a62f3a-b8dab28d15amr350226266b.10.1769599116237; Wed, 28 Jan 2026 03:18:36 -0800 (PST) Date: Wed, 28 Jan 2026 11:18:35 +0000 In-Reply-To: <20260128-kselftest-fix-failures-file-v1-1-b58072c66317@linutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260128-kselftest-fix-failures-file-v1-1-b58072c66317@linutronix.de> X-Mailer: aerc 0.21.0 Message-ID: Subject: Re: [PATCH] selftests: runner: Avoid spurious warning about missing failures file From: Brendan Jackman To: "=?utf-8?q?Thomas_Wei=C3=9Fschuh?=" , Shuah Khan , Brendan Jackman Cc: Shuah Khan , , Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed Jan 28, 2026 at 9:05 AM UTC, Thomas Wei=C3=9Fschuh wrote: > When runner.sh is *not* executed via run_kselftest.sh,=20 Hm, what's the usecase for that? runner.sh is a "library", right? So in my mind there's basically an undocumented contract that you need to set this variable before you call the relevant functions. The fix below opens the door to bugs where we fail to report test failures which would be... a shame! > the variable > $kselftest_failures_file does not exist. This triggers a harmless but > annyoing warning from runner.sh if a test fails: > > tools/testing/selftests/kselftest/runner.sh: line 50: : No such file or d= irectory > > Silence the spurious warning. > > Fixes: d9e6269e3303 ("selftests/run_kselftest.sh: exit with error if test= s fail") > Signed-off-by: Thomas Wei=C3=9Fschuh Having said that, it's not a big deal, the risk of those bugs is not that high and we'd probably notice them before too long. Assuming you have a usecase where just setting the variable to /dev/null yourself is a pain, this LGTM. Reviewed-By: Brendan Jackman