From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 908D133ADBD for ; Wed, 28 Jan 2026 14:53:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769612017; cv=none; b=tQKF4xuOR71gjmyb/cOVh6cTmLKKmitKISKcDXKkzV/JPEkB9Hi0TkR3UGyWiWqvMYg4sTR/X+Bo9b2EkTGOJV4hfqFTDcdhHOIBmpCm8DRYIhkrMno1vS+TEPOgk/aTI+ZWOIA90Ld0oU4/6tc7aeqC2okN9YCdaQfHDVfvlyE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769612017; c=relaxed/simple; bh=RLGH0KLlJYKtiHI1o5Hc7krURGr/94NxReup/3F61b0=; h=Mime-Version:Content-Type:Date:Message-Id:To:Cc:Subject:From: References:In-Reply-To; b=DbRmQXLmx51iG63gZM+ZaLKcW4eCI8IgV68IXdZHJ9V5fCI0obVP4IaeBhKV9sVockWxrVHpGD5w+27gzgSsI0YMjLnYxMtL1Bv/tyap4kA12KokfmsWoJMgV8+27qITh6CLJ0mj/Q7+ccAnIWaQrdU6h4TCER5kqAK0A/3ZbBE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=2VBK3Vu5; arc=none smtp.client-ip=209.85.218.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="2VBK3Vu5" Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-b885e8c6727so199231266b.1 for ; Wed, 28 Jan 2026 06:53:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1769612014; x=1770216814; darn=vger.kernel.org; h=in-reply-to:references:from:subject:cc:to:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=0tvMFVjPj7LszBlDjv0UEAIY+fzVqoG9LSfE8sRUrMQ=; b=2VBK3Vu5lBA6MLYy4oFSUJkVAPutIIKdV62A7v/I1JF/Qc6Bkn5OPE1dRB58pgVjOl FN6hU2dQNRI1w5UQpACYrs794d/ZOXmPCJOvE+Xcdk7R2mJ1JGNAojZk4XU4uCMHkrNc Juj8qNug6RyhvLWpzgWi9zF92cDtiSV/mFjjjcTRb6MT/TOfDXRg00wiAeadXjwqIJrL uu+pFGdKTsrwsSv+GVsmHZJ1bUye8elzi/HzQyj4qrh19VGWxRcj6aarrd5mgbyZLsWd X4A9lR4rjaDHKE+BaPubpQVIyqs8D0CxPFIhNPG8SBstzotuW+mgLpdpGryTrG7bZSTj L/KQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769612014; x=1770216814; h=in-reply-to:references:from:subject:cc:to:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=0tvMFVjPj7LszBlDjv0UEAIY+fzVqoG9LSfE8sRUrMQ=; b=JhZ7oVZLfc43zM4soO36fgI3pjlELS3hQbYGb1PAe5kWW1DopExJfFa5/z+pQANsy2 kwp+yC3+HnDAXGoLbovwnjdE6aEijM39dFNfwAfm4x9uxaDYLQUa7maA595cGO5C8JIi UYvv/+ZGo7os/gDBrq2SvlNMfqWWGedH9qmk5jLfUSTdxloQ5B6dDObZXkcinkJbQrVT PEUj+qqEa/GyWvQb5NHtOnP1t+mq86DEsJY4vSVxIfgQ5CSwXoctB0YkQkrTcjfu7iKa ErIURfZN/7X3OJs6XB4p8T/rYMhjeb+mhzKCQfDOLbFDqpBQUQUzROMxa40C0h6CHml+ slDA== X-Forwarded-Encrypted: i=1; AJvYcCXMypnFuc5Qw6FbkCFK7Q7SfKTZgivgZsvkETfQIiZjjDSoCqdMY+H99JAB12aKWwQJxPUEuuPjnh/R3Fc=@vger.kernel.org X-Gm-Message-State: AOJu0YwWAcsuhsEX347AeSnRkj8BVCzhLRCt9YoXNExwZ/EnOKN5Pz2m 4x/Qa+AwkL2xTMAOBlgncDNtAH+M9oMyOPlkf/RnXNwxze/TXLGbI1w39g1d0VyamzJxy2Eug+O hbUEk+LU= X-Gm-Gg: AZuq6aJQgUO/Uotljp6/mrvt4TB/1jWMc37AFbBsBI13mf9SoPZ/DJMoNpm+7MPeUPt XoslM2/L7hOfXPS1ckUBpt64im/ygv1jFJcYMTd6Hl0h4mWIZL80+TSgcStXaeBnNV9e/Bg+o+X xrlMSlAUO5Y7kuDtinukCQaf4fT2fL6Dt+w5SOupVstCufvR7+Cfa1K/TlH+t3G/1n2K+9V0DLN anZlKmzrVVW6OtZo5evjdxOXL5MD8vbvma1CDloJ7Vklhep9nPyxOfcIbv7M+pN24GNO+72v6JL i+4sIQv8VOCr2n0yFeVHNXz3z9yE6uPTG+2mpqj+1HQ9VGSnk7WZxNsF9SHbCH9VVyOtDfM4Rux UqJ2E6ndXrYt3/zBXEcQfkPwkGxn4BuU4zgn5dwlCFq7QA1PFJfacwpzneo9eak+s/Jn8Pr4IDw Jko7qoaOaFaqb7lXL6RE2pwBWS52Htjrt8+RU9MxdilQ6gNU5jueBg93pBkU0/1LKcd2Q= X-Received: by 2002:a17:907:7b8d:b0:b80:456d:bd99 with SMTP id a640c23a62f3a-b8dacc41fabmr404660466b.19.1769612013870; Wed, 28 Jan 2026 06:53:33 -0800 (PST) Received: from localhost (144-178-202-139.static.ef-service.nl. [144.178.202.139]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8dbf2ecc68sm137096266b.64.2026.01.28.06.53.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Jan 2026 06:53:33 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 28 Jan 2026 15:53:33 +0100 Message-Id: To: "Rob Herring (Arm)" , "Luca Weiss" Cc: "Konrad Dybcio" , , "Conor Dooley" , , , <~postmarketos/upstreaming@lists.sr.ht>, , "Linus Walleij" , , "Krzysztof Kozlowski" , "Bjorn Andersson" Subject: Re: [PATCH 1/5] dt-bindings: pinctrl: qcom: Add SM6350 LPI pinctrl From: "Luca Weiss" X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20260128-sm6350-lpi-tlmm-v1-0-36583f2a2a2a@fairphone.com> <20260128-sm6350-lpi-tlmm-v1-1-36583f2a2a2a@fairphone.com> <176960748074.1497503.9897313421386306393.robh@kernel.org> In-Reply-To: <176960748074.1497503.9897313421386306393.robh@kernel.org> On Wed Jan 28, 2026 at 2:38 PM CET, Rob Herring (Arm) wrote: > > On Wed, 28 Jan 2026 13:26:49 +0100, Luca Weiss wrote: >> Add bindings for pin controller in Low Power Audio SubSystem (LPASS). >>=20 >> Signed-off-by: Luca Weiss >> --- >> .../pinctrl/qcom,sm6350-lpass-lpi-pinctrl.yaml | 124 ++++++++++++++= +++++++ >> 1 file changed, 124 insertions(+) >>=20 > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/p= inctrl/qcom,sm6350-lpass-lpi-pinctrl.example.dtb: pinctrl@33c0000 (qcom,sm6= 350-lpass-lpi-pinctrl): Unevaluated properties are not allowed ('i2s1-activ= e-pins' was unexpected) > from schema $id: http://devicetree.org/schemas/pinctrl/qcom,sm6350-lpass= -lpi-pinctrl.yaml I fixed the dtsi addition but forgot about the schema. Will include this diff in v2: diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm6350-lpass-lp= i-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm6350-lpas= s-lpi-pinctrl.yaml index 2fa2484e7bc7..4903b2d37d89 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm6350-lpass-lpi-pinct= rl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm6350-lpass-lpi-pinct= rl.yaml @@ -96,8 +96,8 @@ examples: clock-names =3D "core", "audio"; =20 - i2s1_active: i2s1-active-pins { - clk { + i2s1_active: i2s1-active-state { + clk-pins { pins =3D "gpio6"; function =3D "i2s1_clk"; drive-strength =3D <8>; @@ -105,7 +105,7 @@ examples: output-high; }; =20 - ws { + ws-pins { pins =3D "gpio7"; function =3D "i2s1_ws"; drive-strength =3D <8>; @@ -113,7 +113,7 @@ examples: output-high; }; =20 - data { + data-pins { pins =3D "gpio8", "gpio9"; function =3D "i2s1_data"; drive-strength =3D <8>; Regards Luca