From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45B7724A064 for ; Thu, 29 Jan 2026 22:01:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769724097; cv=none; b=LRnHl5kzW1J7qIH2u0OTAoJE2i8YJeQCiBKKxCmelC76gbNXlb0vRcZZ+r5NlGAri1P5HvzYL1l9P+B3pXM2cHb56tC/VAI9OQPqPgZBn8958MoO8Xl5gahdDvsAycxd6OKNuRUoa0vVlazV//gSyajeIQN4CmYpuSMeKqa3ric= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769724097; c=relaxed/simple; bh=tShtgEb6PrrHsVoTgUMICzXzwPuiV1UsqwCEidOLv+k=; h=Mime-Version:Content-Type:Date:Message-Id:To:From:Subject:Cc: References:In-Reply-To; b=Lelz+hR5ZC6ROTcey8PkQztSG3+jq+aNvlslQWbCMvggc58eBCTU81t2EzOmASOxxDp4tfmk7rItNLj3OFmH9mBAp0QGhuv0II7yxbFA74izp940f7WwtExVmb+NqjxvRN+mCE1GTO4T/yCFIk8Vz6LlGMoyTjZ02w2naYAl1/4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=YpY/j04T; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="YpY/j04T" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id A798C1A2B15; Thu, 29 Jan 2026 22:01:32 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 6B8AC60746; Thu, 29 Jan 2026 22:01:32 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 8D72E119A87AF; Thu, 29 Jan 2026 23:01:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1769724091; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=tShtgEb6PrrHsVoTgUMICzXzwPuiV1UsqwCEidOLv+k=; b=YpY/j04Twk+Wp8SW4Sm7G8YbY2ghy01GGC9oiX+zIIYhB1gBK8cJ0qMYl2O0hh2M8d7H55 qO4l6Za+CruuNsdjUq+dKcCn7T41t3owZZRZ7cPNc+OO/IfEC3TtTEiLzT83nyhdqZwLp9 DqRjDuxW8IjHQ/rljBD+BJKqUiy7sEx/8gatJ+kxDjzPIPc+fYvPzOnfGyQpnAUjXG2fiF OFRJk/HdQK7Okqq1QFdxljpeHMxcJQwBRqi6bQ4IwHwjYnqpwJfBft+A3b4EycpT2OPlYu Q9nFaRictojBvDlK8fMfspB7296iEqhXSo3NmaOlVhf4HLW1+pqW5MJGSP6PBg== Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 29 Jan 2026 23:01:26 +0100 Message-Id: To: "Felix Gu" , "Paul Kocialkowski" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "David Airlie" , "Simona Vetter" From: "Luca Ceresoli" Subject: Re: [PATCH] drm/logicvc: Fix device node reference leak in logicvc_drm_config_parse() Cc: "Paul Kocialkowski" , , X-Mailer: aerc 0.20.1 References: <20260130-logicvc_drm-v1-1-04366463750c@gmail.com> In-Reply-To: <20260130-logicvc_drm-v1-1-04366463750c@gmail.com> X-Last-TLS-Session-Version: TLSv1.3 On Thu Jan 29, 2026 at 5:21 PM CET, Felix Gu wrote: > The logicvc_drm_config_parse() function calls of_get_child_by_name() to > find the "layers" node but fails to release the reference, leading to a > device node reference leak. > > Fix this by using the __free(device_node) cleanup attribute to automatic > release the reference when the variable goes out of scope. > > Fixes: efeeaefe9be5 ("drm: Add support for the LogiCVC display controller= ") > Signed-off-by: Felix Gu Reviewed-by: Luca Ceresoli -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com