From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vs1-f43.google.com (mail-vs1-f43.google.com [209.85.217.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52A37315760 for ; Sat, 31 Jan 2026 00:55:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.217.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769820956; cv=none; b=AzxdCefhqRFFZFBGlREEP/g5GII67w74bqUBcq1kTidfdF9RbvcjI5tLVtRFhpOW8x4/6o23PszZ0zlVYWMaV2FUKfFjxpzGoXb+2wqMoI0/6gonZVexzWA9ytv8wjgNxu7l2/1HsTshvJvwe9JyknrMSF7NkAYBPWfozObYLww= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769820956; c=relaxed/simple; bh=Z1JmO0I/bAD2VuhUhgeTdA/CEFjzp72kijRKOu/bnjU=; h=Mime-Version:Content-Type:Date:Message-Id:From:To:Cc:Subject: References:In-Reply-To; b=TkKuYZyOTjt1tsvA3rxChCGGiYUSPaB2Eln/sMmHNCLxbqBvMfSiRpkgxc6RtiowRUZ4enRfSB4kmCHT+1eBMW/7Wh312vXsvNTxzpNszpsHrm/6RnPj6pnGF5TQcX9eKYQdnQwn23DcqayCfOWHAFpwC+pjDkr/crQJLPAsPTc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=A9om7XWe; arc=none smtp.client-ip=209.85.217.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="A9om7XWe" Received: by mail-vs1-f43.google.com with SMTP id ada2fe7eead31-5f547823192so1055544137.0 for ; Fri, 30 Jan 2026 16:55:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769820954; x=1770425754; darn=vger.kernel.org; h=in-reply-to:references:subject:cc:to:from:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=9WlO7xYJM+tT3nKpCZj4OQK4votiqUa3y4KG/p2upfU=; b=A9om7XWeXKJN1Z+AedcVC6y8bzsZPEly5ezFJy06rSVg/u3V+Kn32SyLALUNuM5Ed2 vLWdaivqE0bNOK5m0/XwV4kUZrorAzE5ET7dGFXGxFy0Ckk/jRYPI6Fv293FfuTJ2Rrg 1YX/83cd6ZhODIyUjYNtx3VlrKsQAOnc6CTFw1R2yzgTQK69zWReSOzd+JJVaSXUjnO4 sq49GELFoRPoq5oD1E1PNNDrvuaX/oVPl4q7guOISU7j9GjWRg8TMp5K3dYESs6Dr074 U2S8+ExTO0YagFdb3Q9xLGZxImMXL+LOT+u+6gpkqs55teKd2D2iEwuSl8UPdXatGfnU hEbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769820954; x=1770425754; h=in-reply-to:references:subject:cc:to:from:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=9WlO7xYJM+tT3nKpCZj4OQK4votiqUa3y4KG/p2upfU=; b=RfcyAQ3sKo4irzVTs6sX7kw3gCHOVix6UC5Gv+eHHL8U9F267ecnAIqe3ZIuTFU5SC Xg4GHotg0IS1jasyNeYLOVcghrNsYnmvg29DdGD/uLV/sxbBrc4IBaHaLOSH/x/NLdNr naHgi81r2EA/OEsCwPJWkdlwonyENG1XKK8pHWXUOGxoa4BmVjeuD7+lrDacE4wqfDgV ianRhej6+FEjlA9/JfBV0u+/m5QVrOmB6Ut32U1DolxMIrdE1hmHv0D4ABWbMn6DVX7i gYUmao3lQt/01j7uOHr+Ey9G0Npzx5e+yfLQTlX9rTgSefP63lBFilQCKALLtWXaxx0D Pb8Q== X-Forwarded-Encrypted: i=1; AJvYcCUa1f63JBxPzLJ/eOAKuQlGpueOM1VOowhcRkibAuwIvoNUjxJgAN3plgQdTDdcsgjhiveSNqMya4Vzsyw=@vger.kernel.org X-Gm-Message-State: AOJu0YwJPPgFrLdJG5aS2GsCxx5J2VI3BvVgpcneD4efBuSQg+Gv4iM8 c9ujQcXFsB9ueH9TKCXPC2CICnVd9YNVICAXG7HghxycDODcNgAnAqco X-Gm-Gg: AZuq6aKtkV+9V0fR5iMmiTJAB6wJjOJ1r9oP/GSlAcdU1hFp7WsUFZTJBN00JWvRoE8 548ts7WhiYFEiQyeC8RVP/prP97vC3b6GWDTUsI3acYcKvaDqFi+q8ZzIrMK1432yOBIrn+tCd5 JaQyxV/HdS+G6B/ZCBCHZWLtq8O2tuBb1zgLLyZ6qD0R8Jl2W3JRc0Zj8TLHtlHh4wkoRAmuX37 W1cL7oc5ztU+3RLE6INrYSbGPQvsVOMk9ndaqmlt4UdrTuXzYtbZoCnnE+7LBlwoegwurFPibAz 9I2DLTUFlSoz+8XPMiL+WPWR8YyvnSxO92Frzoxlp5QYtF0oBssATyL04zlGxC8RC/u+gF/ZDoA ORuyQAmre74WOCqS/RXQRQ30zr9NCHf4laZIQ1lx40DN0fTfNCjmq1qJZTm7pW+HcmRLHlAD+ml vlEVLg9A== X-Received: by 2002:a05:6102:d8a:b0:5f5:35bd:6fb3 with SMTP id ada2fe7eead31-5f8e23760a7mr1453134137.5.1769820954185; Fri, 30 Jan 2026 16:55:54 -0800 (PST) Received: from localhost ([2800:bf0:150:1112:fd48:bce3:7e1d:77e2]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-5f734eb4e8dsm2440249137.11.2026.01.30.16.55.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Jan 2026 16:55:53 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 30 Jan 2026 19:55:51 -0500 Message-Id: From: "Kurt Borja" To: "Guenter Roeck" , "TINSAE TADESSE" Cc: "Armin Wolf" , "linux-hwmon@vger.kernel.org" , , "Guenter Roeck" Subject: Re: [PATCH 1/3] hwmon: spd5118: Do not fail resume on temporary I2C errors X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <39b48803-e236-4acc-84e9-18162770f9ae@roeck-us.net> <5ecc96da-0c87-45f6-ab57-c3ea8eb28de1@gmx.de> <6249756d-7e49-464e-bb7e-11dfba3085f3@roeck-us.net> In-Reply-To: On Tue Jan 27, 2026 at 6:41 PM -05, Guenter Roeck wrote: > Hi, > > On Tue, Jan 27, 2026 at 10:23:24PM +0300, TINSAE TADESSE wrote: >>=20 >> Disabling CONFIG_SENSORS_SPD5118_DETECT completely avoids the issue on >> affected platforms, >> even without any code changes. This confirms that the failures are >> triggered specifically by automatic >> SPD5118 instantiation on systems where the i801 controller enforces >> SPD Write Disable. > > Thanks for confirming. Can you try if the patch below fixes the problem ? > It is a wild shot, but it might be worth a try. > > Thanks, > Guenter > > --- > From b44c31c2c779a67827e3144b818cf21f5efacea1 Mon Sep 17 00:00:00 2001 > From: Guenter Roeck > Date: Tue, 27 Jan 2026 15:32:32 -0800 > Subject: [PATCH] hwmon: (spd5118) Explicitly enable temperature sensor in > probe function > > Instantiating the driver does not make sense if the temperature sensor > is disabled, so enable it unconditionally in the probe function. > > If that fails, write operations to the chip are likely disabled > by the I2C controller. Bail out with an eror message if that happens. > > Signed-off-by: Guenter Roeck > --- > drivers/hwmon/spd5118.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/hwmon/spd5118.c b/drivers/hwmon/spd5118.c > index 5da44571b6a0..3e0e780014f9 100644 > --- a/drivers/hwmon/spd5118.c > +++ b/drivers/hwmon/spd5118.c > @@ -552,6 +552,11 @@ static int spd5118_common_probe(struct device *dev, = struct regmap *regmap, > if (!spd5118_vendor_valid(bank, vendor)) > return -ENODEV; > =20 > + if (regmap_update_bits(regmap, SPD5118_REG_TEMP_CONFIG, > + SPD5118_TS_DISABLE, 0) < 0) > + return dev_err_probe(dev, -ENODEV, > + "Failed to enable temperature sensor\n"); > + > data->regmap =3D regmap; > mutex_init(&data->nvmem_lock); > dev_set_drvdata(dev, data); Hi Guenter, I'm experiencing the same issue reported in this thread. This patch does not fix it for me :(. --=20 Thanks, ~ Kurt