From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C164826CE17 for ; Sat, 31 Jan 2026 15:27:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.171.202.116 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769873249; cv=none; b=kqZ2cIaA5SeRXwo6/XvnqBJQfqAhWr/S42aCmCdb9BWM00t8luc4nskxrCrXuQfqIRvr47UAvFGjHNb0zy0R1MOB3gwvFqMrG/n9OepysajLtardwUcIgY+fyns1G1a53bJo0vIyQyzIdKh6QQOJW3UmKxHHw1eTm0PKm4I3zkU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769873249; c=relaxed/simple; bh=qtpmDsq3ytg4fhtKS3sLcNy2RBrYqbbzW5k5P5GOj2g=; h=Mime-Version:Content-Type:Date:Message-Id:To:From:Subject:Cc: References:In-Reply-To; b=MlD7Yk+z5/C8EUKIT6w1bT1Yya35y57v0uVaXfs96z3ogbDZuH/sSwmwU5ALI2gicYM+yYPWKcXMGBWVkavsRrcM/jErt8H0v06SbDxBL5EWIYBv5uJIXI4KULJ47nARte40ihdY1eUEHM2MTLtfgG97kFb79u8j3u/Km4oTW74= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=BAMZMV9m; arc=none smtp.client-ip=185.171.202.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="BAMZMV9m" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id 04793C22F7E; Sat, 31 Jan 2026 15:27:30 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 1B789606B6; Sat, 31 Jan 2026 15:27:26 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id DC896119A888D; Sat, 31 Jan 2026 16:27:19 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1769873245; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=1BjwHKdIR0J3wfWhl7U6iKJkPH13bu7eeuse87r/j0w=; b=BAMZMV9mXKRYc3CwqSdirB45ZqkRodmw8anrVG1dtlflolsGttLuabyAEkYaiasbV8+dbH 9vfIa1LFOWX+PVOrnvjZsEgFEkNS5vOY8YvpfoSVFM4v356maVJsYYGlwoiWCm0dPQPtNe WOdyn8mo1/mL3dYWGWvcRJdkCGNIGJMMeotKO+/OHi/4VWkS0GoXg9wAAN9Ie8SO+7S3Pb FbncBPqnyMwLRZdm99kTAB+mtyMc5zQQ+0G/AZ8Ycbyg/pOzKkj+ZOjPinkfy8pvhshK+U Iz7Y7UUT6u22Ez8olLUjgWmhcnQbuwfo/6a81GM9XxlUqAIKNKoqMOI6+fBatg== Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Sat, 31 Jan 2026 16:27:19 +0100 Message-Id: To: "Linus Walleij" From: "Luca Ceresoli" Subject: Re: [PATCH 4/6] drm/mcde: dsi: convert to of_drm_find_and_get_bridge() Cc: "Biju Das" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "David Airlie" , "Simona Vetter" , "Anitha Chrisanthus" , "Edmund Dea" , "Laurent Pinchart" , "Tomi Valkeinen" , "Kieran Bingham" , "Geert Uytterhoeven" , "Magnus Damm" , "Tomi Valkeinen" , "Hui Pu" , "Ian Ray" , "Thomas Petazzoni" , , , X-Mailer: aerc 0.20.1 References: <20260116-drm-bridge-alloc-getput-drm_of_find_bridge-4-v1-0-e34b38f50d27@bootlin.com> <20260116-drm-bridge-alloc-getput-drm_of_find_bridge-4-v1-4-e34b38f50d27@bootlin.com> In-Reply-To: X-Last-TLS-Session-Version: TLSv1.3 Hello Linus, On Mon Jan 19, 2026 at 9:57 AM CET, Linus Walleij wrote: > On Fri, Jan 16, 2026 at 6:33=E2=80=AFPM Luca Ceresoli wrote: > >> of_drm_find_bridge() is deprecated. Move to its replacement >> of_drm_find_and_get_bridge() which gets a bridge reference, and ensure i= t >> is put when done. >> >> We need to handle the two cases: when a panel is found and when it isn't= , >> even though the latter is not supported. So: >> >> * in case a panel is not found and bridge is, get a reference to the >> found bridge >> * in case a panel is found, get a reference to the panel_bridge when it >> is added, so the following code always get exactly one reference that >> it needs to put >> >> Finally, use the next_bridge pointer in struct drm_bridge in order to >> simplify putting the reference. >> >> Signed-off-by: Luca Ceresoli > > I do not understand the change as a whole but the approach > looks sane so: > Acked-by: Linus Walleij Thanks! However I'm not adding your A-by to v2. The change you suggested to patch 3 (break instead of warn) made the drm_bridge_put() call in this patch unnecessary, so I dropped it for v2, making this patch slightly different. I hope you'll Ack v2 too. :) Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com