From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from layka.disroot.org (layka.disroot.org [178.21.23.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 195B833CEB9; Sun, 1 Feb 2026 14:14:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.21.23.139 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769955288; cv=none; b=k0fcvdEdb+ab5Q9MEjZGgVmL7Ffo+zq+gwLNPDage+k6m7XM2mHO8uPvC81D6Zs3mMLd+T6pAV1qfVdvVKWK/MIiAjb7CAeO9wTrs1QI3sgYVAndpdaNfUYeTOC2F8EtaMsof6HwF+fTNIhvqpNoHmHSpHMjvvMHKo/toIy9q6A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769955288; c=relaxed/simple; bh=HyiFrtV16BT2yMD0/WH+EkSthkQwVKOebWrORCHC8bU=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:From:To:Cc: References:In-Reply-To; b=Z6KV4kFDSaqciJAaOYmnWdk8TjEPHjHj2Az5VxTEb0hj5DnWzKzBJumbLSbmWYWihppLPmXKqeTjS7Y7/KLEIRrjrDGaZdFFISCg0F5HMBUtmqX0CyUoT8NAnaTe+eZchbYLgB1wuERb4ET3iN6XqCJxgPsTkK6xPEoX3gUfOvk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org; spf=pass smtp.mailfrom=disroot.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b=kpITffrX; arc=none smtp.client-ip=178.21.23.139 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=disroot.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b="kpITffrX" Received: from [127.0.0.1] (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 5DE2326125; Sun, 1 Feb 2026 15:14:37 +0100 (CET) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id v6vFyFPygDq0; Sun, 1 Feb 2026 15:14:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1769955276; bh=HyiFrtV16BT2yMD0/WH+EkSthkQwVKOebWrORCHC8bU=; h=Date:Subject:From:To:Cc:References:In-Reply-To; b=kpITffrXNM5mo/aIaQotE/HwHYqgja7BYdRED5/t14rR5pvLSCIBfuFithK+VaFd9 TPzlXT08+jGsc/LDw+BhEDSproQ5MVaNlFBDGejKF5gfZ5b8v11/2FcOgkai7Oprkf qIA9Wm3T0eNy1FTIhAr5QLKh5ZTZ0e5fgrpJd5w60lBbR8TRtU9uVOXl9YggSFf23V KN45QW8Ogr2POMi6YUAawsibxCntEyrL0CF53lsEhNOV91IJugr8KQLccrSAoqU4En uQ7mXI304ZNA5kM5bIMXty6PewA9mVZfXPIKdvxuca+/SiK++FFfGU5AajZlsYFPQv zxNL3UkWoPKvg== Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Sun, 01 Feb 2026 19:44:24 +0530 Message-Id: Subject: Re: [PATCH 1/3] drm/bridge: samsung-dsim: move bridge init sequence to atomic_enable From: "Kaustabh Chakraborty" To: "Marek Szyprowski" , "Kaustabh Chakraborty" , "Inki Dae" , "Jagan Teki" , "Andrzej Hajda" , "Neil Armstrong" , "Robert Foss" , "Laurent Pinchart" , "Jonas Karlman" , "Jernej Skrabec" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "David Airlie" , "Simona Vetter" Cc: , , References: <20260124-exynos-dsim-fixes-v1-0-122d047a23d1@disroot.org> <20260124-exynos-dsim-fixes-v1-1-122d047a23d1@disroot.org> <1db5ffdf-924b-49cb-a057-802a1bfe6073@samsung.com> In-Reply-To: <1db5ffdf-924b-49cb-a057-802a1bfe6073@samsung.com> On 2026-01-26 09:57 +01:00, Marek Szyprowski wrote: > On 24.01.2026 18:20, Kaustabh Chakraborty wrote: >> Since commit c9b1150a68d9 ("drm/atomic-helper: Re-order bridge chain >> pre-enable and post-disable"), pre-enable sequence is called before the >> CRTC is enabled. >> >> This causes unintended side-effects (abberation among potentially other >> things) in the display when samsung_dsim_init() is called in the >> pre-enable part of the sequence. Call it in samsung_dsim_atomic_enable() >> instead. >> >> Cc: stable@vger.kernel.org # v6.17 and later >> Signed-off-by: Kaustabh Chakraborty > > I'm not sure if this will be needed: > > https://lore.kernel.org/all/20251205-drm-seq-fix-v1-0-fda68fa1b3de@ideaso= nboard.com/ Tested on v6.19-rc7, this is fixed now. This can be dropped. > > >> --- >> drivers/gpu/drm/bridge/samsung-dsim.c | 13 +++++++------ >> 1 file changed, 7 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bri= dge/samsung-dsim.c >> index 1d85e706c74b9..975f8b50ae660 100644 >> --- a/drivers/gpu/drm/bridge/samsung-dsim.c >> +++ b/drivers/gpu/drm/bridge/samsung-dsim.c >> @@ -1655,6 +1655,13 @@ static void samsung_dsim_atomic_pre_enable(struct= drm_bridge *bridge, >> } >> =20 >> dsi->state |=3D DSIM_STATE_ENABLED; >> +} >> + >> +static void samsung_dsim_atomic_enable(struct drm_bridge *bridge, >> + struct drm_atomic_state *state) >> +{ >> + struct samsung_dsim *dsi =3D bridge_to_dsi(bridge); >> + int ret; >> =20 >> /* >> * For Exynos-DSIM the downstream bridge, or panel are expecting >> @@ -1665,12 +1672,6 @@ static void samsung_dsim_atomic_pre_enable(struct= drm_bridge *bridge, >> if (ret) >> return; >> } >> -} >> - >> -static void samsung_dsim_atomic_enable(struct drm_bridge *bridge, >> - struct drm_atomic_state *state) >> -{ >> - struct samsung_dsim *dsi =3D bridge_to_dsi(bridge); >> =20 >> samsung_dsim_set_display_mode(dsi); >> samsung_dsim_set_display_enable(dsi, true); >> > Best regards