From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE2551E1A3D for ; Sun, 1 Feb 2026 21:47:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769982451; cv=none; b=Yyi2Q5skhH22L1MqJ+LXc32Sckni3MLD53SGZXxT8KZcjqitr33ePAvrN5RXgO5+0SOcwioyIsmnbXChsFuhpCJdFykg5CRGvGVAyVpzJxJkUDLaTZ9J8zkE9peQVB6B0tp3viATFK1uhGLgjE9UBi3uuoPSNKUS9k54jXVt+s0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769982451; c=relaxed/simple; bh=UUJi09olw3z2alBOMu1Tzu+FggHp8iosUalWgPJFN/I=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:Cc:To:From: References:In-Reply-To; b=sRWTp3LefkDmsf6OiynrcQJjSniWZIOu0j/QYf4ELVWJ7fzUJB5IwHpyu+Zco9W0fx6vQ30x/1KDPswwFrtsQa3IfPpfpHRDbRPMlxI3fM8sbPrB8EVYoM5lxic6uk6fAdSClbDqjKesGxFhlg/Rb/gvzatjnVyF+TXER/UU5V4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=rSSQ1vvB; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="rSSQ1vvB" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 68A38C4CEF7; Sun, 1 Feb 2026 21:47:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769982450; bh=UUJi09olw3z2alBOMu1Tzu+FggHp8iosUalWgPJFN/I=; h=Date:Subject:Cc:To:From:References:In-Reply-To:From; b=rSSQ1vvB9dkWUjAJ3FRKZ5I1CInEoEmQpvhHB1yQgkKMY9A5uorAcxj6fB8ytGKh1 qT26KzMBy8zYnI/CiJ6PC59GGuEW5p6liU917BsqSxtoLL5skP+JtJdcrKsFP9QHci T77vLP6BbWMgok5mdjdPQnq+kSNe9L4QTWx2iTKZ9EIeeBrSLIMiln/fgc9n5V1Bom 5i8ZMSkjT/oFApnIsu3lCAHj7EdH20Dj59bmDHXWf71w2DL287MlB1fZXnyZSG+fHI Xl/LD9RcxMrCopXJPSwEC7MQqdkh3D6iLRVmypNmQLdzUbcxx+iHppF7gElD5CjvwI Bbti8kDaSuokA== Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Sun, 01 Feb 2026 22:47:26 +0100 Message-Id: Subject: Re: [PATCH drm] Revert "drm/nouveau/disp: Set drm_mode_config_funcs.atomic_(check|commit)" Cc: "Lyude Paul" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "David Airlie" , "Simona Vetter" , , "Dave Airlie" , , To: "John Ogness" From: "Danilo Krummrich" References: <20260130113230.2311221-1-john.ogness@linutronix.de> In-Reply-To: <20260130113230.2311221-1-john.ogness@linutronix.de> On Fri Jan 30, 2026 at 12:32 PM CET, John Ogness wrote: > This reverts commit 604826acb3f53c6648a7ee99a3914ead680ab7fb. > > Apparently there is more to supporting atomic modesetting than > providing atomic_(check|commit) callbacks. Before this revert: > > WARNING: [] drivers/gpu/drm/drm_plane.c:389 at .__drm_universal_plane_ini= t+0x13c/0x794 [drm], CPU#1: modprobe/1790 > BUG: Kernel NULL pointer dereference on read at 0x00000000 > .drm_atomic_get_plane_state+0xd4/0x210 [drm] (unreliable) > .drm_client_modeset_commit_atomic+0xf8/0x338 [drm] > .drm_client_modeset_commit_locked+0x80/0x260 [drm] > .drm_client_modeset_commit+0x40/0x7c [drm] > .__drm_fb_helper_restore_fbdev_mode_unlocked.part.0+0xfc/0x108 [drm_kms_h= elper] > .drm_fb_helper_set_par+0x8c/0xb8 [drm_kms_helper] > .fbcon_init+0x31c/0x618 > [...] > .__drm_fb_helper_initial_config_and_unlock+0x474/0x7f4 [drm_kms_helper] > .drm_fbdev_client_hotplug+0xb0/0x120 [drm_client_lib] > .drm_client_register+0x88/0xe4 [drm] > .drm_fbdev_client_setup+0x12c/0x19b4 [drm_client_lib] > .drm_client_setup+0x15c/0x18c [drm_client_lib] > .nouveau_drm_probe+0x19c/0x268 [nouveau] > > Fixes: 604826acb3f5 ("drm/nouveau/disp: Set drm_mode_config_funcs.atomic_= (check|commit)") > Reported-by: John Ogness > Closes: https://lore.kernel.org/lkml/87ldhf1prw.fsf@jogness.linutronix.de > Signed-off-by: John Ogness Applied to drm-misc-fixes, thanks!