From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6ED811D6195 for ; Thu, 5 Feb 2026 09:21:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770283297; cv=none; b=Dlkv04mFvdF3osbQcmdzw+OP1vi05XP4o/yQY9COMQIIdAXqWHXIjYAIcPJUB/Zdeqm2ZItaagrb2BVEEo0yvsn5RITsrskmATJfsUfz2dYE7t0UVD041iFeJ8vkhEJRPAI9Ts0EVlic7I9bM+XOeaF8H7tiBuOrsl2nezlWy6Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770283297; c=relaxed/simple; bh=TjJwQ30B8ulmotyPacBb374jrp7gGZ5n6uQH42MzFB8=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:Cc:To:From: References:In-Reply-To; b=K78F7/qS8T8Sg1Rk1BK+NHEh0+zmmSOnf2WkK9NKlFop5ucmZ6y5ckRq6tugV7MZaI2Du0UCK8X49eZV2QYEc8pE8t+B78C08q5w7d40IEc3RTrqt3unGh2lpNyjJLx2P6wZIDUkS2w7wwuyt9HKQp9rIRzsF4aGDsFfGy2emqA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=qtaCayC1; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="qtaCayC1" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id D12024E4240F; Thu, 5 Feb 2026 09:21:34 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id A2BC3606FD; Thu, 5 Feb 2026 09:21:34 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 98734119A865B; Thu, 5 Feb 2026 10:21:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1770283293; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=Ty37LSAWvvUI6qAp67+JaVk7ExaFUkeXx5EXAWhMrmc=; b=qtaCayC10O/iglKC9KAONKb/mFoaRGMI9j30TDsCXIC7BLIHd4ztEbDFsTWtC1aqQWMCKs ONrOeFpuFtsNHacTMORdI041H0Q4O4E5krvkda6EVhxohm6gqKkiMHw8aWoWBX42EfrsVt AMAh3WcnHfza1IxaXtHp6OrDmuDovDaRf1fq5cokx6fIefkK4Et5QWv7+62UN+XprLixnG NSbUDwoLEeGNdSOSmdAuj5HXJ5IFY4Ic3pEyJlS9uR1+hR+dUTuG5T8aQchHLwoL1evNVM YLZ4ovWkBvHPtYPJuCjGCilq/FLt5wnYUOpYr5605jpAVHQ/Svv7CYRZ6TJtBA== Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 05 Feb 2026 10:21:25 +0100 Message-Id: Subject: Re: [PATCH v2] drm/bridge: synopsys: dw-dp: Check return value of devm_drm_bridge_add() in dw_dp_bind() Cc: , To: "Luca Ceresoli" , "Chen Ni" , , , , , , , , , , , , , , From: "Luca Ceresoli" X-Mailer: aerc 0.20.1 References: <3384b794.65bd.19c27b7d739.Coremail.andyshrk@163.com> <20260204092148.2309681-1-nichen@iscas.ac.cn> In-Reply-To: X-Last-TLS-Session-Version: TLSv1.3 On Thu Feb 5, 2026 at 10:06 AM CET, Luca Ceresoli wrote: >> --- a/drivers/gpu/drm/bridge/synopsys/dw-dp.c >> +++ b/drivers/gpu/drm/bridge/synopsys/dw-dp.c >> @@ -2049,7 +2049,11 @@ struct dw_dp *dw_dp_bind(struct device *dev, stru= ct drm_encoder *encoder, >> bridge->type =3D DRM_MODE_CONNECTOR_DisplayPort; >> bridge->ycbcr_420_allowed =3D true; >> >> - devm_drm_bridge_add(dev, bridge); >> + ret =3D devm_drm_bridge_add(dev, bridge); >> + if (ret) { >> + dev_err_probe(dev, ret, "failed to add bridge\n"); >> + return ERR_PTR(ret); >> + } > > Looks correct, but can be simpler: > > ret =3D devm_drm_bridge_add(dev, bridge); > if (ret) > return ERR_PTR(dev_err_probe(dev, ret, "failed to add bridge\n")); I noticed you are doing the same fix in [0] but without logging a message. Either is fine, but I don't see why using a different policy. I think not logging anything for devm_drm_bridge_add() is fine, because the only error it can return is on a small memory allocation which de facto cannot happen. So I'm OK if you just ditch the message in v3. [0] https://lore.kernel.org/lkml/20260204090629.2209542-1-nichen@iscas.ac.c= n/ Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com