From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C5B02FFDEC for ; Thu, 5 Feb 2026 09:47:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770284878; cv=none; b=g/fkcybDrOEM0ezUQsxEfX/eAa/F/v9Tjs1idYBFV95UKhIDTdgyvwXrR9P81+yj0p+Gv+bBnVOWBzTl9oVqRGiytpbgnR59t+WHkKCm8Dj7f743YxtLNwrGiOVbClCEL1qJo+HdM0qPOdFxkQxNwY5Un5MynQhm5Q+TU/D7Pbs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770284878; c=relaxed/simple; bh=iTPRLWCrtwEnPiBKOwDCIY1yQgs7QyjSJqN+DML3kvA=; h=From:Mime-Version:Content-Type:Date:Message-Id:To:Cc:Subject: References:In-Reply-To; b=WWrng2zWNEBBsLA3XrLcX3o2CZdh2BWG4g2F95XEL78BXapRVesY5/ifi3aNE+dGVzBIqBL1IVD/jsm8XAWV/ffatLgXGu4DxPq4nM41Gc8H9UT68RYyCNdD5aWwwOXpQTEhkF9DUnbDzPsHlCddLuRhuXlkd8toxDWPrOBCnzI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=YJmex3yi; arc=none smtp.client-ip=209.85.218.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="YJmex3yi" Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-b8eafb515aeso86243466b.1 for ; Thu, 05 Feb 2026 01:47:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770284877; x=1770889677; darn=vger.kernel.org; h=in-reply-to:references:subject:cc:to:message-id:date :content-transfer-encoding:mime-version:from:from:to:cc:subject:date :message-id:reply-to; bh=A8L/5GVKN6SgP0V716Hd0o1e71oyUMMXvmVf3IuUxkA=; b=YJmex3yiIWFPQpkrFCR4VmRHnVYbrsvHLL1uegtkSG/Ar44V9F0AkYTjLHjQhD+0Oa RBgRp2ZoXp+yikEv/cJLqUjssGO+CzfNT44peZ8LKx2xP6Src196KemyFYyeKBsi+s7d 6Lbx5CxVntCSNsY8wi8OhL2bk8z6TH+4Y5Du5KyK0i90OQ7QWFGnFE/bh+GbsIf5nTlQ 1GwwOq0xpO2T2OTMTykKQ84eHPcd/SeF98pklqqeaL90GYdLcJLoumV+Y5gUdpx5I69R S1u+ggRLP9aR3UTAE2vNqQ3gDms08FAd9LXYsl+q31Lr2PR+HWM4yYAPRz05xsiAgSe7 +TmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770284877; x=1770889677; h=in-reply-to:references:subject:cc:to:message-id:date :content-transfer-encoding:mime-version:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=A8L/5GVKN6SgP0V716Hd0o1e71oyUMMXvmVf3IuUxkA=; b=dwdnnuZNPf79qmewwxpLoGBGrneC+ko5rk1gpHRk1CBK0ZgqPuCaMgPlAQ6xJQgUCa CdiD1rdBcTdn5cAOpYk7qorLV73tkW1+7kEgvHA7SNrcCLUaIWfyXRiRM0wCCVe0PH/i NTkyLXDR2XVrP7OAcSEgyklpOAIjbXTkSRjtjMzoM8t+fxA2Qpl//35RW0Slp52o5GJo kWlhkH8lBDWvKZK1tWfziyv0TbxRf04H323M/WyNC8lrvtZv5u/3vnLAc6QcXDhrSzrn yC0dfhOcc6H0CL+Ec5jjJkZhVQmPq+CLYnkFDYRCjOZphG767jYU6xTEC/NXDsvl7UDN osAA== X-Forwarded-Encrypted: i=1; AJvYcCWLNf8dpiNz4xxiu0wrQ8o1Ql9nrqHHflmvAXoA+coXy+dqDQ/qzK7WUAFsOFZOD5Ry+CpDEGcudW77Jx4=@vger.kernel.org X-Gm-Message-State: AOJu0Yx0Gnud3AIIiHReqESgAgYcxd5LHMNOerZ63Hn3213REcs2Sls4 PuWv0JOQIKX9NRIDFQFGIHyVfe2sZcq4XLWNFrZ9HYgLPCudB4x9WzdQFjfoWp3/kLNQYpb67oR Ayhujfeo= X-Gm-Gg: AZuq6aK8JZv6FUYd6gphTYwzlZaWEAt4Z4PMOU+dScjPuH6C2luj1OGJzxxoDcJ8I47 H7NM+lXM5jZKrcKcA1FXQaBrwb2NSnJqo8tsmFvgJRJQLD7UJaWqmv2WgHzRVnbGW0eKgKTg/Er OJ7XC+9Q7ChWvwrEiFLFyvEyl6KJIKnf9pBezVTr9y7ziFXjAakoM13bE8TTQjJifYFKIvlVmK4 XR8jZqQUmHwlQuIp7lNyS6IMPnvsrghxsumYkbq4anA7eU97elyYMA8xY3Av7EgRoJL8vj8oQC5 QqSGl5fbH1WZIH3yoSyT1ctdzkr43q/84ZagQFvKhq10YjCkpBwzcF6f2Po6eApSRJ4O1XIsLAs vn0LeORussqv95n92COKdWxJ2F0NrhyWCZjSdPipxMKPfSZrRU10yCdI+46vzkrfQo3kafDfTVA h13HNxo10qT18UH73RAIjxQQ4yC1Ss2XnVe4jaXnA= X-Received: by 2002:a17:907:3ea8:b0:b83:1327:920d with SMTP id a640c23a62f3a-b8e9ec9179dmr398904666b.0.1770284876852; Thu, 05 Feb 2026 01:47:56 -0800 (PST) Received: from localhost (a109-49-32-132.cpe.netcabo.pt. [109.49.32.132]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8ea00435fdsm202409366b.57.2026.02.05.01.47.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Feb 2026 01:47:56 -0800 (PST) From: Rui Miguel Silva X-Google-Original-From: "Rui Miguel Silva" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 05 Feb 2026 09:47:55 +0000 Message-Id: To: "Rachit Dhar" , "Rui Miguel Silva" Cc: "Johan Hovold" , "Alex Elder" , "Greg Kroah-Hartman" , , , Subject: Re: [PATCH v3 4/4] staging: greybus: resolved checkpatch checks for light.c References: <20260204183142.182785-1-rchtdhr@gmail.com> In-Reply-To: <20260204183142.182785-1-rchtdhr@gmail.com> Hey Rachit, Thanks for the patch. And the sending corrections along the path. On Wed Feb 4, 2026 at 6:31 PM WET, Rachit Dhar wrote: > Added comment to mutex declarations, to resolve checkpatch.pl checks. > > Signed-off-by: Rachit Dhar > --- > drivers/staging/greybus/light.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/greybus/light.c b/drivers/staging/greybus/li= ght.c > index e509fdc715db..1f2faa6d545d 100644 > --- a/drivers/staging/greybus/light.c > +++ b/drivers/staging/greybus/light.c > @@ -37,7 +37,7 @@ struct gb_channel { > bool releasing; > bool strobe_state; > bool active; > - struct mutex lock; > + struct mutex lock; /* protects gb_channel->active */ > }; > =20 > struct gb_light { > @@ -59,7 +59,7 @@ struct gb_lights { > struct gb_connection *connection; > u8 lights_count; > struct gb_light *lights; > - struct mutex lights_lock; > + struct mutex lights_lock; /* protects gb_lights->lights */ > }; > =20 This LGTM. Acked-by: Rui Miguel Silva Cheers, Rui > static void gb_lights_channel_free(struct gb_channel *channel); > --=20 > 2.43.0