From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 617CC2C234B for ; Fri, 6 Feb 2026 08:00:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770364851; cv=none; b=gT5UnSu/Jf9tcVZ/s3xcO51RtBC1znjEkJinjWPe2+VZ2ocEO56SSzUmRJ6HO1U9pc36jTOIFQoMvh8MPDXGw/lft1bhQH2AhiqIrBAhoj2Cy8rl0BLG5Jefpw987LcbEIWYh7DWbhBoKRixy8bj1DwWI1NrCUyxW6PjqTuOQ+E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770364851; c=relaxed/simple; bh=AVE5c7GDfxm5QI1oDnrcMiVjSN/g0DzUK2V3+zFV60Q=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:To:From:Subject: References:In-Reply-To; b=UC05wr7eRYbU1Ci98jVcUrxtXD3Jj4+0yZWJJQ/UKy7i9oREGDOxkYBHjM20gVjfFl5hSbAtwsOLLpzIIKQQt3PtRO/hD9xsUCblch46hiPm1hJr/jBdyHW1bJB3vvOru4x9z7rGvpfbnU1GRmE5ZThx2fjSrLZOvUnQqHI/jes= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=xpRdtuSG; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="xpRdtuSG" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 92CB94E4243A; Fri, 6 Feb 2026 08:00:48 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 6523C60729; Fri, 6 Feb 2026 08:00:48 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id B02E8119D1836; Fri, 6 Feb 2026 09:00:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1770364847; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=AVE5c7GDfxm5QI1oDnrcMiVjSN/g0DzUK2V3+zFV60Q=; b=xpRdtuSGEQDBN1WAr+kp9eSqaIIOJghMJiQVKK1fae+njbhoOmYs3RFzoW2hoel93Vwi4v YdDF/C7FbiDBCqNN56eOJ45iAfNyRB05GIf1jNzESfGtjadj7WrDAh9JgVc16HAkGksRgo zbcFw44qqHClK1iLzfWe/kDJDzEBF71+pW2TiVpI0qQElgmO50roLZ7w4Rq2ppXhwTgFoH RdQMrcj4SQo7JBCiH+MV2GxZOL3sWBSczjYVy3PLD3E5rRxRcp1WbL7YEFNJl9c9XYIRDz yIUYuXwsTDuq+vJIAHTsUMpssOU61A1uqH7qYOok6bOq5Dsb2I6rDnzVUuG0lg== Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 06 Feb 2026 09:00:39 +0100 Message-Id: Cc: , To: "Chen Ni" , , , , , , , , , , , , , From: "Luca Ceresoli" Subject: Re: [PATCH v3] drm/bridge: synopsys: dw-dp: Check return value of devm_drm_bridge_add() in dw_dp_bind() X-Mailer: aerc 0.20.1 References: <20260206023015.3876957-1-nichen@iscas.ac.cn> In-Reply-To: <20260206023015.3876957-1-nichen@iscas.ac.cn> X-Last-TLS-Session-Version: TLSv1.3 On Fri Feb 6, 2026 at 3:30 AM CET, Chen Ni wrote: > Return the value of devm_drm_bridge_add() in order to propagate the > error properly, if it fails due to resource allocation failure or bridge > registration failure. > > This ensures that the bind function fails safely rather than proceeding > with a potentially incomplete bridge setup. > > Fixes: b726970486d8 ("drm/bridge: synopsys: dw-dp: add bridge before atta= ching") > Signed-off-by: Chen Ni Reviewed-by: Luca Ceresoli -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com