From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 95090346E56 for ; Fri, 6 Feb 2026 08:03:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770365024; cv=none; b=svB1uQS+X+A+E1kKfaTVOOpFzod/9tHSScr/YVQiBnBAsUSa+GSd/HogNE4/HFWtpHcHeMW+zGkb88GafX/wjZAiWmdpLQrg7PFmHR5mzLx+ryfx7RkVjmQhVS0yxxaUF/YSNuq73LPL03+0IBeue1yKG0NZz70Dc1QXFiWh8UQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770365024; c=relaxed/simple; bh=ogPezs6eTrXi2tdE0iUJohQvI+u9va745K1F4Kf4lS8=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:To:From:Subject: References:In-Reply-To; b=MekCfF3v+0KINDKJwhaG/QbLpIMzV8Y+YppzPTGCoiBXLnOFQUBon/z4q0BdqcpMPaR4hR2hMf0KSMptXEsfAdYVmtIn1dVMf6auskgWclN+0A1jZWongkMuKgz4NkkCcDIHTbkHtDI+LetEmEFrPzvp2Qq1WYmtbCTBdklLd6Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=XkyYYv7Z; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="XkyYYv7Z" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 370904E4243C; Fri, 6 Feb 2026 08:03:42 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 0846C60729; Fri, 6 Feb 2026 08:03:42 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 1CE3E119D198D; Fri, 6 Feb 2026 09:03:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1770365021; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=ogPezs6eTrXi2tdE0iUJohQvI+u9va745K1F4Kf4lS8=; b=XkyYYv7Zte3DH31LLRlrRf3NTMxCRn1EWqBlnXf9gkfP7zNZ5AGvMwW18C2VKT7DFQ+60O lhpJOtz3ZI6HWhey3dGR7DsZk2HPYyJ76+c7UCQOVrCqppQty7Z0ye8MJ8JsA0BNk4BQZZ P7IMsrPZNKVmuq5+Q4HVEggDtI1iFiq0VEdZ5cBo2RKShNza94HF0Y2o9uIXYstYr1sS0q a5/h2t42dlbGdIYWhplvwkAIlVyPeFQ+ieHSfXPgIp0nHzdFosrpSAHQR+2ras/CYlPLnG TswZS/9f1NzKrsZRRZqKSyJxsiGwHv8joPFjQ4OsXOBizd/Uuvw9VSw1hC2DfA== Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 06 Feb 2026 09:03:35 +0100 Message-Id: Cc: , , "Andy Yan" To: "Chen Ni" , , , , , , , , , , , , , From: "Luca Ceresoli" Subject: Re: [PATCH v4] drm/bridge: synopsys: dw-dp: Check return value of devm_drm_bridge_add() in dw_dp_bind() X-Mailer: aerc 0.20.1 References: <20260206040621.4095517-1-nichen@iscas.ac.cn> In-Reply-To: <20260206040621.4095517-1-nichen@iscas.ac.cn> X-Last-TLS-Session-Version: TLSv1.3 Hello Chen, Andy, On Fri Feb 6, 2026 at 5:06 AM CET, Chen Ni wrote: > Return the value of devm_drm_bridge_add() in order to propagate the > error properly, if it fails due to resource allocation failure or bridge > registration failure. > > This ensures that the bind function fails safely rather than proceeding > with a potentially incomplete bridge setup. > > Fixes: b726970486d8 ("drm/bridge: synopsys: dw-dp: add bridge before atta= ching") > Signed-off-by: Chen Ni > Reviewed-by: Andy Yan > --- > Changes in v4: > - Add Reviewed-by tag from Andy Yan As far as I can see Andy reviewed v2, not this version. Andy, if you are OK with this version it'd be great if you could tell it clearly with a Reviewed-by, possibly on v3 which has the exact same diff and commit message. Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com